meta/recipes-bsp/optee-os: correct typo in class inheritance

Message ID 20251205091419.6733-1-srinuvasan.a@siemens.com
State Accepted, archived
Headers show
Series meta/recipes-bsp/optee-os: correct typo in class inheritance | expand

Commit Message

srinuvasan.a Dec. 5, 2025, 9:14 a.m. UTC
From: srinuvasan <srinuvasan.a@siemens.com>

Fixed a typo that caused the optee-os class to not be inherited as expected.

Signed-off-by: srinuvasan <srinuvasan.a@siemens.com>
---
 meta/recipes-bsp/optee-os/optee-os-custom.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jan Kiszka Dec. 5, 2025, 10:40 a.m. UTC | #1
On 05.12.25 10:14, srinuvasan.a@siemens.com wrote:
> From: srinuvasan <srinuvasan.a@siemens.com>
> 
> Fixed a typo that caused the optee-os class to not be inherited as expected.
> 
> Signed-off-by: srinuvasan <srinuvasan.a@siemens.com>
> ---
>  meta/recipes-bsp/optee-os/optee-os-custom.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-bsp/optee-os/optee-os-custom.inc b/meta/recipes-bsp/optee-os/optee-os-custom.inc
> index 1f4ebf7e..b386047d 100644
> --- a/meta/recipes-bsp/optee-os/optee-os-custom.inc
> +++ b/meta/recipes-bsp/optee-os/optee-os-custom.inc
> @@ -5,7 +5,7 @@
>  #
>  # SPDX-License-Identifier: MIT
>  
> -inherir optee-os
> +inherit optee-os
>  
>  do_warn_custom_inc() {
>      bbwarn "Please migrate from \"require recipes-bsp/optee-os/optee-os-custom.inc\" to \"inherit optee-os\""

Oops - good catch. A bit unexpected that this was not caught by the
bitbake parser, though. How did you notice?

Jan
Jan Kiszka Dec. 5, 2025, 10:47 a.m. UTC | #2
On 05.12.25 11:40, Jan Kiszka wrote:
> On 05.12.25 10:14, srinuvasan.a@siemens.com wrote:
>> From: srinuvasan <srinuvasan.a@siemens.com>
>>
>> Fixed a typo that caused the optee-os class to not be inherited as expected.
>>
>> Signed-off-by: srinuvasan <srinuvasan.a@siemens.com>
>> ---
>>  meta/recipes-bsp/optee-os/optee-os-custom.inc | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-bsp/optee-os/optee-os-custom.inc b/meta/recipes-bsp/optee-os/optee-os-custom.inc
>> index 1f4ebf7e..b386047d 100644
>> --- a/meta/recipes-bsp/optee-os/optee-os-custom.inc
>> +++ b/meta/recipes-bsp/optee-os/optee-os-custom.inc
>> @@ -5,7 +5,7 @@
>>  #
>>  # SPDX-License-Identifier: MIT
>>  
>> -inherir optee-os
>> +inherit optee-os
>>  
>>  do_warn_custom_inc() {
>>      bbwarn "Please migrate from \"require recipes-bsp/optee-os/optee-os-custom.inc\" to \"inherit optee-os\""
> 
> Oops - good catch. A bit unexpected that this was not caught by the
> bitbake parser, though. How did you notice?
> 

Ah, that's the compat include - now it's clear :)

Jan
Srinuvasan Arjunan Dec. 5, 2025, 10:51 a.m. UTC | #3
On Fri, Dec 5, 2025 at 4:10 PM 'Jan Kiszka' via isar-users <
isar-users@googlegroups.com> wrote:

> On 05.12.25 10:14, srinuvasan.a@siemens.com wrote:
> > From: srinuvasan <srinuvasan.a@siemens.com>
> >
> > Fixed a typo that caused the optee-os class to not be inherited as
> expected.
> >
> > Signed-off-by: srinuvasan <srinuvasan.a@siemens.com>
> > ---
> >  meta/recipes-bsp/optee-os/optee-os-custom.inc | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-bsp/optee-os/optee-os-custom.inc
> b/meta/recipes-bsp/optee-os/optee-os-custom.inc
> > index 1f4ebf7e..b386047d 100644
> > --- a/meta/recipes-bsp/optee-os/optee-os-custom.inc
> > +++ b/meta/recipes-bsp/optee-os/optee-os-custom.inc
> > @@ -5,7 +5,7 @@
> >  #
> >  # SPDX-License-Identifier: MIT
> >
> > -inherir optee-os
> > +inherit optee-os
> >
> >  do_warn_custom_inc() {
> >      bbwarn "Please migrate from \"require
> recipes-bsp/optee-os/optee-os-custom.inc\" to \"inherit optee-os\""
>
> Oops - good catch. A bit unexpected that this was not caught by the
> bitbake parser, though. How did you notice?
>
> Jan
>
> --
> Siemens AG, Foundational Technologies
> Linux Expert Center
>

  Hi Jan,

     I was checking the latest changes in next, and while going through the
commits, I noticed this.

  Many thanks,
  Srinu

>
> --
> You received this message because you are subscribed to the Google Groups
> "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to isar-users+unsubscribe@googlegroups.com.
> To view this discussion visit
> https://groups.google.com/d/msgid/isar-users/dcf8a2a8-9c0c-4872-8781-376560b965e9%40siemens.com
> .
>
Zhihang Wei Dec. 8, 2025, 1:21 p.m. UTC | #4
Applied to next, thanks.

Zhihang

On 12/5/25 10:14, srinuvasan.a via isar-users wrote:
> From: srinuvasan <srinuvasan.a@siemens.com>
>
> Fixed a typo that caused the optee-os class to not be inherited as expected.
>
> Signed-off-by: srinuvasan <srinuvasan.a@siemens.com>
> ---
>   meta/recipes-bsp/optee-os/optee-os-custom.inc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-bsp/optee-os/optee-os-custom.inc b/meta/recipes-bsp/optee-os/optee-os-custom.inc
> index 1f4ebf7e..b386047d 100644
> --- a/meta/recipes-bsp/optee-os/optee-os-custom.inc
> +++ b/meta/recipes-bsp/optee-os/optee-os-custom.inc
> @@ -5,7 +5,7 @@
>   #
>   # SPDX-License-Identifier: MIT
>   
> -inherir optee-os
> +inherit optee-os
>   
>   do_warn_custom_inc() {
>       bbwarn "Please migrate from \"require recipes-bsp/optee-os/optee-os-custom.inc\" to \"inherit optee-os\""

Patch

diff --git a/meta/recipes-bsp/optee-os/optee-os-custom.inc b/meta/recipes-bsp/optee-os/optee-os-custom.inc
index 1f4ebf7e..b386047d 100644
--- a/meta/recipes-bsp/optee-os/optee-os-custom.inc
+++ b/meta/recipes-bsp/optee-os/optee-os-custom.inc
@@ -5,7 +5,7 @@ 
 #
 # SPDX-License-Identifier: MIT
 
-inherir optee-os
+inherit optee-os
 
 do_warn_custom_inc() {
     bbwarn "Please migrate from \"require recipes-bsp/optee-os/optee-os-custom.inc\" to \"inherit optee-os\""