| Message ID | 20251217083901.1410028-1-anaumann@emlix.com |
|---|---|
| State | Under Review |
| Headers | show |
| Series | [1/1] postproc: Correct typo to image_postprocess_disable_systemd_firstboot | expand |
A sentence here that this typo had no functional impact would have been nice. On 17.12.25 09:39, 'Andreas Naumann' via isar-users wrote: > Signed-off-by: Andreas Naumann <anaumann@emlix.com> > --- > meta/classes-recipe/image-postproc-extension.bbclass | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta/classes-recipe/image-postproc-extension.bbclass b/meta/classes-recipe/image-postproc-extension.bbclass > index b332e826..1aba2ec5 100644 > --- a/meta/classes-recipe/image-postproc-extension.bbclass > +++ b/meta/classes-recipe/image-postproc-extension.bbclass > @@ -80,8 +80,8 @@ image_postprocess_sshd_key_regen() { > fi > } > > -ROOTFS_POSTPROCESS_COMMAND =+ "image_posprocess_disable_systemd_firstboot" > -image_posprocess_disable_systemd_firstboot() { > +ROOTFS_POSTPROCESS_COMMAND =+ "image_postprocess_disable_systemd_firstboot" > +image_postprocess_disable_systemd_firstboot() { > SYSTEMD_VERSION=$(sudo chroot '${ROOTFSDIR}' dpkg-query \ > --showformat='${source:Upstream-Version}' \ > --show systemd || echo "0" ) Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com> Jan
Hello Jan, Am 17.12.25 um 09:51 schrieb Jan Kiszka: > A sentence here that this typo had no functional impact would have been > nice. Good point, should i resend? Andreas > > On 17.12.25 09:39, 'Andreas Naumann' via isar-users wrote: >> Signed-off-by: Andreas Naumann <anaumann@emlix.com> >> --- >> meta/classes-recipe/image-postproc-extension.bbclass | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/meta/classes-recipe/image-postproc-extension.bbclass b/meta/classes-recipe/image-postproc-extension.bbclass >> index b332e826..1aba2ec5 100644 >> --- a/meta/classes-recipe/image-postproc-extension.bbclass >> +++ b/meta/classes-recipe/image-postproc-extension.bbclass >> @@ -80,8 +80,8 @@ image_postprocess_sshd_key_regen() { >> fi >> } >> >> -ROOTFS_POSTPROCESS_COMMAND =+ "image_posprocess_disable_systemd_firstboot" >> -image_posprocess_disable_systemd_firstboot() { >> +ROOTFS_POSTPROCESS_COMMAND =+ "image_postprocess_disable_systemd_firstboot" >> +image_postprocess_disable_systemd_firstboot() { >> SYSTEMD_VERSION=$(sudo chroot '${ROOTFSDIR}' dpkg-query \ >> --showformat='${source:Upstream-Version}' \ >> --show systemd || echo "0" ) > Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com> > > Jan > Andreas Naumann
On 17.12.25 11:05, Andreas Naumann wrote: > Hello Jan, > > Am 17.12.25 um 09:51 schrieb Jan Kiszka: >> A sentence here that this typo had no functional impact would have been >> nice. > > Good point, should i resend? > If you already have the editor open... :) Jan > Andreas > >> >> On 17.12.25 09:39, 'Andreas Naumann' via isar-users wrote: >>> Signed-off-by: Andreas Naumann <anaumann@emlix.com> >>> --- >>> meta/classes-recipe/image-postproc-extension.bbclass | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/meta/classes-recipe/image-postproc-extension.bbclass b/ >>> meta/classes-recipe/image-postproc-extension.bbclass >>> index b332e826..1aba2ec5 100644 >>> --- a/meta/classes-recipe/image-postproc-extension.bbclass >>> +++ b/meta/classes-recipe/image-postproc-extension.bbclass >>> @@ -80,8 +80,8 @@ image_postprocess_sshd_key_regen() { >>> fi >>> } >>> -ROOTFS_POSTPROCESS_COMMAND =+ >>> "image_posprocess_disable_systemd_firstboot" >>> -image_posprocess_disable_systemd_firstboot() { >>> +ROOTFS_POSTPROCESS_COMMAND =+ >>> "image_postprocess_disable_systemd_firstboot" >>> +image_postprocess_disable_systemd_firstboot() { >>> SYSTEMD_VERSION=$(sudo chroot '${ROOTFSDIR}' dpkg-query \ >>> --showformat='${source:Upstream-Version}' \ >>> --show systemd || echo "0" ) >> Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com> >> >> Jan >> > Andreas Naumann >
diff --git a/meta/classes-recipe/image-postproc-extension.bbclass b/meta/classes-recipe/image-postproc-extension.bbclass index b332e826..1aba2ec5 100644 --- a/meta/classes-recipe/image-postproc-extension.bbclass +++ b/meta/classes-recipe/image-postproc-extension.bbclass @@ -80,8 +80,8 @@ image_postprocess_sshd_key_regen() { fi } -ROOTFS_POSTPROCESS_COMMAND =+ "image_posprocess_disable_systemd_firstboot" -image_posprocess_disable_systemd_firstboot() { +ROOTFS_POSTPROCESS_COMMAND =+ "image_postprocess_disable_systemd_firstboot" +image_postprocess_disable_systemd_firstboot() { SYSTEMD_VERSION=$(sudo chroot '${ROOTFSDIR}' dpkg-query \ --showformat='${source:Upstream-Version}' \ --show systemd || echo "0" )
Signed-off-by: Andreas Naumann <anaumann@emlix.com> --- meta/classes-recipe/image-postproc-extension.bbclass | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)