From patchwork Wed Apr 8 06:44:06 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gourav Singh X-Patchwork-Id: 5025 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Wed, 08 Apr 2026 09:19:45 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-qt1-f192.google.com (mail-qt1-f192.google.com [209.85.160.192]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 6387Jhpa019920 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 8 Apr 2026 09:19:44 +0200 Received: by mail-qt1-f192.google.com with SMTP id d75a77b69052e-50b4076dc16sf255605471cf.2 for ; Wed, 08 Apr 2026 00:19:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1775632778; cv=pass; d=google.com; s=arc-20240605; b=NTbrV4sJnyF7uZbWlhwKm5h9DWwQsYkMr2Ocrq8OW8wRgDVoAydXb3LIp22T3evnzs cG3+Rgpc73i1HEvOCLk9nFO26Mgc+OAO/RwhZqhF3hWpD/DUW00aEDFh/GzsY/51AASV QTm22OZXbSyt6gFmwbMGQfwUUf4P9+Oh2rp7WGJX7gzSR6ObTLfYmgOIWh+K27Wwm5Ol FeB5B2Wtg9tIPHPKWDjyEFu5QxiAaumXjvJsc7UWY8jJoa8zB6wbt/TQjSCwnkukgBFv Eb5nReb2seKMHYLh6PiMNwiBmQZKmxomMwGxq/0kuu1GnV4G5Ib2mWlHUJdMvNxZS0xi EenQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Z3rqxeuEvGx+AjTfkZC1Mp58lAz2r0Ci3qr/TJf+x5Q=; fh=+10cHLbRpVW4iP3xpRwgcf50YaOkh/7tsTQ9y7RO7iI=; b=Q/vGvgXPopKThxRwu6wHMGEKwk59mAiTbmXSlZhkcmDMEmm0WnGRW/kZtTgKdFIUFq G4hynD5Y3Wwyj8QdzM0cu6nzRu7mK5kVlun6U+DLLwQmAb9pirKJwzhYuTIlW9qW/hD0 hsDTc6KH8dkKsmd0AUwciNjZlFjQENMGXMarVkWR6VYucOjQYnYmwHtYqqeF7zCmTV+x dC4aLaxr2iRFzES+gepjAZ88ePi65jG4lr61sAYAC22eI/G3NjR9kC3JqHDGkFavVvuN +oRs02GTcuHtp7kSWzDL0gIE2UZ2iGwesZoaAwmAJYE93UoY0vq8sS82B3WjNFSmC5Rt nL8g==; darn=isar-build.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=j27syosb; spf=pass (google.com: domain of fm-1333022-20260408064415291243c6d1000207d0-5rngyx@rts-flowmailer.siemens.com designates 185.136.65.225 as permitted sender) smtp.mailfrom=fm-1333022-20260408064415291243c6d1000207d0-5RNgyx@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20251104; t=1775632778; x=1776237578; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=Z3rqxeuEvGx+AjTfkZC1Mp58lAz2r0Ci3qr/TJf+x5Q=; b=lhwkg9JFe7fxE2xknEjB13OaZBAV4+Qjt+tlQ0qEoCqlI45Y0LN+/A+ekBJWWIHPRN pod/n0OqPWhsH6IC7KM3ayhvJoZ3zpvGDHALFhvbOuEXmg/RkQDboOfIQi/I5TUxN/yb MuM/I3pmpM3lNu+29lRtchwfwkh7YutVSl+BXLGV+UzZOpURup0e5p/0g2TsI+KbBwxM j5IORc84+8rjGKT1spaf1XwQ7LOdzRhwW4k3y2C1Tizu4jb/IcV+Lm0D5b4Grf6aPLjT KszDL+7BbaGEoaLfvzpTq5tYN8yahRKiJ1TSgAVY848E9++B/ga2iVZ38J6wXv8hr2YP PNPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775632778; x=1776237578; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:x-beenthere :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Z3rqxeuEvGx+AjTfkZC1Mp58lAz2r0Ci3qr/TJf+x5Q=; b=i5XGQ86WL6rXM3f+aPpDySxNVZ/x4ZT5Ac16ElBsGu/UqG//O+KttUWU+TjYgKtoQx sIiB5NKELuNVtT9S6/ydZStujXalKkA4pQVBI8t+OaH3z4f7b6Sq2PuRFAhdr7kzm1WK dAUC9Os/2+15gZy4FOTNPNdoVWWTt8g70749LGJOXgrEgQit3yu2Aqrgux+2wsNdu3hZ YHFU3SsNMIw7F3y2P4zr+o1jxs6bDpH/Fg4X/U0JDLXYTMQlB39S/IPA1CLhJde1tbee afc/AhsSmHce2MRrLzdVYB+pkfIAgjsIqqlMg23pPBIv1JCCf7zpr+B6iRQzUbkacK0H Lthw== X-Forwarded-Encrypted: i=2; AJvYcCV5ItZmLAJ1iXpeyxQpIDJ7ef8NeBXzsBk4EyyHMAXms6ZsEvraAD+Uw0LD82qyblldYSO4rnA=@isar-build.org X-Gm-Message-State: AOJu0YxvpagdP0yUX2meOLh3RD8tFfWokOXi2gGvfk0Ac6I3VEXFfggL nWa5z7zfrtBhVPub4H61V+ucXlUSlcF1c1k/zWfyvj1LHuW5W5f/wFF3 X-Received: by 2002:ac8:7d56:0:b0:509:68c:634d with SMTP id d75a77b69052e-50d62614d02mr287958191cf.10.1775632777753; Wed, 08 Apr 2026 00:19:37 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h="AYAyTiLqJzzsl3L7p6aBhE0SJnz0kr8G99T+QJ0aYQOwg913sg==" Received: by 2002:ac8:5d89:0:b0:509:41df:80ff with SMTP id d75a77b69052e-50d4c6c8ddcls110277231cf.2.-pod-prod-06-us; Wed, 08 Apr 2026 00:19:37 -0700 (PDT) X-Received: by 2002:a05:620a:178b:b0:8cf:dfc9:c09c with SMTP id af79cd13be357-8d41b8e3d3bmr2772150885a.10.1775632777314; Wed, 08 Apr 2026 00:19:37 -0700 (PDT) Received: by 2002:a05:6808:2806:b0:46b:22a1:35fc with SMTP id 5614622812f47-46bd6fcb9b4msb6e; Tue, 7 Apr 2026 23:44:18 -0700 (PDT) X-Received: by 2002:a17:90b:4ecc:b0:359:7c55:c166 with SMTP id 98e67ed59e1d1-35de67dcbe1mr19197735a91.7.1775630657609; Tue, 07 Apr 2026 23:44:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1775630657; cv=none; d=google.com; s=arc-20240605; b=YFOBkt6Srxl7o8uYWqIqjXaNmwGd3mMN+v4SNrJnp5PRiGu/Kd2AK9q6NvIJ/u+0zl jY78ygNoCQBWPYdgKzybrKyMBhjTdVSs4MfuOYaNqMpU80fYLNfHMOSedrESXGZdTOif y8zrWtJd5ij8AVIHcgtJF0uYFqFJbcOKJW7cYAY+b0SZzRNhP2lamlDZugutAyawMucs adm5hMLJOgnpb/zBPF1NKew0XISQ9ypvwD8czeasXmqqhp3EfZZs8bNnBER8zklWvd2K hRmTJDXES183umEuTHBwFAKhiY6Zdjt7m/mdM6XVG+wkfRBdHPsNaeTrK4pPvh8OK1LN Vkmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=feedback-id:content-transfer-encoding:mime-version:message-id:date :subject:cc:to:from:dkim-signature; bh=xhFVF4z4VULo4FX0pmMYK1tzPFTI5Q5NAT/4aG4uAlo=; fh=F5B7sHw8QSYpzAgwBsAEFSY7gmjvHKn1s8Oqz1DQh58=; b=l2DOHiyIIC7icHa4+WtBU0flMUw9Q+s3n6jl4cq3oLFnUjnrZTBa4SzO7ZkDRvTXRw CTe7oG7/59O//vy6Em7MladGzmElZVtP6Qt09L3MFrhXeVA5i5IRKHRpQHFT9UHoA+Bw xRYx2zzVNgeSwwrJ9YxQU+H04vb+v9/RQOuFrWqoEiWEpsmAIzCS5tInD8FKfUM5riiy XN9ad1PAe8UpC2dWZnrj6TUzQ7Y6CT59fMjjPFjcEcEZIvfBiW6MoM0+21XpveioFLMv NlUjSww8y33hmoPqqurURKi3TJM9/oT75BDOCNbJCI9DFAelZPkaOyEGVZ/MNsE3EMDs tubQ==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=j27syosb; spf=pass (google.com: domain of fm-1333022-20260408064415291243c6d1000207d0-5rngyx@rts-flowmailer.siemens.com designates 185.136.65.225 as permitted sender) smtp.mailfrom=fm-1333022-20260408064415291243c6d1000207d0-5RNgyx@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-65-225.siemens.flowmailer.net (mta-65-225.siemens.flowmailer.net. [185.136.65.225]) by gmr-mx.google.com with ESMTPS id 98e67ed59e1d1-35dd35e9bd0si580592a91.1.2026.04.07.23.44.17 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Apr 2026 23:44:17 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-1333022-20260408064415291243c6d1000207d0-5rngyx@rts-flowmailer.siemens.com designates 185.136.65.225 as permitted sender) client-ip=185.136.65.225; Received: by mta-65-225.siemens.flowmailer.net with ESMTPSA id 20260408064415291243c6d1000207d0 for ; Wed, 08 Apr 2026 08:44:15 +0200 X-Patchwork-Original-From: "'Gourav Singh' via isar-users" From: Gourav Singh To: isar-users@googlegroups.com Cc: cedric.hombourger@siemens.com, Gourav Singh Subject: [PATCH v2] wic/plugins/bootimg-efi-isar: gate root= with creator.rootdev not None Date: Wed, 8 Apr 2026 12:14:06 +0530 Message-Id: <20260408064406.3396423-1-gouravsingh@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1333022:519-21489:flowmailer X-Original-Sender: gouravsingh@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=j27syosb; spf=pass (google.com: domain of fm-1333022-20260408064415291243c6d1000207d0-5rngyx@rts-flowmailer.siemens.com designates 185.136.65.225 as permitted sender) smtp.mailfrom=fm-1333022-20260408064415291243c6d1000207d0-5RNgyx@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Gourav Singh Reply-To: Gourav Singh Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: Cedric Hombourger Checks for creator.rootdev not being None were missing and would cause the kernel command line to read "root=None". When using the Discoverable Partitions Specification, we really want no root= parameter on the kernel command line (and root=None is anyhow not a valid option). Signed-off-by: Cedric Hombourger Signed-off-by: Gourav Singh --- meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) -- 2.39.5 diff --git a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py index 6bc78d42..6c6698d6 100644 --- a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py +++ b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py @@ -104,7 +104,7 @@ class BootimgEFIPlugin(SourcePlugin): (get_bitbake_var("KERNEL_IMAGETYPE"), get_bitbake_var("INITRAMFS_LINK_NAME")) label = source_params.get('label') - label_conf = "root=%s" % creator.rootdev + label_conf = f" root={creator.rootdev}" if creator.rootdev else "" if label: label_conf = "LABEL=%s" % label @@ -201,7 +201,8 @@ class BootimgEFIPlugin(SourcePlugin): boot_conf += "linux /%s\n" % kernel label = source_params.get('label') - label_conf = "LABEL=Boot root=%s" % creator.rootdev + label_conf = "LABEL=Boot" + label_conf += f" root={creator.rootdev}" if creator.rootdev else "" if label: label_conf = "LABEL=%s" % label @@ -366,7 +367,7 @@ class BootimgEFIPlugin(SourcePlugin): with tempfile.TemporaryDirectory() as tmp_dir: label = source_params.get('label') - label_conf = "root=%s" % creator.rootdev + label_conf = f" root={creator.rootdev}" if creator.rootdev else "" if label: label_conf = "LABEL=%s" % label