From patchwork Tue Apr 21 10:05:25 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gourav Singh X-Patchwork-Id: 5043 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Tue, 21 Apr 2026 12:06:41 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-qv1-f61.google.com (mail-qv1-f61.google.com [209.85.219.61]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 63LA6aRT027820 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 21 Apr 2026 12:06:37 +0200 Received: by mail-qv1-f61.google.com with SMTP id 6a1803df08f44-895375da74bsf6685816d6.0 for ; Tue, 21 Apr 2026 03:06:37 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1776765991; cv=pass; d=google.com; s=arc-20240605; b=AB51DZNB8GmCkyD0emQgBjtbKvP/34jGd7IrR/wUqx0xCe7o7xdAgGRlIvB9I8VvTS UTPeA1sRTFJUdkrUBysPfvRcnc3O5GKK4DL8QfGPqH4BhpdGXwP4nU5f2ksJOXlCPz/S Z3BOvxOEsEcVx+tvmxbQNQIO02VVJ7mzl47/xAlz28VKTXHW95aW3lYwAPCDjiuVpCnk snbDb7yXv8w777Rd9i/qHJKxYB5sjlFBqmocklNU2OeI4igSt8fHjh5Bc/Ga6VBJws4m evRtaYSXtJo7Fj/M1SBUsYw31MVcaOCH+22kFiAFlarTpx5FFfR5FVjzCQUEtEHNsQmH tA9w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Q1NvcNzMU61ad6yhDZtWD4/yaVfQG7SXp6U7OH1BJPk=; fh=6coPEyvkqNTFWpCdQwyFrKogZvRh6GFR/55q3EAS/po=; b=hKgtQ8p42H6fED7In2TiY4yFrpcYVz5QkyqyoxQbG9h9PQr5/3jWQ27Us6N2+9rXwr jttMZ9qLw9A7rT3eTAMHihgb+eMEV3wfcm28BIVfVRA0pMaW8WjPwA6bEXGBlwuD5bkN A7C2ZDtWBAnUFAE1H3qJCnRpujy+f8BdqySnS5Tkz/MFcjnSiirjSXkrlC6NVXL4vlHG RGXLEwMMX57n/7dk9KZkxNY4CQId8atGRf6I0vn9b3Pw5aL1shPd4F+38PkWP4ch8gyG VtHd97lCQ1qSXfR373m2s9raBNCuMZJcN8UxzBjraq/IfCJl0Z6yy5mCXUjWlxiYm89m Q9OQ==; darn=isar-build.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=Qi5eqavt; spf=pass (google.com: domain of fm-1333022-20260421100628a814e9e112000207da-2etq3u@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) smtp.mailfrom=fm-1333022-20260421100628a814e9e112000207da-2ETQ3u@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20251104; t=1776765991; x=1777370791; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=Q1NvcNzMU61ad6yhDZtWD4/yaVfQG7SXp6U7OH1BJPk=; b=A6C/CvQRxUSM5OxD8DE+gOHUlakgPnURMnwcutQMscPzK0gO/p4fM7fAW+i9Ini3mm G4AXAiFIaC7G2plIjLUUIzUPv53yOcWQtYOIRaIwo+i7NE2/wlzAJ7Uu2gqE84jyazxI wpOUCl8NT3t7/9XEUM0ozaEui3M3dnFDGOFctR3IulgTfEVyw1Rn99LIp+Bd+AtU7p+L KjEk85COE1hGrERNirrvHSqoRdh7NZDHRqjpfnuDaWsGbbhy4GAsnYVI2fOYQ91yBQ6B xVQ0Ogt4MhykK6f5le0nthnGB+m3teDBx3bTjYXxZXmk5Z+e2JiMPzR//2Oj8A0eEBAE V14g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776765991; x=1777370791; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:x-beenthere :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q1NvcNzMU61ad6yhDZtWD4/yaVfQG7SXp6U7OH1BJPk=; b=Ul09Ej/LNsTggMYFQHX3jiNRS1JxSAs4yyHXyZVUP1VZ+4ckMwpVO7tHea71EQJK1e U1WQptJKT7eQa02g1va2HJMJsL9+cjkE4dxa2aXdzgYz5O7X1Z0N6sw/ig674AWwsnQd tRORm9NZT/QRapsom9icsokfUHzZeE6hWsXvJ7/qUR43n/cT7TlqSlJm0UJlk49wX6vL lBxA+LY5wHiF5aC/bPKMiaVmj6nmBajLZIv5i/9LC+ZgAKYFvI5axcwOfYeUuu5M6bJi hglu+sKIJFKSBazRgGJCyOzvjbtGrF46tyL6M7eKPYYMG+MbAFkJLSELTgMJZ2bpTZGD m/7A== X-Forwarded-Encrypted: i=2; AFNElJ+ZdQVR660UMzfyVf5uqfXNN6EJrXEmRz1JA02G4rZN8O3zSm8em70nvqxsR3sYlTsiULg/QdM=@isar-build.org X-Gm-Message-State: AOJu0YzmGmIVEcrI/n24Mv89vM4y3aEoxSe0NeFZEe32Y7XTNWAL6f0F eNkVaq/RHaIkfXCoX1n5ytZlLN32ed0o2X4WyQA9aKYcKWFFFun/x+Qb X-Received: by 2002:ad4:5f0f:0:b0:8a5:e0a7:d99a with SMTP id 6a1803df08f44-8b0280f8de0mr190232246d6.3.1776765991108; Tue, 21 Apr 2026 03:06:31 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h="AYAyTiIHUOjNG2nYFO7bBGEYRFp/bujTFlX+enGLTV8DJx/7fA==" Received: by 2002:a05:622a:11c8:b0:509:2a0e:163b with SMTP id d75a77b69052e-50e5f788904ls25219381cf.1.-pod-prod-07-us; Tue, 21 Apr 2026 03:06:30 -0700 (PDT) X-Received: by 2002:a05:620a:4115:b0:8ee:630e:350a with SMTP id af79cd13be357-8ee630e46c3mr272398385a.58.1776765990375; Tue, 21 Apr 2026 03:06:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1776765990; cv=none; d=google.com; s=arc-20240605; b=Dk9AlYyGyz1xare587HX1r8b9eFNkQkWL3tKsrFvSMv/ZBGfJTOIRY87Pq2aelfTUw wY7xFK+6Cw0ZdY3gOBSdCEYAHjFlHqqlySXd3GvTjZnGD/giUuxi/bz2VqIugwXEeJEb O4SDTolBAeyi5B2fRDC022ctmAwsMKOFkihJMfvqHDjOhoDolnQSeFqSgtIl+PrnH0NL 5pGhKgEnE2yyXkTae0qqDt6817B5DshGN7owT4ybNXoC+V+Sj6WkYM45oQbt61KSti3e TkMJIGj/lT7fMw85Ze6zPnCJndC4+f54CSS8Yk00EjUc2ioBcx3806SwLQvaophgejl4 31Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=feedback-id:content-transfer-encoding:mime-version:message-id:date :subject:cc:to:from:dkim-signature; bh=sKXt7Ldvdwn2jW6wkMYMLf7tWH4rUFEAgIr33uj5vUk=; fh=gz0ZrJn6x76gX3XefOAliLWTyygDYYdGT/FXhQYr+zo=; b=BOicy3sKS5kdTJ5ln85RK7gux6bZAXvN3cnucVqb53kp9MMo4K27z4Ba6hQGHpugxX XG/xKDv8L22j/PLUuZDdKsUDdlOZHeO5DMu4BnmXQh7hL9B91LOE8rQ7p7ZDvz3CCFTp Y1ERuZ6NIbg81KDWitoYsnVGfYkt9a2JL5zdlQorup3z5FdRQKdQIIXYwrn2HlkxJIL5 LyIyd3DocJS9h7pCvILYujB+w0Yy77QQ4gUNX3w7a6gnBzyKZ2tdAYkGXWm/Bk4gFmUL rKJremJzTakXllaByt+qoVkAVYFPGN47ssobuh3mctWXrWQxcXMhhwi6VUjjBzQYrrVa 2LdA==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=Qi5eqavt; spf=pass (google.com: domain of fm-1333022-20260421100628a814e9e112000207da-2etq3u@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) smtp.mailfrom=fm-1333022-20260421100628a814e9e112000207da-2ETQ3u@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-64-226.siemens.flowmailer.net (mta-64-226.siemens.flowmailer.net. [185.136.64.226]) by gmr-mx.google.com with ESMTPS id af79cd13be357-8eb3b910bd2si16267485a.6.2026.04.21.03.06.30 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Apr 2026 03:06:30 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-1333022-20260421100628a814e9e112000207da-2etq3u@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) client-ip=185.136.64.226; Received: by mta-64-226.siemens.flowmailer.net with ESMTPSA id 20260421100628a814e9e112000207da for ; Tue, 21 Apr 2026 12:06:28 +0200 X-Patchwork-Original-From: "'Gourav Singh' via isar-users" From: Gourav Singh To: isar-users@googlegroups.com Cc: Gourav Singh Subject: [PATCH] installer-add-rootfs: wait for full target image build via do_build Date: Tue, 21 Apr 2026 15:35:25 +0530 Message-Id: <20260421100525.4066102-1-gouravsingh@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1333022:519-21489:flowmailer X-Original-Sender: gouravsingh@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=Qi5eqavt; spf=pass (google.com: domain of fm-1333022-20260421100628a814e9e112000207da-2etq3u@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) smtp.mailfrom=fm-1333022-20260421100628a814e9e112000207da-2ETQ3u@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Gourav Singh Reply-To: Gourav Singh Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= Previously, the installer depended only on do_image_, which was derived from IMAGE_DATA_POSTFIX (e.g. do_image_wic for wic.zst). This created a hidden ordering assumption that the image type being installed was also the last artifact to be built. This assumption breaks silently when target images include additional build steps that run after the wic image, such as swupdate (.swu) generation. In that case, the installer would start before all artifacts were ready, missing files like the .swu image entirely. Replace the derived do_image_ dependency with do_build, which is the natural synchronization point signaling that a recipe is fully done. This guarantees the installer only starts after all target image artifacts are produced, regardless of which features are enabled. As a result, the get_image_type() helper function is no longer needed and is removed. Signed-off-by: Gourav Singh --- meta-isar/classes-recipe/installer-add-rootfs.bbclass | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/meta-isar/classes-recipe/installer-add-rootfs.bbclass b/meta-isar/classes-recipe/installer-add-rootfs.bbclass index e3777d62..a0bfc893 100644 --- a/meta-isar/classes-recipe/installer-add-rootfs.bbclass +++ b/meta-isar/classes-recipe/installer-add-rootfs.bbclass @@ -57,10 +57,6 @@ def get_mc_depends(d, task): deps.append(f"mc:{installer_mc}:{installer_target_mc}:{image}:{task}") return " ".join(deps) -def get_image_type(suffix): - image_type = suffix.split(".")[0] - return f"{image_type}" - python() { entries = [] @@ -81,5 +77,5 @@ python() { d.setVar("ROOTFS_ADDITIONAL_FILES", " ".join(entries)) } -INSTALLER_TARGET_TASK ??="do_image_${@ get_image_type(d.getVar('IMAGE_DATA_POSTFIX'))}" +INSTALLER_TARGET_TASK ??="do_build" do_rootfs_install[mcdepends] += "${@ get_mc_depends(d, d.getVar('INSTALLER_TARGET_TASK'))}"