From patchwork Tue Apr 21 17:21:47 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gourav Singh X-Patchwork-Id: 5044 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Tue, 21 Apr 2026 19:22:24 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-yx1-f59.google.com (mail-yx1-f59.google.com [74.125.224.59]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 63LHMNxM029787 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 21 Apr 2026 19:22:23 +0200 Received: by mail-yx1-f59.google.com with SMTP id 956f58d0204a3-6501d242e5csf6012607d50.2 for ; Tue, 21 Apr 2026 10:22:23 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1776792137; cv=pass; d=google.com; s=arc-20240605; b=kIwW2e7Eh6sBBJCutc0k+ZoVkt2AhJ4WsJcd5LEnxIjA6WF9IozBpdHYgx68PiGFmN 1Lp8hUvAfepAMUwks59/VuDF9sxP7C/KxTnS4NTdIwmgNYc/nOJQhCOw4LRkxPm8zj+V 87GKaObIJS0GBNbPaI6PkVq7sV6pUEVpRoTl+dytbf9yae8QOQiu8zEmQhHc5ETsOXBr RiESxmsOBXeEJMHav5kPDnQWDB0qpyrrDfR08npo5Ck4wC/xs1DY209NqOWYhihSvJoi 3TzPKHui4pZ8dKzEuszzQ4b3iMRYcY/Ha6pMcZ2ZzPvR4U6dGFwYsUuDiXZVWYhaWwCG MpRQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=JLcOJA7c97WOM1D+WTC4l6PVqQ0iTHCf0o+4Hmb2T/c=; fh=ZKCIz0eFJzeukkoT+209lwKPA7ALwau4zxTtQqfnyHY=; b=c/RRPg0dy43MR1fUNsiFz/lrWw/sBHilvzLkSWuYpWaUnddHGPU7d3ILyb3IWBx3dy npXYOBTmA+V0BOAd6tZt7kj1g+dIyrYdHtC3p5Eod1G7D/psiOgysk8UXbXbenmb6lZR f1PB96KixPP7YY52ju/ZQAHuiN61mcj2A0lj1gXKztxcQiyMdcBFAD6LhZo+damJxIJP Zp5Ugp7003AGSVm8puXDQZgtkKE/XyhY/BK59x/DwFRBLyS8bsplNneUEMigrVQJ58r+ d/87UzG7a9AxN2dQYIGGYCdjF3zwsFyr/qCzfcSDUEDGHvuDbDg0NJi4HhdCe+/FuhJ9 aiQA==; darn=isar-build.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=F4ocxlOq; spf=pass (google.com: domain of fm-1333022-20260421172214942567365200020731-zhlpba@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) smtp.mailfrom=fm-1333022-20260421172214942567365200020731-ZhlPBa@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20251104; t=1776792137; x=1777396937; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=JLcOJA7c97WOM1D+WTC4l6PVqQ0iTHCf0o+4Hmb2T/c=; b=B+rG9SVM87A9vUxsVVpc/9jzChS1WsQgcuxMFA1om9s+rN5K5IZHaysLheN285ZIrC JfVsSUQuWp7ePKqVrQUz0W6zcNCkyJXbnpCbTZGteAn5DuGLk7Kyc06sAwgLvlo1nFuW HWHLBuN7IT8QMEvvKvFzgqTjZqBk5ArrlGi+d32jvGueG/cBtuIHcr3O8qeMJ6VMUNdj NkNBvHQ39vEMNeK2TFyjyqMphsYXVIVdRAGvKX+pRNfEA4+OUDm/9KsT04tULPyNfSDA M3WPUJiErEgAyp5eC3I1Pzc04IvlgYgJkywRRH+Y8R6VXgoCK51X8oCHEcAzzsamWSLb uGkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776792137; x=1777396937; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:x-beenthere :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JLcOJA7c97WOM1D+WTC4l6PVqQ0iTHCf0o+4Hmb2T/c=; b=dszSXTvJxGzGL811aSUxdj0cWqJX+sdnFD4gs3b+DAor+NfvuFAqW82aDcOgxY9x+r ++21fK+Q86sBf3wFlw2zpEYA8LHjbB/D28MjcchonVhol0mvNmwrvvMzPtdcOZ+r9MGR ioIEoEOF4myDTAO2AMCHkD/edwrLbcmpD9Ce1GNEMA62tI3RV8UCuVPT7if0MPYVZCvq GgT/rpOGUHPSVxRbss2xpKfIU0IzA7EColeFP/A9pBhF9g2TqX3zirYVq6chzGb1VO/O s6fw24/OJ9NNlcXr8bNjrHrrEZ1OXbAcDQnwxVMRaHkn4j3nghK+THSPNG/6/Rokg25J KEQQ== X-Forwarded-Encrypted: i=2; AFNElJ/LD95oL+zDuy6ZEO54y8yQqWMbxZb1/9lQ0nuYkSVmn18Kcqzg6JKFZHUvHDw7Kn22Q0D8jSo=@isar-build.org X-Gm-Message-State: AOJu0YzSXPCnThw+62GLJTbgnc0afKVUdhIUSIG0wNF+A87ssOTdlHWT MpPFNrc/CH/M5U6NvLpp96Mw9eL9QS1DFmGVwi3AYX4FdvvUvV8lpXwV X-Received: by 2002:a05:690e:4811:b0:64a:f163:1554 with SMTP id 956f58d0204a3-653108380d0mr11185819d50.14.1776792137427; Tue, 21 Apr 2026 10:22:17 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h="AYAyTiKkARtROkJHz1YVKXubWrDe7l+6s9FPkPQ6CO4f15lbLw==" Received: by 2002:a53:e30f:0:b0:652:f9fe:d29e with SMTP id 956f58d0204a3-652f9fee05als4340983d50.1.-pod-prod-07-us; Tue, 21 Apr 2026 10:22:16 -0700 (PDT) X-Received: by 2002:a53:c803:0:b0:650:1d21:d6af with SMTP id 956f58d0204a3-65310a0bdc5mr12328108d50.40.1776792136358; Tue, 21 Apr 2026 10:22:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1776792136; cv=none; d=google.com; s=arc-20240605; b=b3VwBjWLOKY3qjK2Yjg0GTVrQiZSuWL9EZKfh2XgbYrJwjcdvYcF+YEEcaQ1apBgpg n6a1HIdgSllhknTpixecw34P/eBQjj8TQaKhjukpaV5r3vLoQm+Y/ITgfy58xyb7EuEK WTw8pVU01cdF93O1n8G46iQjKpaWhi+dZuC4ljf3dVm1tAXYzK0jOXijgoboTOuo/e6A jtlktJcqzJIB8ItvnO4xO95q7XWye3kWDj/DGtD4NLyoy8UQ5zqbuSuGX7TN66HfeGUO oe5YhMYmpGWsQlhGkSwFziVUYzJ67UNM0tt/o4fAZk9oxnELbpyApWoHrZ84AfyVNKEt ELSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=feedback-id:content-transfer-encoding:mime-version:message-id:date :subject:cc:to:from:dkim-signature; bh=/SfzGuJTiRaj/wBDMWxrffDpJjerTI5pFbFX6nei16A=; fh=gz0ZrJn6x76gX3XefOAliLWTyygDYYdGT/FXhQYr+zo=; b=bk2rlyRllg9ZC+rSHIpyk7BKLHagvhIXNucUNBaIihJIT8x7riFQTtjM8e7c/fJC0A tF3aT+AhxtEkUZYpxngz78i1bKaqZTcZxM7KiSwkW457ziKbVGfLypt2Xph1Z3ifG61n 3KO0+4H1Ok6+N9KALW+03tAGKaDDGmVX31a5IrILPzFs1jKN55nIsMbyKAUfXyjxVbLA 0+4U1D6Os0JuVycVJdW25//9vCnrNnx3ijhN99EfXwekdWgXNrP76k8YtLomFOUv8Gx4 DQ7jU2Qcx+cFp37eyQU7eT7qhIgGiN/Sb9Aa0+bAlvwHV4xgLr4l75Y5kC6LRf++iQL6 se5A==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=F4ocxlOq; spf=pass (google.com: domain of fm-1333022-20260421172214942567365200020731-zhlpba@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) smtp.mailfrom=fm-1333022-20260421172214942567365200020731-ZhlPBa@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-64-225.siemens.flowmailer.net (mta-64-225.siemens.flowmailer.net. [185.136.64.225]) by gmr-mx.google.com with ESMTPS id 956f58d0204a3-65314dafc43si475095d50.6.2026.04.21.10.22.16 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Apr 2026 10:22:16 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-1333022-20260421172214942567365200020731-zhlpba@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) client-ip=185.136.64.225; Received: by mta-64-225.siemens.flowmailer.net with ESMTPSA id 20260421172214942567365200020731 for ; Tue, 21 Apr 2026 19:22:14 +0200 X-Patchwork-Original-From: "'Gourav Singh' via isar-users" From: Gourav Singh To: isar-users@googlegroups.com Cc: Gourav Singh Subject: [PATCH v2] installer-add-rootfs: wait for full target image build via do_build Date: Tue, 21 Apr 2026 22:51:47 +0530 Message-Id: <20260421172147.4077796-1-gouravsingh@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1333022:519-21489:flowmailer X-Original-Sender: gouravsingh@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=F4ocxlOq; spf=pass (google.com: domain of fm-1333022-20260421172214942567365200020731-zhlpba@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) smtp.mailfrom=fm-1333022-20260421172214942567365200020731-ZhlPBa@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Gourav Singh Reply-To: Gourav Singh Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= Previously, the installer depended only on do_image_, which was derived from IMAGE_DATA_POSTFIX (e.g. do_image_wic for wic.zst). This created a hidden ordering assumption that the image type being installed was also the last artifact to be built. This assumption breaks silently when target images include additional build steps that run after the wic image, such as swupdate (.swu) generation. In that case, the installer would start before all artifacts were ready, missing files like the .swu image entirely. Replace the derived do_image_ dependency with do_build, which is the natural synchronization point signaling that a recipe is fully done. This guarantees the installer only starts after all target image artifacts are produced, regardless of which features are enabled. As a result, the get_image_type() helper function is no longer needed and is removed. Fixes: a7364ea ("installer-add-rootfs: build target image for image data postfix") Signed-off-by: Gourav Singh --- meta-isar/classes-recipe/installer-add-rootfs.bbclass | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) -- 2.39.5 diff --git a/meta-isar/classes-recipe/installer-add-rootfs.bbclass b/meta-isar/classes-recipe/installer-add-rootfs.bbclass index 69d87be8..111506df 100644 --- a/meta-isar/classes-recipe/installer-add-rootfs.bbclass +++ b/meta-isar/classes-recipe/installer-add-rootfs.bbclass @@ -56,10 +56,6 @@ def get_mc_depends(d, task): deps.append(f"mc:{installer_mc}:{installer_target_mc}:{image}:{task}") return " ".join(deps) -def get_image_type(suffix): - image_type = suffix.split(".")[0] - return f"{image_type}" - python() { entries = [] @@ -80,5 +76,5 @@ python() { d.setVar("ROOTFS_ADDITIONAL_FILES", " ".join(entries)) } -INSTALLER_TARGET_TASK ??="do_image_${@ get_image_type(d.getVar('IMAGE_DATA_POSTFIX'))}" +INSTALLER_TARGET_TASK ??="do_build" do_rootfs_install[mcdepends] += "${@ get_mc_depends(d, d.getVar('INSTALLER_TARGET_TASK'))}"