[v4] image-postproc: ignore systemd preset failures

Message ID 20260427042148.945434-1-badrikesh.prusty@siemens.com
State New
Headers show
Series [v4] image-postproc: ignore systemd preset failures | expand

Commit Message

Badrikesh Prusty April 27, 2026, 4:21 a.m. UTC
Add '|| true' to systemd preset invocation during image postprocessing
to tolerate failures caused by already-masked units.

Fixes: 72b88a12 ("classes/image-postproc: Enable systemd units based on systemd presets")

Signed-off-by: Badrikesh Prusty <badrikesh.prusty@siemens.com>
---
 meta/classes-recipe/rootfs.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.47.3

Comments

Jan Kiszka April 27, 2026, 9:59 a.m. UTC | #1
On 27.04.26 06:21, Badrikesh Prusty wrote:
> Add '|| true' to systemd preset invocation during image postprocessing
> to tolerate failures caused by already-masked units.
> 
> Fixes: 72b88a12 ("classes/image-postproc: Enable systemd units based on systemd presets")
> 
> Signed-off-by: Badrikesh Prusty <badrikesh.prusty@siemens.com>
> ---
>  meta/classes-recipe/rootfs.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes-recipe/rootfs.bbclass b/meta/classes-recipe/rootfs.bbclass
> index 8b502a50..adb6c614 100644
> --- a/meta/classes-recipe/rootfs.bbclass
> +++ b/meta/classes-recipe/rootfs.bbclass
> @@ -574,7 +574,7 @@ image_postprocess_populate_systemd_preset() {
>          --show systemd || echo "" )
> 
>      if (test "$SYSTEMD_INSTALLED" = "installed"); then
> -        sudo chroot '${ROOTFSDIR}' systemctl preset-all --preset-mode="enable-only"
> +        sudo chroot '${ROOTFSDIR}' systemctl preset-all --preset-mode="enable-only" || true

A better pattern than "|| true" is

[ masked ] || systemctl ...

Jan

Patch

diff --git a/meta/classes-recipe/rootfs.bbclass b/meta/classes-recipe/rootfs.bbclass
index 8b502a50..adb6c614 100644
--- a/meta/classes-recipe/rootfs.bbclass
+++ b/meta/classes-recipe/rootfs.bbclass
@@ -574,7 +574,7 @@  image_postprocess_populate_systemd_preset() {
         --show systemd || echo "" )

     if (test "$SYSTEMD_INSTALLED" = "installed"); then
-        sudo chroot '${ROOTFSDIR}' systemctl preset-all --preset-mode="enable-only"
+        sudo chroot '${ROOTFSDIR}' systemctl preset-all --preset-mode="enable-only" || true
     fi
 }