From patchwork Thu May 14 09:19:46 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kasturi shekar X-Patchwork-Id: 5077 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Thu, 14 May 2026 11:20:01 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-ed1-f61.google.com (mail-ed1-f61.google.com [209.85.208.61]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 64E9JnlX025756 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 14 May 2026 11:19:49 +0200 Received: by mail-ed1-f61.google.com with SMTP id 4fb4d7f45d1cf-67c3d3a11cesf7326211a12.0 for ; Thu, 14 May 2026 02:19:49 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1778750384; cv=pass; d=google.com; s=arc-20240605; b=QFLE2I9e4zM05GlGoTLXc0Q7864II8DjNjrAfvvoGP7UMA41s/y/IZjzUAVwhREtNB wsl3mhmsKKup8l/uAbnUy4NsKsZxvjJmLmEwyo51BqbrhCIYJQQDEUsr9Dbcm0DvCQVs ddtUSQT3pCSEbwCQV5tXVzf8Zcj/8mq5m1Bk+vE/M8WzeI75UUAfw7A5KwqcVRGNdl64 oqPnxBdDTeH2DUviSQhyptTm0iHhWlidM85Qb2u1kfw6huAEnxRzQ9wDrcUYw47JogsW yoiht6rTHctxEqG7ufWCAOzDeRxxKUKxD5OAvdkOOMBQ/ySIqWK3ud0tQ/FNIUf7xSkt 2ydw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=QVA2m+EhOw3NgG34l3zorDOtOTmAUbx5rgTIgv4mCio=; fh=dmpTWkS4cVOv2RndLOl7S8ASiA48t5GLW/7XAJ8I/qM=; b=jJxsg8zzbj3oVeSXQUma0KzqudOef+yfKzWTZMS9HpqpN8W2UiB3Nti5me8IU4C8Sr 5PlsZhzDK2WN9TUVhnDOvcXFk2BypaPL+4XKvOVaKnEkNrKXt/vbmihS28wYZDF5AV/9 hnQXqZHBp+0ik5gdkndxsVy5dEmquwSolwLalGQGNWsQiLUK6F8WRAPkTHXKSxDstkcp TfFkt9Y7SAsgMcx1dcIqqOyr9BDgWxJVgZZqP08E14RKFZzyhZeoPssXRF1GIX1wO9Sa WGI4rljX9GN2ppQs7utOXXPjrv0Vw/2siZl1f8Mstzrobi1Gb88lzunLRPhwQY1918VD YSZg==; darn=isar-build.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=RY0m8nJM; spf=pass (google.com: domain of fm-1328757-20260514091940dd025137920002078f-bcfpro@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) smtp.mailfrom=fm-1328757-20260514091940dd025137920002078f-bcFpRO@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20251104; t=1778750384; x=1779355184; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QVA2m+EhOw3NgG34l3zorDOtOTmAUbx5rgTIgv4mCio=; b=kVDnktj+W1F7wFnhJnU5IC0MsgFbz3sSdCMnY5yzrcbey2OcrVbHzYgwpg9KQlKHL0 ZE2YcOWpdSFb9Wpscd1POl78i+4BpiY6VIVKW9fejr6m25CflWZ7Ql8IdEMkacCdygFL yTkoQ68zFg45bc5VbHL0empDwfHNPDjOKeGztj5wxnwQLhlbqMM+pIbVBXQVDpy79gOI XO30rqS2bFk4CDWFYNmesxpKbfwchx8liGzE/Hh3DMIjoVHxSiG+4co0qJWq1KsMQGPM GXBDdjznlU7NxuetuR/43erWJpkQD/Pd7mJmKcgOWSjlutdM3EtFrhbridJwMOWDZTju Z90w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778750384; x=1779355184; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-beenthere:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=QVA2m+EhOw3NgG34l3zorDOtOTmAUbx5rgTIgv4mCio=; b=g113GoZeHuKhVI0MK38E/FTTEknB4KHjkL9VBmnFwqL8VSzITPFiXHt8DhZy5RwbwJ mlwnxat4oReNlERzw31YZwm2yWAAGN7jwtMhMnToBKx3qrRwU9rouz3X8u0NBfvGdvAs oLP2u3Z+HF0Jw0Uc4fWrXffv8fm+NQmA3GlRhKVlJ/FmA89OvW8CRmbGsnZOA2SVQssV uuyeRsQjid6lLiZq8TNCxjzerAnmo9uZe3OdOjvyMWzp5pk1mCU7pL2kbCNxHJ4zBZ3i RV/z35iRRqba1ik9WeiW8er+KmVwnSwP57AxWdWdfR+/M3ZUjOSZKZ0qFrOz/96w7UQO Ty7g== X-Forwarded-Encrypted: i=2; AFNElJ/0+WI9pYqH2PM66gcaJJeqgatSdGZCT2CQSa3bvaRIWLvVejl7vdV/kmRan4tQQl7ktURYXzw=@isar-build.org X-Gm-Message-State: AOJu0YxqcbkQOLL3jK4AXXzCRJalG1lQLB80EgZ5ARFfkwaAqYtyqAp0 x9F701MXVLGrB/fCnRZLZ6FN8nHUAh0ttDDr1xoSn8f6aAChyfYIVooo X-Received: by 2002:aa7:cd55:0:b0:676:9c8e:fa4f with SMTP id 4fb4d7f45d1cf-68256d5e76bmr3173818a12.20.1778750383820; Thu, 14 May 2026 02:19:43 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h="AUV6zMOkdFIaBDPNBA0uVHexAW+t0TxevkYp6Qvc82T19yn+JA==" Received: by 2002:aa7:cad6:0:b0:676:4ba3:ec04 with SMTP id 4fb4d7f45d1cf-6833048a156ls634231a12.2.-pod-prod-01-eu; Thu, 14 May 2026 02:19:41 -0700 (PDT) X-Received: by 2002:a05:6402:405c:20b0:66a:8002:fe17 with SMTP id 4fb4d7f45d1cf-68256c5aa7fmr3247352a12.13.1778750381558; Thu, 14 May 2026 02:19:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1778750381; cv=none; d=google.com; s=arc-20240605; b=JC/61Mudv98zgTKRVsaUwPVT0WoYITa3TUt7wG0sw71Wr86cAxtOz/2mt5g7xzX6S3 5+1qCFxK7RoKyDttnjrGLgAGSdwP09GJM49VZ5yEFck+8ne+FDmFHG9eY2JaMjA6IKGO kNZEPn1764vCFZHBQ+ASqxRdSgi3UgRjyXQroB/XPaDsYfC4P/1nsHg7IG7ScOFMj968 SA8vShoynNXuV2ILZpKwFMbSndfbtPvj3xs+7+MBgT7v/SNiE78K83qFnlwDFEQReXUm Cvy6Mn/2hzRZ3dj4AFuecE6KmN5tulnkbv4VWT2JiLQeVKCDTd1aVRXygl3e6T/oTon+ FJPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=feedback-id:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=ukvus698i4Fg7M59mfl1qbqT+qDigW87Jl2QKddtQxI=; fh=pR4tJPO4NbHlIB/rP4bIo54Z1zh5hd/ksAGQ0tcKkYM=; b=F84oLNH9VJLKyMnfdWUxQl93BoXoLYsJNAOYJmM3hq+KrzYh/6rx0j1PS7tJuL04dH VoqQBB8irCTfifGIHm0ARPiOAx+v8ZCHIwkuwbFbVcltsl4qJb/pXJj83Tn4oYsZ/2Vk J1V3RXqYoHkVar7MfFHISBLVDc/vSHp9RsoJuupB2Vx7hfusDZ+3EDnEoFDKST04mXdm 0gU1a4LLKn90bAgESP5ShI6GLt88Yu5bDcP/bdvA+X06XR2v2PHg7kQcEOmvHrw6yoiI vT7eyRAd6dNcA2UGwbuPw4P4pJp5EGwvoLvUGaC31HWFXleZ3XDp3hEWodFPVugclr7s x/VQ==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=RY0m8nJM; spf=pass (google.com: domain of fm-1328757-20260514091940dd025137920002078f-bcfpro@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) smtp.mailfrom=fm-1328757-20260514091940dd025137920002078f-bcFpRO@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-64-226.siemens.flowmailer.net (mta-64-226.siemens.flowmailer.net. [185.136.64.226]) by gmr-mx.google.com with ESMTPS id 4fb4d7f45d1cf-68311058e41si41827a12.4.2026.05.14.02.19.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 May 2026 02:19:41 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-1328757-20260514091940dd025137920002078f-bcfpro@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) client-ip=185.136.64.226; Received: by mta-64-226.siemens.flowmailer.net with ESMTPSA id 20260514091940dd025137920002078f for ; Thu, 14 May 2026 11:19:41 +0200 X-Patchwork-Original-From: "'Kasturi shekar' via isar-users" From: Kasturi shekar To: isar-users@googlegroups.com Cc: Kasturi Shekar Subject: [PATCH v2 2/4] installer: extract attended UI to installer_ui.sh Date: Thu, 14 May 2026 14:49:46 +0530 Message-ID: <20260514091951.1572682-3-kasturi.shekar@siemens.com> In-Reply-To: <20260514091951.1572682-1-kasturi.shekar@siemens.com> References: <20260427063957.603123-4-kasturi.shekar@siemens.com> <20260514091951.1572682-1-kasturi.shekar@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1328757:519-21489:flowmailer X-Original-Sender: kasturi.shekar@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=RY0m8nJM; spf=pass (google.com: domain of fm-1328757-20260514091940dd025137920002078f-bcfpro@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) smtp.mailfrom=fm-1328757-20260514091940dd025137920002078f-bcFpRO@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Kasturi shekar Reply-To: Kasturi shekar Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: Kasturi Shekar Move attended dialog interactions into installer_ui.sh The new UI module provides: - image selection menu - target device selection menu - install and overwrite confirmation dialogs - error and info dialogs - attended progress gauge hooks Signed-off-by: Kasturi Shekar --- .../files/usr/bin/installer_ui.sh | 217 +++++++++++++----- 1 file changed, 161 insertions(+), 56 deletions(-) mode change 100755 => 100644 meta-isar/recipes-installer/deploy-image/files/usr/bin/installer_ui.sh diff --git a/meta-isar/recipes-installer/deploy-image/files/usr/bin/installer_ui.sh b/meta-isar/recipes-installer/deploy-image/files/usr/bin/installer_ui.sh old mode 100755 new mode 100644 index 33685c6f..9d3ba5de --- a/meta-isar/recipes-installer/deploy-image/files/usr/bin/installer_ui.sh +++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/installer_ui.sh @@ -1,86 +1,191 @@ #!/usr/bin/env bash +# This software is a part of ISAR. +# Copyright (C) Siemens AG, 2026 # -# installer_ui.sh — Attended installer frontend -# ------------------------------------------------ +# SPDX-License-Identifier: MIT -SCRIPT_DIR="$(CDPATH= cd -- "$(dirname -- "$0")" && pwd)" -INSTALL_DATA=${INSTALL_DATA:-./install} +#-------------------------------------------------------------------------- +# installer_ui.sh - Frontend/UI helpers for isar installer. +# +# This file is intentionally UI-only: +# - dialog menus and message boxes +# - attended confirmations +# - user abort countdown handling +#-------------------------------------------------------------------------- +UI_GAUGE_PID="" + +#-------------------------------------------------------------------------- +# ui_show_error +# +# Displays an error dialog in attended mode. +#-------------------------------------------------------------------------- +ui_show_error() { + local message="$1" + dialog --msgbox "$message" 6 60 +} -# Backend APIs -. "$SCRIPT_DIR/sys_api.sh" +#-------------------------------------------------------------------------- +# ui_show_info +# +# Displays an informational dialog in attended mode. +#-------------------------------------------------------------------------- +ui_show_info() { + local message="$1" + dialog --msgbox "$message" 6 60 +} + +#-------------------------------------------------------------------------- +# ui_countdown_allow_attended_switch +# +# In unattended mode, this gives users a chance to switch to attended +# mode by pressing any key. Returns 0 when attended mode should be +# used, and 1 otherwise. +#-------------------------------------------------------------------------- +ui_countdown_allow_attended_switch() { + local timeout="$1" + local abort_file="$2" + local i + + # Countdown loop prints a message once per second and accepts a key press. + # If any key is pressed, create the abort trigger file for the caller. + for ((i=timeout; i>0; i--)); do + echo -ne "\rUnattended installation will start in $i seconds. Press any key to switch to attended mode..." + + if [ -f "$abort_file" ] || read -n 1 -t 1; then + touch "$abort_file" + echo + return 0 + fi + done -# ------------------------------------------------ -# Helpers -# ------------------------------------------------ -die() { - dialog --msgbox "$1" 6 60 - exit 1 + echo + return 1 } -# ------------------------------------------------ -# UI: Select image -# ------------------------------------------------ -ui_select_image() { - local images json list=() +#-------------------------------------------------------------------------- +# ui_select_image_menu +# +# Uses sys_list_installable_entries backend API and returns selected +# relative image path on stdout. +#-------------------------------------------------------------------------- +ui_select_image_menu() { + local install_data_dir="$1" + local list=() + local entry + local selected - # On failure, show error dialog and exit - json=$(sys_locate_disk_images search_path="$INSTALL_DATA") || \ - die "No installable images found in $INSTALL_DATA" + while IFS= read -r entry; do + [ -n "$entry" ] || continue + list+=("$entry" "$entry") + done < <(sys_list_installable_entries "$install_data_dir") - # Extract image paths from JSON - images=$(echo "$json" | sed -n 's/.*"images":\[\(.*\)\].*/\1/p' | tr -d '"' | tr ',' '\n') + if [ "${#list[@]}" -eq 0 ]; then + return 1 + fi - # Building dialog menu entries - for img in $images; do - base=$(basename "$img") - list+=("$img" "$base") - done + selected=$(dialog --no-tags \ + --menu "Select image to be installed" 12 70 6 \ + "${list[@]}" --output-fd 1) || return 2 - # Display menu and capture selection - INSTALL_IMAGE=$(dialog --no-tags \ - --menu "Select image to install" 10 70 5 \ - "${list[@]}" \ - --output-fd 1) || exit 0 + echo "$selected" + return 0 } -# ------------------------------------------------ -# UI: Select target device -# ------------------------------------------------ -ui_select_target_device() { +#-------------------------------------------------------------------------- +# ui_select_target_device_menu +# +# Displays candidate target devices and returns selected /dev path. +#-------------------------------------------------------------------------- +ui_select_target_device_menu() { local list=() + local target + local target_size + local state + local selected - devices=$(sys_list_valid_target_devices) || \ - die "No valid target devices found" + for target in "$@"; do + [ -b "$target" ] || continue - for dev in $devices; do - [ -b "$dev" ] || continue + target_size=$(sys_device_size "$target") + [ -n "$target_size" ] || target_size="unknown" - size=$(lsblk --nodeps --noheadings -o SIZE "$dev" 2>/dev/null | tr -d " ") - [ -z "$size" ] && size="unknown" - - if cmp /dev/zero "$dev" -n 1M >/dev/null 2>&1; then + # Indicate whether the selected device is already empty, to help users + # avoid accidental overwrite of data. + if sys_device_is_empty "$target"; then state="empty" else state="contains data" fi - list+=("$dev" "$dev ($size, $state)") + list+=("$target" "$target ($target_size, $state)") done - if [ "${#list[@]}" -lt 2 ]; then - die "no installable target devices available" + if [ "${#list[@]}" -eq 0 ]; then + return 1 fi - TARGET_DEVICE=$(dialog --no-tags \ - --menu "Select target device" 10 70 6 \ - "${list[@]}" \ - --output-fd 1) || exit 0 + selected=$(dialog --no-tags \ + --menu "Select device to install image to" 12 70 6 \ + "${list[@]}" --output-fd 1) || return 2 + + echo "$selected" + return 0 } -run_interactive_installer() { - clear - ui_select_image - ui_select_target_device +#-------------------------------------------------------------------------- +# ui_confirm_install +# +# Returns: +# 0 when user confirms, 1 when canceled. +#-------------------------------------------------------------------------- +ui_confirm_install() { + local image_path="$1" + local target_device="$2" + local target_size="$3" + + dialog --yes-label Ok --no-label Cancel \ + --yesno "Start installing\n'$image_path'\nto $target_device (capacity: $target_size)" 8 70 +} + +#-------------------------------------------------------------------------- +# ui_confirm_overwrite +# +# Returns: +# 0 when user accepts overwrite, 1 when canceled. +#-------------------------------------------------------------------------- +ui_confirm_overwrite() { + dialog --defaultno --yesno "WARNING: Target device is not empty! Continue anyway?" 8 70 +} + +#-------------------------------------------------------------------------- +# ui_start_progress_gauge +# +# Opens a dialog gauge and updates it from bmaptool psplash pipe. +#-------------------------------------------------------------------------- +ui_start_progress_gauge() { + local pipe_path="$1" + + ( + while true; do + if read -r line < "$pipe_path"; then + percentage=$(echo "$line" | awk '{ print $2 }') + echo "$percentage" + fi + done + ) | dialog --gauge "Flashing image, please wait..." 10 70 0 & + + UI_GAUGE_PID=$! +} + +#-------------------------------------------------------------------------- +# ui_stop_progress_gauge +# +# Best-effort termination of the active progress gauge process. +#-------------------------------------------------------------------------- +ui_stop_progress_gauge() { + if [ -n "$UI_GAUGE_PID" ]; then + kill "$UI_GAUGE_PID" 2>/dev/null || true + UI_GAUGE_PID="" + fi } -run_interactive_installer