From patchwork Mon Jun 8 05:17:33 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kasturi shekar X-Patchwork-Id: 5113 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Mon, 08 Jun 2026 07:19:54 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-pf1-f185.google.com (mail-pf1-f185.google.com [209.85.210.185]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 6585Jqv3028730 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 8 Jun 2026 07:19:53 +0200 Received: by mail-pf1-f185.google.com with SMTP id d2e1a72fcca58-84233efcaadsf2663914b3a.1 for ; Sun, 07 Jun 2026 22:19:53 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1780895986; cv=pass; d=google.com; s=arc-20240605; b=jdvgWhfLtvDPDvtG/AgkAC9tGcR5fZT13jW5JRoRT3wlSr5xW8trabG6oYiAiiwhlr GqbG1jPqLt55948ZcSVzstpkhZYMysr/N+OHBq9agZGQgh32xc0Dw3GVNrpyW2XWdUKQ osQGGlTx6/SDGCY027J7sXX0ojWhhoXZW5FPaasbZRPWtejJVI/HqdEpmVdHsfheT42C wjDvLhKlg7KNtoN1r79gn62segsWGNFIQhY+Y1uQhr2RcfXP60R4/cLMWpm17vwI8u9G g6X/cJsbK/n6KyOhrOc7b4xm6290EQRuSYw/DZGp4aUvO6JlhQyjFjGdkJa8grgQhY6I XLmw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=AH7IJhIl84+WWLyMRh3Zr/MTar123JOnWd/rqpQ0tPk=; fh=PA7lPSmjv6cLiR9mJJySE7V6AaaeLBiHs7YtOOq3OyM=; b=kCHyajR0ydEtRM8DFCC7S4ORXRCCEw8l/V8yJmWNRDdAn0ArT5wi0bThRV4NdqduBb wzV7If50axrFX2/7Oqwwm6Xe7TPPPjOphHIxy0ioTxKVW42SM/xQIEJX5iX57TFIdgPd iKxP+aXnbUNI8p1mD7ePG/fhFSwySvRqYhUNgjFjR92X4xo24+TTgOLXTC5zNnUk1O2y 9k0Kw6yLz0ml6TFEOH03lKLL4RVM8sxsSEM1gVzM3qVREGG1dmYxcG/AtW7IAGK/AqUQ T5l5e2vAe19yc95v0beGgFd0nCKNyix//MjmzLkTpCkH4g3JOY/cusrwP1GmJhrKgHRV cTgw==; darn=isar-build.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=Pwd4IqZy; spf=pass (google.com: domain of fm-1328757-2026060805194353b1824e4700020751-x0cbrw@rts-flowmailer.siemens.com designates 185.136.65.227 as permitted sender) smtp.mailfrom=fm-1328757-2026060805194353b1824e4700020751-x0CBRw@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20251104; t=1780895986; x=1781500786; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AH7IJhIl84+WWLyMRh3Zr/MTar123JOnWd/rqpQ0tPk=; b=pmtjC3N3lJtQp92TRXoI5GpVYgRsnNJ5ja7bjcSHRCKMesZWSv8ZDNCCe0H0Pwnc/J BWZ81bXQmDwWLATUzVlWQMGZ8kKrqsEv7PF+l+RO2a6/+1iNaLSQWdYjlKY4gJ1GN8e0 IAF1L/jGt61EWLh+K+mstSuz5t/f9mjjZYaNN82XxfR4PqZ0x9myvXkiD3fU/Z6rAL+t ibs+vHknOHwa6msAj74u1vI3eOJ/Memfef4u6eaC05i+vev+kWW38k667/1zBOyJZQH8 u65oqCEgWkj/bxV9w/1r7HeZ0vuWQe3EjFpaHCgG7ifNOwzNWx+Nw9vLrw1sF89Gq793 skJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780895986; x=1781500786; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-beenthere:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=AH7IJhIl84+WWLyMRh3Zr/MTar123JOnWd/rqpQ0tPk=; b=jqf0xs1NdOrMkjmrwtTRBfIn/IppwsU204l+WgCejOTdQ9GhW4baFMhkt+TvLa9xdB D/67WfBZKy65iz6lZc3vzPpaiFArraIQIMFf5NI3EHVjiE9JUuCc/p4ZD69R55qLMw2x BHAm/sdSh5mEkW9xPXD4qjolSOh0bUhHKSLU/XdhTiD4STsNSKZ5yblgUDrWSh+0tzSH AMVNLsHbuWfHAzOQsdXrdU6vZderJ4R0S1NNic6V/RbNHCNR5zmKw8eCiXWDdA69kP6X 4D4mbz2/JDubFoKKPg6/YlVz3UCQT28237SxeGi2ZhGZSxx59Ed3uT/O83m6X2CIOMt3 LgCA== X-Forwarded-Encrypted: i=2; AFNElJ/YgXDh04/pinbkyAbOLWOUacJHlGDpengpLZyda7LSjPatwCOFTK3gJRlR5LkaabyJqLQK2FA=@isar-build.org X-Gm-Message-State: AOJu0Yzxk6Iqs61dsNDYqRhJ5EMj8yhp7EnD/6ylkZBxVZ69ipXnM/Av khrA/2IHP3A84Pn+EE5OUZm3IDca03JU3hoMakT3A9Lf+LE9+jzwYoJX X-Received: by 2002:a05:6a00:4510:b0:842:6e9f:9dc with SMTP id d2e1a72fcca58-842b10b308bmr13303746b3a.34.1780895986513; Sun, 07 Jun 2026 22:19:46 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h="AX0PUUeShhMF9B4/IoghGB0zqTkPiu+6y5HvCrsmB8MEOUz/cw==" Received: by 2002:a05:6a00:a8d:b0:82a:6b57:a7a6 with SMTP id d2e1a72fcca58-8429cd3a247ls4361483b3a.2.-pod-prod-02-us; Sun, 07 Jun 2026 22:19:45 -0700 (PDT) X-Received: by 2002:a05:6a20:7490:b0:3b2:86c9:baa5 with SMTP id adf61e73a8af0-3b4ccfdbb5dmr16955088637.38.1780895985027; Sun, 07 Jun 2026 22:19:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1780895985; cv=none; d=google.com; s=arc-20240605; b=IFNWqD/WXWMGnwY+yVRBYG2b5A/OL+DFYZqeWKECjvg2MbY6VEbEtmgh+sSD7qMkQc 7mcn1W2pqS2hWDe7eX/1Ir5Tihj5bexL2fr306mc54iyFWI3kGVTM4C6UadhuQTXnxvH btqqOELGKJnhp8E5TQ9K3VRDf8wjvVRL6VjLCAHR2UWkieomI9EJisNpgpBzu4Ox7ARO iT3KZC0nTK+BKae4W3RYMzxUeGDeAM/yNcCkCT8jKrLo57UFPWWUmqyZbVMZZMlRNhoP MXnmPdNwz1m6IJUOcxYOnX4RI+UFoykqwa2+icEoBS4SxNEirOh1nN8TibWUy5r6vNez /IEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=feedback-id:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=ukvus698i4Fg7M59mfl1qbqT+qDigW87Jl2QKddtQxI=; fh=pR4tJPO4NbHlIB/rP4bIo54Z1zh5hd/ksAGQ0tcKkYM=; b=JOPj/2SpHI5mCwJ4ZFXUFOnQUw/cXig92PN65zTEifKlaZlZJlnuYrS+7UOFPp975w kG2t2PV5X8hDCuyJVWKKuD1yR5AKN0bzq40rzCNP5QQdI9rGjm4zNOqzCk+oUQcPvplv eJXztX5b9jQbSkFllbppKyUsbEmg1pgeZShDYy6UTu5yeUq5U46QRpzM9qr/0k0qQO/B 2GgTJCZCWFFDQ79ncb1uKnMIkMBJ4RU0Or6ZdpnY+b/sRp9D1G92f5prFj98acHpyoK6 c01DAEoP3BkceJR5f8nJA8UUPvwIgugiqpRaujpUlEsd6/8wI3z1rRLNUpS6nLP5PF3V bMTw==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=Pwd4IqZy; spf=pass (google.com: domain of fm-1328757-2026060805194353b1824e4700020751-x0cbrw@rts-flowmailer.siemens.com designates 185.136.65.227 as permitted sender) smtp.mailfrom=fm-1328757-2026060805194353b1824e4700020751-x0CBRw@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-65-227.siemens.flowmailer.net (mta-65-227.siemens.flowmailer.net. [185.136.65.227]) by gmr-mx.google.com with ESMTPS id 41be03b00d2f7-c85df08cc94si474019a12.6.2026.06.07.22.19.44 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 07 Jun 2026 22:19:45 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-1328757-2026060805194353b1824e4700020751-x0cbrw@rts-flowmailer.siemens.com designates 185.136.65.227 as permitted sender) client-ip=185.136.65.227; Received: by mta-65-227.siemens.flowmailer.net with ESMTPSA id 2026060805194353b1824e4700020751 for ; Mon, 08 Jun 2026 07:19:43 +0200 X-Patchwork-Original-From: "'Kasturi shekar' via isar-users" From: Kasturi shekar To: isar-users@googlegroups.com Cc: Kasturi Shekar Subject: [PATCH v3 2/4] installer: extract attended UI to installer_ui.sh Date: Mon, 8 Jun 2026 10:47:33 +0530 Message-ID: <20260608051737.946413-3-kasturi.shekar@siemens.com> In-Reply-To: <20260608051737.946413-1-kasturi.shekar@siemens.com> References: <8b658081-ce7b-4ffc-b108-1691f5a8ceaf@ilbers.de> <20260608051737.946413-1-kasturi.shekar@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1328757:519-21489:flowmailer X-Original-Sender: kasturi.shekar@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=Pwd4IqZy; spf=pass (google.com: domain of fm-1328757-2026060805194353b1824e4700020751-x0cbrw@rts-flowmailer.siemens.com designates 185.136.65.227 as permitted sender) smtp.mailfrom=fm-1328757-2026060805194353b1824e4700020751-x0CBRw@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Kasturi shekar Reply-To: Kasturi shekar Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: Kasturi Shekar Move attended dialog interactions into installer_ui.sh The new UI module provides: - image selection menu - target device selection menu - install and overwrite confirmation dialogs - error and info dialogs - attended progress gauge hooks Signed-off-by: Kasturi Shekar --- .../files/usr/bin/installer_ui.sh | 217 +++++++++++++----- 1 file changed, 161 insertions(+), 56 deletions(-) mode change 100755 => 100644 meta-isar/recipes-installer/deploy-image/files/usr/bin/installer_ui.sh diff --git a/meta-isar/recipes-installer/deploy-image/files/usr/bin/installer_ui.sh b/meta-isar/recipes-installer/deploy-image/files/usr/bin/installer_ui.sh old mode 100755 new mode 100644 index 33685c6f..9d3ba5de --- a/meta-isar/recipes-installer/deploy-image/files/usr/bin/installer_ui.sh +++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/installer_ui.sh @@ -1,86 +1,191 @@ #!/usr/bin/env bash +# This software is a part of ISAR. +# Copyright (C) Siemens AG, 2026 # -# installer_ui.sh — Attended installer frontend -# ------------------------------------------------ +# SPDX-License-Identifier: MIT -SCRIPT_DIR="$(CDPATH= cd -- "$(dirname -- "$0")" && pwd)" -INSTALL_DATA=${INSTALL_DATA:-./install} +#-------------------------------------------------------------------------- +# installer_ui.sh - Frontend/UI helpers for isar installer. +# +# This file is intentionally UI-only: +# - dialog menus and message boxes +# - attended confirmations +# - user abort countdown handling +#-------------------------------------------------------------------------- +UI_GAUGE_PID="" + +#-------------------------------------------------------------------------- +# ui_show_error +# +# Displays an error dialog in attended mode. +#-------------------------------------------------------------------------- +ui_show_error() { + local message="$1" + dialog --msgbox "$message" 6 60 +} -# Backend APIs -. "$SCRIPT_DIR/sys_api.sh" +#-------------------------------------------------------------------------- +# ui_show_info +# +# Displays an informational dialog in attended mode. +#-------------------------------------------------------------------------- +ui_show_info() { + local message="$1" + dialog --msgbox "$message" 6 60 +} + +#-------------------------------------------------------------------------- +# ui_countdown_allow_attended_switch +# +# In unattended mode, this gives users a chance to switch to attended +# mode by pressing any key. Returns 0 when attended mode should be +# used, and 1 otherwise. +#-------------------------------------------------------------------------- +ui_countdown_allow_attended_switch() { + local timeout="$1" + local abort_file="$2" + local i + + # Countdown loop prints a message once per second and accepts a key press. + # If any key is pressed, create the abort trigger file for the caller. + for ((i=timeout; i>0; i--)); do + echo -ne "\rUnattended installation will start in $i seconds. Press any key to switch to attended mode..." + + if [ -f "$abort_file" ] || read -n 1 -t 1; then + touch "$abort_file" + echo + return 0 + fi + done -# ------------------------------------------------ -# Helpers -# ------------------------------------------------ -die() { - dialog --msgbox "$1" 6 60 - exit 1 + echo + return 1 } -# ------------------------------------------------ -# UI: Select image -# ------------------------------------------------ -ui_select_image() { - local images json list=() +#-------------------------------------------------------------------------- +# ui_select_image_menu +# +# Uses sys_list_installable_entries backend API and returns selected +# relative image path on stdout. +#-------------------------------------------------------------------------- +ui_select_image_menu() { + local install_data_dir="$1" + local list=() + local entry + local selected - # On failure, show error dialog and exit - json=$(sys_locate_disk_images search_path="$INSTALL_DATA") || \ - die "No installable images found in $INSTALL_DATA" + while IFS= read -r entry; do + [ -n "$entry" ] || continue + list+=("$entry" "$entry") + done < <(sys_list_installable_entries "$install_data_dir") - # Extract image paths from JSON - images=$(echo "$json" | sed -n 's/.*"images":\[\(.*\)\].*/\1/p' | tr -d '"' | tr ',' '\n') + if [ "${#list[@]}" -eq 0 ]; then + return 1 + fi - # Building dialog menu entries - for img in $images; do - base=$(basename "$img") - list+=("$img" "$base") - done + selected=$(dialog --no-tags \ + --menu "Select image to be installed" 12 70 6 \ + "${list[@]}" --output-fd 1) || return 2 - # Display menu and capture selection - INSTALL_IMAGE=$(dialog --no-tags \ - --menu "Select image to install" 10 70 5 \ - "${list[@]}" \ - --output-fd 1) || exit 0 + echo "$selected" + return 0 } -# ------------------------------------------------ -# UI: Select target device -# ------------------------------------------------ -ui_select_target_device() { +#-------------------------------------------------------------------------- +# ui_select_target_device_menu +# +# Displays candidate target devices and returns selected /dev path. +#-------------------------------------------------------------------------- +ui_select_target_device_menu() { local list=() + local target + local target_size + local state + local selected - devices=$(sys_list_valid_target_devices) || \ - die "No valid target devices found" + for target in "$@"; do + [ -b "$target" ] || continue - for dev in $devices; do - [ -b "$dev" ] || continue + target_size=$(sys_device_size "$target") + [ -n "$target_size" ] || target_size="unknown" - size=$(lsblk --nodeps --noheadings -o SIZE "$dev" 2>/dev/null | tr -d " ") - [ -z "$size" ] && size="unknown" - - if cmp /dev/zero "$dev" -n 1M >/dev/null 2>&1; then + # Indicate whether the selected device is already empty, to help users + # avoid accidental overwrite of data. + if sys_device_is_empty "$target"; then state="empty" else state="contains data" fi - list+=("$dev" "$dev ($size, $state)") + list+=("$target" "$target ($target_size, $state)") done - if [ "${#list[@]}" -lt 2 ]; then - die "no installable target devices available" + if [ "${#list[@]}" -eq 0 ]; then + return 1 fi - TARGET_DEVICE=$(dialog --no-tags \ - --menu "Select target device" 10 70 6 \ - "${list[@]}" \ - --output-fd 1) || exit 0 + selected=$(dialog --no-tags \ + --menu "Select device to install image to" 12 70 6 \ + "${list[@]}" --output-fd 1) || return 2 + + echo "$selected" + return 0 } -run_interactive_installer() { - clear - ui_select_image - ui_select_target_device +#-------------------------------------------------------------------------- +# ui_confirm_install +# +# Returns: +# 0 when user confirms, 1 when canceled. +#-------------------------------------------------------------------------- +ui_confirm_install() { + local image_path="$1" + local target_device="$2" + local target_size="$3" + + dialog --yes-label Ok --no-label Cancel \ + --yesno "Start installing\n'$image_path'\nto $target_device (capacity: $target_size)" 8 70 +} + +#-------------------------------------------------------------------------- +# ui_confirm_overwrite +# +# Returns: +# 0 when user accepts overwrite, 1 when canceled. +#-------------------------------------------------------------------------- +ui_confirm_overwrite() { + dialog --defaultno --yesno "WARNING: Target device is not empty! Continue anyway?" 8 70 +} + +#-------------------------------------------------------------------------- +# ui_start_progress_gauge +# +# Opens a dialog gauge and updates it from bmaptool psplash pipe. +#-------------------------------------------------------------------------- +ui_start_progress_gauge() { + local pipe_path="$1" + + ( + while true; do + if read -r line < "$pipe_path"; then + percentage=$(echo "$line" | awk '{ print $2 }') + echo "$percentage" + fi + done + ) | dialog --gauge "Flashing image, please wait..." 10 70 0 & + + UI_GAUGE_PID=$! +} + +#-------------------------------------------------------------------------- +# ui_stop_progress_gauge +# +# Best-effort termination of the active progress gauge process. +#-------------------------------------------------------------------------- +ui_stop_progress_gauge() { + if [ -n "$UI_GAUGE_PID" ]; then + kill "$UI_GAUGE_PID" 2>/dev/null || true + UI_GAUGE_PID="" + fi } -run_interactive_installer