diff mbox series

[1/1] fix(rootfs): close progress reporter after last step finished

Message ID 20260629150437.2980426-1-felix.moessbauer@siemens.com
State Priority Review
Headers show
Series [1/1] fix(rootfs): close progress reporter after last step finished | expand

Commit Message

MOESSBAUER, Felix June 29, 2026, 3:04 p.m. UTC 
We currently stop the progress reporter after each step. This is
incorrect, as finish must only be called after the last step. However,
the impact is quite limited. Currently the only observable effect is
that - when running in debug mode - a summary of all previous execution
times is printed per step (instead of once).

We further want to call finish also if a step raises, hence we move it
to the finally block.

Fixes: eae54341 ("rootfs: Add missing umounts in rootfs ...")
Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
 meta/classes-recipe/rootfs.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/meta/classes-recipe/rootfs.bbclass b/meta/classes-recipe/rootfs.bbclass
index a58ad031..8e45c10d 100644
--- a/meta/classes-recipe/rootfs.bbclass
+++ b/meta/classes-recipe/rootfs.bbclass
@@ -458,8 +458,8 @@  python do_rootfs_install() {
 
             if "release-after" in (d.getVarFlag(cmd, 'isar-apt-lock') or ""):
                 bb.utils.unlockfile(lock)
-            progress_reporter.finish()
     finally:
+        progress_reporter.finish()
         bb.build.exec_func('rootfs_do_umounts', d)
 }
 addtask rootfs_install before do_rootfs_postprocess after do_unpack