| Message ID | 20260729103351.432203-1-srinuvasan.a@siemens.com |
|---|---|
| State | New |
| Headers | show |
| Series | isar-image-base: avoid ISAR_RELEASE_CMD warning in image builds | expand |
On 29.07.26 12:33, srinuvasan.a via isar-users wrote: > From: Srinuvasan A <srinuvasan.a@siemens.com> > > Set ISAR_RELEASE_CMD in the image recipes to avoid the below warning. > > WARNING: isar-image-base-1.0-r0 do_rootfs_postprocess: You are using external > layers that will not be considered in the build_id. Consider changing ISAR_RELEASE_CMD. > > Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com> > --- > meta-isar/recipes-core/images/isar-image-base.bb | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/meta-isar/recipes-core/images/isar-image-base.bb b/meta-isar/recipes-core/images/isar-image-base.bb > index 77c78bfb..94de571a 100644 > --- a/meta-isar/recipes-core/images/isar-image-base.bb > +++ b/meta-isar/recipes-core/images/isar-image-base.bb > @@ -10,4 +10,7 @@ LIC_FILES_CHKSUM = "file://${LAYERDIR_core}/licenses/COPYING.GPLv2;md5=751419260 > > PV = "1.0" > > +# Avoid ISAR_RELEASE_CMD warning in image.bbclass Wrong reason - but it seems this was inherited from isar-image-ci.bb. The obvious reason to set this variable is to encode which release the image was built from. But that is not worth a comment. > +ISAR_RELEASE_CMD = "git -C ${LAYERDIR_isar} describe --tags --dirty --match 'v[0-9].[0-9]*'" > + > inherit image Here is the risk: this is a base image, and some downstream layers may build on top, and will then no longer see the warning. I'm wondering if we cannot limit this to the case where the target recipe is isar-image-base itself. Same task for isar-image-debug. Jan
diff --git a/meta-isar/recipes-core/images/isar-image-base.bb b/meta-isar/recipes-core/images/isar-image-base.bb index 77c78bfb..94de571a 100644 --- a/meta-isar/recipes-core/images/isar-image-base.bb +++ b/meta-isar/recipes-core/images/isar-image-base.bb @@ -10,4 +10,7 @@ LIC_FILES_CHKSUM = "file://${LAYERDIR_core}/licenses/COPYING.GPLv2;md5=751419260 PV = "1.0" +# Avoid ISAR_RELEASE_CMD warning in image.bbclass +ISAR_RELEASE_CMD = "git -C ${LAYERDIR_isar} describe --tags --dirty --match 'v[0-9].[0-9]*'" + inherit image