diff mbox series

[v2,4/4] testsuite: add rootfs-add-files unittest

Message ID 20261026101018.276241-4-clara.kowalsky@siemens.com
State New
Headers show
Series [v2,1/4] rootfs-add-files: correctly remove files in ROOTFSDIR | expand

Commit Message

Clara Kowalsky Oct. 26, 2026, 10:10 a.m. UTC 
Run rootfs_add_files and verify the removal command targets ROOTFSDIR
before the replacement is copied. Cover schroot and unshare commands,
including the unshare ownership.

Signed-off-by: Clara Kowalsky <clara.kowalsky@siemens.com>
---
 testsuite/unittests/test_rootfs_add_files.py | 80 ++++++++++++++++++++
 1 file changed, 80 insertions(+)
 create mode 100644 testsuite/unittests/test_rootfs_add_files.py
diff mbox series

Patch

diff --git a/testsuite/unittests/test_rootfs_add_files.py b/testsuite/unittests/test_rootfs_add_files.py
new file mode 100644
index 00000000..1ef7c4a8
--- /dev/null
+++ b/testsuite/unittests/test_rootfs_add_files.py
@@ -0,0 +1,80 @@ 
+# This software is a part of Isar.
+# Copyright (C) Siemens AG, 2026
+#
+# SPDX-License-Identifier: MIT
+
+from rootfs import TemporaryRootfs
+
+import os
+import sys
+import unittest
+from unittest.mock import patch
+from typing import Tuple
+
+sys.path.append(os.path.join(os.path.dirname(__file__), '../../bitbake/lib'))
+
+from bb import process
+from bb.build import exec_func
+from bb.data_smart import DataSmart
+from bb.data import init
+from bb.parse import handle
+
+file_name = 'meta/classes-recipe/rootfs-add-files.bbclass'
+
+
+class TestRootfsAddFiles(unittest.TestCase):
+    def assert_remove_targets_rootfs(self, run_mock, rootfs_file):
+        command = run_mock.call_args_list[0].args[0]
+        if isinstance(command, str):
+            command = command.split()
+        self.assertEqual(
+            command[-3:], ['/usr/bin/rm', '-f', rootfs_file],
+            'Expected the existing destination to be removed from ROOTFSDIR.',
+        )
+
+    def setup(self, chroot_mode: str,
+              destination: str = 'install/payload'
+              ) -> Tuple[DataSmart, TemporaryRootfs]:
+        rootfs = TemporaryRootfs()
+        rootfs.create_file('/source', 'payload')
+        rootfs.create_file('/install/payload', 'old payload')
+
+        d = handle(
+            os.path.join(os.path.dirname(__file__), '../..', file_name),
+            init(),
+        )
+        d.setVar('T', f'{rootfs.path()}/temp')
+        d.setVar('ROOTFSDIR', rootfs.path())
+        d.setVar('ROOTFS_ADDITIONAL_FILES', 'payload')
+        d.setVar('RUN_PRIVILEGED_CMD', 'unshare --mount --user'
+                 if chroot_mode == 'unshare' else 'sudo -E')
+        d.setVar('ISAR_CHROOT_MODE', chroot_mode)
+        d.setVarFlag('ROOTFS_ADDITIONAL_FILE_payload', 'source',
+                     f'{rootfs.path()}/source')
+        d.setVarFlag('ROOTFS_ADDITIONAL_FILE_payload', 'destination',
+                     destination)
+        return (d, rootfs)
+
+    def test_replace_existing_file(self):
+        for destination in ('install/payload', '/install/payload'):
+            with self.subTest(destination=destination):
+                d, rootfs = self.setup('schroot', destination)
+                rootfs_file = f'{rootfs.path()}/{destination}'
+
+                with patch.object(process, 'run') as run_mock:
+                    exec_func('rootfs_add_files', d)
+
+                self.assert_remove_targets_rootfs(run_mock, rootfs_file)
+
+    def test_replace_existing_file_unshare(self):
+        d, rootfs = self.setup('unshare')
+        rootfs_file = f'{rootfs.path()}/install/payload'
+
+        with patch.object(process, 'run') as run_mock:
+            exec_func('rootfs_add_files', d)
+
+        self.assert_remove_targets_rootfs(run_mock, rootfs_file)
+
+
+if __name__ == '__main__':
+    unittest.main()