From patchwork Mon Oct 26 12:18:44 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Clara Kowalsky X-Patchwork-Id: 5566 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Mon, 26 Oct 2026 13:19:20 +0100 X-Sieve: CMU Sieve 2.4 Received: from mail-qv1-f56.google.com (mail-qv1-f56.google.com [209.85.219.56]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 69QCJIDo010685 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 26 Oct 2026 13:19:19 +0100 Received: by mail-qv1-f56.google.com with SMTP id 6a1803df08f44-91b8306ba68sf79360786d6.2 for ; Mon, 26 Oct 2026 05:19:19 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1793017153; cv=pass; d=google.com; s=arc-20260327; b=VX4tTavKiy3GukTd/231/i/9wo7hRczf1fbotfY3zm4SVRh8G3tCVM5uLnwxC1DmOp YFXE8sQB3d/y9paZeW2fwDSzUrVAmu/G70+p7t+6orvbnYwoWePkmh/BKKGP+M//Chqj Fmi4VKx8Ahp6P9cXnzBVWylmc1XuP6sSv7bzuQABAoUmvzFjZbASnPBe7ewkZebaj5Ce 9XVoEcPr463TOtyuIid8yNOY8WDlroGbXqUkiGEuMl1wUvN2X9sCAunTeLYtFIowSDf7 IDL0mFxjfdWoH51iaJr2Jr3ON4JFHieZfvoFYidsa7lhnUG+C0izL6943LRphPWvTo+A H48w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Bykjib9e9FYxE5t2hRagB7OlB2zp1SLHVynozNvammE=; fh=pUgQXIDVVTuSVPtqpcm9RLFDTOJrKuP+72ME9ve3Tos=; b=USaWukr+LGjWcZaiPu20WiDy5kbxIw6XtPnl/184a29zu9NmTvB2d5nJ6p5pp5U7Ft +n8F5098yskZqceto9WlnE3X6K1X5WHY4IVBJz/CvLNy24Djtm3SLfVd6Lsy+fzAGc/p OxnVJ9QZ60OWLzV7He3yCcUE/ph93FB6EGmAr2gvMNwiWXYP9/PhhzA0lcnIHPlYwYJL 1sRdxNWMGu4j0os1zFboJMqw1U63A+VN3mEQP+bZGfPqY38pBVSDBNGvF+Iv/CqwhvJe 2H3SyoRH5ilZoZu1SYT/zlDrbVQltChdevCeq+FUBehPG9FtB/Ef0SKHW8oLJTBED1rA +h7g==; darn=isar-build.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=iom4dNKz; spf=pass (google.com: domain of fm-1047747-202610261219102c630e727c00020755-yf0vtw@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) smtp.mailfrom=fm-1047747-202610261219102c630e727c00020755-YF0vTw@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20251104; t=1793017153; x=1793621953; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:content-type:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Bykjib9e9FYxE5t2hRagB7OlB2zp1SLHVynozNvammE=; b=p1axrD/72+DQp6Gt8NekV9ijRZkWFRL7+Q4kBTRLRchHJgpxgMUo75vthgy5Oq6tu+ yLo8eVd+cQQionUk4JWCqmY37G2WSG6PwkgQ3+8eVpHxRhacu579f/hq6B3BDxGtJSrN ORoNnzQMsFDl7Vh1DHkTi43QdpMAVchPHy/FzgPdlfJNb9WZOo1Fq6xwDbdbB3NlpDXn HoQfhjO0j4/6xabwcX3Uvqq6VsNNDbTQO91tUbrugv2MOkL+7R+K/oLA8I9XZU7vzmqi dOuri0ypwr/PFsZrJSCGUxIOGrTaZnNhH6sJFtJvucQFVx2tUT0SHCagVku/rCH/kQp6 nG9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793017153; x=1793621953; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :content-type:reply-to:x-original-authentication-results :x-original-sender:feedback-id:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-beenthere:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to:content-type; bh=Bykjib9e9FYxE5t2hRagB7OlB2zp1SLHVynozNvammE=; b=oiCZRenzt+Y2lj7pP6qvbqeYuCcgnD4M8PzWBdGkj2ELJ+110FDO3EF0wmTwKgzxPl K4qfWf24NZlhKn6pMx0ZXYrWwge5i9fZS8eQE0NYrnDjhFZ6MPAnoZPv/sB2T5uX9Gy7 7s0eVCTXfRispGFdpdWlKaqRlImFGIc/+Gm5VrZykoyogv44snYgo6pQGf4/8yNxPV4H O+wIocJfGNpfgftt81AIm9tmaroim5vH2iuJr5Hr3dIsap5cgtwh95ss5SDBQIY1IZUR RESxEjg4G5B9+768yzDVPyOOWRNWfaiNDtJAp2X60pxTxli0ovBIQlr1+eCvz4cJHys1 LULQ== X-Forwarded-Encrypted: i=2; AKwUvBzcn0Qx/cUps9TVhXuoDTDV5m4YVUgaEXmLmnn3Bn3CHiDo2Wz6f4wmLL+Cq+kF5GtBsSaEshY=@isar-build.org X-Gm-Message-State: AFq9FYIRH3R2Wh2Kz7o0GggNZCLR84a/TXDsuTbnkM8skZ5gM/Gmc1nW aI36Mt4DUlAPlecuOoidaM5/3B39MGHMrwgK9+GTUOsz3or45QeAiU/H X-Received: by 2002:a05:6214:451b:b0:91b:dd71:fb94 with SMTP id 6a1803df08f44-91c48eca1edmr107701696d6.56.1793017153346; Mon, 26 Oct 2026 05:19:13 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h="ATskLddljPGcG7HVcyQRHgfENJ5tRgvBhZgr9pl1T8yQ3fCBLw==" Received: by 2002:a05:6214:19ee:b0:91c:5ffc:f0ff with SMTP id 6a1803df08f44-91c5ffcf324ls28052026d6.1.-pod-prod-07-us; Mon, 26 Oct 2026 05:19:12 -0700 (PDT) X-Received: by 2002:a05:6102:c4a:b0:7cc:25bc:3b30 with SMTP id ada2fe7eead31-7ce5cd85b39mr2191601137.21.1793017152469; Mon, 26 Oct 2026 05:19:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1793017152; cv=none; d=google.com; s=arc-20260327; b=GeAgqmVF4WOMA4RXS1N6aVvOtZ4DTmJI5KGFtBXsSH2IRWWta4V/TzVw+LsEReCsPg AQ9sSLFRIjujBIC+eMA++8+QxKmMH1pBqunsT1aOaUaLQTsVO5QEBRxZ+qzEaBpH6Nn/ Kc1lFJJje6KOgFE90L/3T5tLFe2rs4IuzU9ibtdntPg+GilCsn708aMsrAJ/NW0adPW7 XP3ocjq8Ehl8Kc6t/zs2JJEAB4SevXlHj1dlKc1f04wimotFnjMjzIcX5XMEJ/vdgak9 uUWMCvWcjxpzPW0wckakvNLAUIcOJ6V8bL8K8+EH1duP2rdM0eZUVsSYhEjrkJes9Umt hxlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=feedback-id:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=5iKalTdvBkQ204goetJwK8ZE/Lygvcb7pqL4YoEk/Uw=; fh=AqT8zD6jUs4YP+XkSwmnbRYu3wrat9Vyg/xvm1MGQCM=; b=i0jU5o/owctnQSh1pzgFzVrz62M2lfCwu+8hzJcedf94SUgnd9bmTDzLu6sPnOtTjp hwu+ErODU1q60E5pPkN8JY5PEmh112xqCRklH+zXjFL7//okSuAetvIw2EBnsHfPtxan oKqWE80r3PI/Kt/nyCLW8y3AEZGYtQvQgjU9DCtqiWrpMrWgkSNCQrgv8ONg5FEuCu2H JsGvupHx0WH8CTvzqZhRwXypg7ilQQrDAFPo1W+bwcCokwPNMia91FukEgfAOjdlHk3U mzHPS9FL/BqrLvF2P517BvaXnFFE6NrunZLb8wAWXQvhKOmcUKFOaOZMhJ6BAkPUtNFz SeuQ==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=iom4dNKz; spf=pass (google.com: domain of fm-1047747-202610261219102c630e727c00020755-yf0vtw@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) smtp.mailfrom=fm-1047747-202610261219102c630e727c00020755-YF0vTw@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-64-225.siemens.flowmailer.net (mta-64-225.siemens.flowmailer.net. [185.136.64.225]) by gmr-mx.google.com with ESMTPS id ada2fe7eead31-7ce5df6d29dsi147987137.2.2026.10.26.05.19.12 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Oct 2026 05:19:12 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-1047747-202610261219102c630e727c00020755-yf0vtw@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) client-ip=185.136.64.225; Received: by mta-64-225.siemens.flowmailer.net with ESMTPSA id 202610261219102c630e727c00020755 for ; Mon, 26 Oct 2026 13:19:10 +0100 X-Patchwork-Original-From: "'Clara Kowalsky' via isar-users" From: Clara Kowalsky To: isar-users@googlegroups.com Cc: Clara Kowalsky Subject: [PATCH 2/2] testsuite: fix deterministic password test in image account extension Date: Mon, 26 Oct 2026 13:18:44 +0100 Message-ID: <20261026121844.663746-2-clara.kowalsky@siemens.com> In-Reply-To: <20261026121844.663746-1-clara.kowalsky@siemens.com> References: <20261026121844.663746-1-clara.kowalsky@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1047747:519-21489:flowmailer X-Original-Sender: clara.kowalsky@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=iom4dNKz; spf=pass (google.com: domain of fm-1047747-202610261219102c630e727c00020755-yf0vtw@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) smtp.mailfrom=fm-1047747-202610261219102c630e727c00020755-YF0vTw@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Clara Kowalsky Reply-To: Clara Kowalsky Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= The test expected two process.run calls which worked for the original crypt-based implementation. Commit 6144daf9 replaced crypt with an openssl passwd subprocess, adding a third call, but did not update the test. Also mock the openssl output and verify the expected salt and password input. Fixes: 6144daf9 ("image-account-extension: Avoid deprecated crypt module") Signed-off-by: Clara Kowalsky --- testsuite/unittests/test_image_account_extension.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/testsuite/unittests/test_image_account_extension.py b/testsuite/unittests/test_image_account_extension.py index ecadc15f..fcc23506 100644 --- a/testsuite/unittests/test_image_account_extension.py +++ b/testsuite/unittests/test_image_account_extension.py @@ -117,11 +117,16 @@ class TestImageAccountExtensionImageCreateUsers( ) with patch.object(process, 'run') as run_mock: + run_mock.return_value = (encrypted_password, '') image_create_users(d) password_data = f"{test_user}:{encrypted_password}".encode() - assert run_mock.call_count == 2 + assert run_mock.call_count == 3 + run_mock.assert_any_call([ + 'openssl', 'passwd', '-6', '--salt', 'eb2e2a12cccc88a', + cleartext_password, + ]) assert run_mock.call_args[0][1] == password_data