From patchwork Tue Sep 16 11:05:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 4353 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Tue, 16 Sep 2025 13:05:30 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-wm1-f55.google.com (mail-wm1-f55.google.com [209.85.128.55]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 58GB5TO3017328 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 16 Sep 2025 13:05:29 +0200 Received: by mail-wm1-f55.google.com with SMTP id 5b1f17b1804b1-45b920a0c89sf28873415e9.2 for ; Tue, 16 Sep 2025 04:05:29 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1758020723; cv=pass; d=google.com; s=arc-20240605; b=gvYkLCpLXeqSFV04nvXcVLxW/mG1cYzSn8y+JSI/lIbFT3VL4m03HpgbCRvPMsMSv1 55GjNOP81IN+aNPeiUKiOjkQ1UDlbS7pwZXoRarvO5llAJhRwfmbDM9T0xTsegqJccu5 FGgOn7Gq6HjGiiOMJrrgFr5wS6c5094r8wGTVqVyCPxn5A7G38zxDZXuNSbsVjEz+5uX E74pqZ9UPxGXSqpTbxEqpTy4FOwIMt1GezrwwWOnQE6+incLpTQDEipRTEr3nc2FaMzc iy6EMDDgmMjFAXaArz/ru/FCBKugu1nuhiQcyAZcyTa6RcHKucucuPibvOqfqBe719l1 r5kA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ew7vRuCubG8k30k/Ja3g0XWTpr61tTrjF8NiXISLrfU=; fh=vMQWopqEoLVDILjB4tPE6mVr/EHnqBhi4NEBRuLQi1E=; b=C6pVCLYO0gr5lJnwu7ByqlhIWCML1ezf+zSkeYl5E5Vymqhp3z9BCik2Gscb3BADeR vh1O4yLU5ZQDDKDgH/LWKfFTYPJ8Q9HggPGQpRZ77BuK0DdSsfX9Pf/DPsqyaly9zK+W Os4zvTtQOJbid5Plx5M6GGtVQPYhoVLIIhTxCDwYWIUSvELymxtKNxYuuuu3Fcy/3oHF y84ZY1Yi3yGHkuAifIC0chYX+IqBefxH6Di1SQO0yjSqfU+/8gMhzPatUIkMmD6/jhxJ ynwpXPI5jtIEn6dNM2lBXdqhzcZtGm+U+l3SkPTOWJ5gW/Eiala+K6MkFvaERjcbRr8u 8qeQ==; darn=isar-build.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=qKXTbKBv; spf=pass (google.com: domain of fm-294854-20250916110519d4e360865f00020727-qy5g9b@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) smtp.mailfrom=fm-294854-20250916110519d4e360865f00020727-Qy5g9b@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1758020723; x=1758625523; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=ew7vRuCubG8k30k/Ja3g0XWTpr61tTrjF8NiXISLrfU=; b=PegE+Runpo3M1Cd7pIoIU6Dv84rNIqUfxiSsahitxZYu+y9j2vp53jXju/IWAGxRUp pJjWJ4BjJfdTxFE2IfvbYK+iCwE25TZLxhVCILEJ+zXT2u851oBSr7vmb2R840JTp75c pNoZcUNpvX2OnlOdzT4N10Pz/7WGU+UptPhzR/KKKEtvWAq7wYsTZh7sBYF+kHiSb1E5 enOaN5nu4uR2fo35GXJpFioLcOeBvQk9mmaU5Dnve7ePvLNex8CJhLnv7dtGZETrqMjb q4XEFl3B5cNwF+Lien9CE+koOBNG2HxLaLB6fR51SuhXf8l9xFAc7xx29W5pR5atG+ab I+fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758020723; x=1758625523; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-beenthere:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ew7vRuCubG8k30k/Ja3g0XWTpr61tTrjF8NiXISLrfU=; b=rRBmK7Ae7F3NaF1HOU74NJYt0vhXwofSHMQGUrK14Y5cBpDdpcgRExiI0eT7IJVygO 01Lqu6SPdoBYbPVU9UWuAdinkt1U5ngcLEoe2qnMgAWc2wfJC229BLhVeNWi5IVBRNbC DV9PPPliak7tLX07typZK8Moc1KRE/g2k+3yQzXlurDrOU4RJqiktkIwFh5Bx9BfjYN/ +1MsZQWRlwma1Zdi0kergwEjkveiuI+5gWQwz7A7YUE2EBmvj8CXos9k8Ctsk4HJyURV nau5Cp3DrpchiYfd7LblffqQyacSoW+VGd+ZvSBKYgbLMwWXoiqxrDOradPJNSWogpEj arkQ== X-Forwarded-Encrypted: i=2; AJvYcCUJ1EetV+vkFdtP8cRWNU3rVIRawTOi65p1Jv+MWXlO/cZ5/DmoYYSQe8n3jcr5WV4Suai3cXE=@isar-build.org X-Gm-Message-State: AOJu0Yy1b1whtyUJt/NaqvuLKMVaX+HmHmIbKOt31NXrVaCWPehMFrrG Jd0mtHNY0fuF5HuUQM90gBxaPdfCNa64APJKNg7yJjB2dx4Y4lqyswaD X-Google-Smtp-Source: AGHT+IHIkyx6AUGuqtcJ/WmsIxoFJ156RcvqMxjpTmbt2xqcC+lgBkLBSa7Eba7wQtETloFz06ckww== X-Received: by 2002:a05:600c:4e8a:b0:45f:2940:d186 with SMTP id 5b1f17b1804b1-45f29b1199dmr74937615e9.32.1758020722946; Tue, 16 Sep 2025 04:05:22 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h=ARHlJd67FWFEgu6Bu+A7a8YqhA4hZw19r7d9X96jPri+D9b1Dg== Received: by 2002:a05:600c:1f06:b0:45d:d5d8:c718 with SMTP id 5b1f17b1804b1-45dffc127ddls30563675e9.1.-pod-prod-06-eu; Tue, 16 Sep 2025 04:05:20 -0700 (PDT) X-Received: by 2002:a05:600c:58d8:b0:45b:868e:7f7f with SMTP id 5b1f17b1804b1-45f211f856fmr129250015e9.17.1758020719798; Tue, 16 Sep 2025 04:05:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1758020719; cv=none; d=google.com; s=arc-20240605; b=ZiAnFPX37eiweCAriO7fZLRo97Swntuvx4dhkf+7RSenMWscIT1oAaF3Bt+2rv9DaC Sl/JEVWqBEdZXNObLjymkAAD+8y2uSpCPG+FHvrJW5qUSwS2ZRBnavTSUEI27+FloY8Z kYtAHMlbiySl6yNlEUkiGWTAq4bC39G58O49mOtxUyx0Z5Vh8FkBq03wnQNmIRJuhzhM eVcB/fsb4iW5NuxkqQhtsqQokA/IIUt/yDX+45UeyeqzN8ahf71X4KQLtim9hOLKTM0E 2uWlrbI7Wq0e4G8gW4WU2iNlAPW8eY1MjUbHYWrz896ZgqmkjhZa5Na1RaJZW7G+18V8 qg6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=feedback-id:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=70wqbbgDA2eYCxWKzemjX1nS+4ZNt+I88TyYV06N8ws=; fh=xxo2rOAPT4f31TY31yIWVuVlno6QMa2Pdllc3KKolm0=; b=NMHdu7sCl3UwUhsz3L7zc4ehHglsnO3vgc71UeppPSdyhIv28EuuX54xwF5x77cEbP RLMheYSoI7gOMeRjuzzfZRN2mxkDVTjKJFMzAkBlstZrTXvFajJrePhupdiQ7XLhm7C3 zuv5YYLjsmWCnGTWH6NpAqFHz7tEYNcH6evD/XPXTiD1nZFKAcS+ty7vHivKzY/ysZBF LBbtpGiwjKBrzI9ID81gBeT7XFIeWobp+TCK4zqZsmNVev/FDa+y5uc1nmMiaQQ1dxxs oM5Pu4j/GQhG08KfdxwIcYtRaxRHD4L/PPwGqNHmC6lWareitkqTbtLXcxABpIMtztOZ XJJg==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=qKXTbKBv; spf=pass (google.com: domain of fm-294854-20250916110519d4e360865f00020727-qy5g9b@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) smtp.mailfrom=fm-294854-20250916110519d4e360865f00020727-Qy5g9b@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-64-225.siemens.flowmailer.net (mta-64-225.siemens.flowmailer.net. [185.136.64.225]) by gmr-mx.google.com with ESMTPS id ffacd0b85a97d-3ec4efa8d18si42834f8f.3.2025.09.16.04.05.19 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Sep 2025 04:05:19 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-294854-20250916110519d4e360865f00020727-qy5g9b@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) client-ip=185.136.64.225; Received: by mta-64-225.siemens.flowmailer.net with ESMTPSA id 20250916110519d4e360865f00020727 for ; Tue, 16 Sep 2025 13:05:19 +0200 X-Patchwork-Original-From: "'Jan Kiszka' via isar-users" From: Jan Kiszka To: isar-users Cc: Felix Moessbauer Subject: [PATCH v2 3/4] rootfs: Avoid unneeded commands inside chroot Date: Tue, 16 Sep 2025 13:05:11 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-294854:519-21489:flowmailer X-Original-Sender: jan.kiszka@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=qKXTbKBv; spf=pass (google.com: domain of fm-294854-20250916110519d4e360865f00020727-qy5g9b@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) smtp.mailfrom=fm-294854-20250916110519d4e360865f00020727-Qy5g9b@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Jan Kiszka Reply-To: Jan Kiszka Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: Jan Kiszka As the chroot implies emulation in case of cross-installation, any call into it that can be avoided saves a few seconds. Signed-off-by: Jan Kiszka --- meta/classes/rootfs.bbclass | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass index 605d5e01..5c48d91c 100644 --- a/meta/classes/rootfs.bbclass +++ b/meta/classes/rootfs.bbclass @@ -245,8 +245,11 @@ rootfs_export_package_cache() { ROOTFS_INSTALL_COMMAND += "${@ 'rootfs_install_clean_files' if (d.getVar('ROOTFS_CLEAN_FILES') or '').strip() else ''}" rootfs_install_clean_files[weight] = "2" rootfs_install_clean_files() { - sudo -E chroot '${ROOTFSDIR}' \ - /bin/rm -f ${ROOTFS_CLEAN_FILES} + sudo -s <<'EOSUDO' + for clean_file in ${ROOTFS_CLEAN_FILES}; do + rm -f "${ROOTFSDIR}/$clean_file" + done +EOSUDO } ROOTFS_INSTALL_COMMAND += "rootfs_install_pkgs_install" @@ -490,14 +493,14 @@ python do_generate_initramfs_setscene () { rootfs_generate_initramfs[progress] = "custom:rootfs_progress.InitrdProgressHandler" rootfs_generate_initramfs() { if [ -n "$(sudo find '${ROOTFSDIR}/boot' -type f -name 'vmlinu[xz]*')" ]; then - sudo -E chroot "${ROOTFSDIR}" sh -c '\ - for kernel in /boot/vmlinu[xz]-*; do \ - export kernel_version=$(basename $kernel | cut -d'-' -f2-); \ - mods_total="$(find /usr/lib/modules/$kernel_version -type f -name '*.ko*' | wc -l)"; \ - echo "Total number of modules: $mods_total"; \ - echo "Generating initrd for kernel version: $kernel_version"; \ - update-initramfs -u -v -k "$kernel_version"; \ - done;' + for kernel in ${ROOTFSDIR}/boot/vmlinu[xz]-*; do + export kernel_version=$(basename $kernel | cut -d'-' -f2-) + mods_total="$(find ${ROOTFSDIR}/usr/lib/modules/$kernel_version -type f -name '*.ko*' | wc -l)" + echo "Total number of modules: $mods_total" + echo "Generating initrd for kernel version: $kernel_version" + sudo -E chroot "${ROOTFSDIR}" sh -c ' \ + update-initramfs -u -v -k "$kernel_version"' + done if [ -n "${INITRD_DEPLOY_FILE}" ]; then if [ -f "${ROOTFSDIR}/initrd.img" ]; then # debian (mkinitramfs)