From patchwork Wed Feb 24 21:47:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Quirin Gylstorff X-Patchwork-Id: 342 Return-Path: Delivered-To: ilbers.mnt@gmail.com Received: by 2002:a4a:c583:0:0:0:0:0 with SMTP id x3csp169443oop; Wed, 24 Feb 2021 23:47:14 -0800 (PST) X-Received: by 2002:a17:906:9714:: with SMTP id k20mr237136ejx.519.1614239234319; Wed, 24 Feb 2021 23:47:14 -0800 (PST) ARC-Seal: i=3; a=rsa-sha256; t=1614239234; cv=pass; d=google.com; s=arc-20160816; b=hH/badXQj9cHGGVb4uo+gQD3xMFP+Ik648oVhSxw3Wk8N4vSu6CfWEVFUdcGCayRUa tap3Tw7bDAe19twN7A9qr/xjCVW+j87jlKsuBeQILcWsu8BqB/AnODjtmS2wSCyOTXEn rIcVzrtUXFmu/4qa6VPEyviqVgJXNXJrP9RCwX2gmEroLr9GGV2uPMzo7rSepq5XkjCx SOH1uly0LS3u++mh5A6QQ1vU91306StiEWQWd842iDAUQteurx+oJoc2Ih9bB44mMij7 hASCPrZcSVuIPwwAjdtDie7ark1mFJLNz85HcicDGDU+3Etq0U8bvbRa5KY/etIhe2Me 04+A== ARC-Message-Signature: i=3; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:message-id:date :subject:cc:to:from:sender:dkim-signature; bh=Vfy4LUAs0Zz/ae/vwyIIz08YN/I93FWGeu9t52z7YFs=; b=ZMr8GwtFM3LmpoHcDs2V+YXCHyfCmTr+jUW86k2VRkn2UtBJZpfRR7nEFA5CxUlOzx nUoASW3Xx/D2SPcee/4R/oLznFMaIfwayAkcz/GhhYMq347lJDXu3g2xmLZ4MiEWafOI XbBpxJH7ZP82YjQ2ZuCboqFjat5HiWtI4I+Zw4MDy+7hneQ39A3nFSYSV0rANWqgqser nM86ObE/RWhLTD/NDcpMbPSdFJ9/wVTA+8X9MbpuMbx0blNUWhlAMyTAHAL5tBW5tnGR xG++x9JjfcbJvig8wMvHXUPy2yPw7pQbn6aiVcsT4qi7c36WglG0Uq1XPWMNABNaBBwJ GpGQ== ARC-Authentication-Results: i=3; mx.google.com; dkim=pass header.i=@googlegroups.com header.s=20161025 header.b="Q/OLA2CA"; arc=pass (i=2 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of isar-users+bncbctzztvx2qcrbanm3waqmgqekbynjni@googlegroups.com designates 209.85.220.55 as permitted sender) smtp.mailfrom=isar-users+bncBCTZZTVX2QCRBANM3WAQMGQEKBYNJNI@googlegroups.com; dmarc=fail (p=NONE sp=NONE dis=NONE arc=pass) header.from=siemens.com Received: from mail-sor-f55.google.com (mail-sor-f55.google.com. [209.85.220.55]) by mx.google.com with SMTPS id i20sor5077218edt.0.2021.02.24.23.47.14 (Google Transport Security); Wed, 24 Feb 2021 23:47:14 -0800 (PST) Received-SPF: pass (google.com: domain of isar-users+bncbctzztvx2qcrbanm3waqmgqekbynjni@googlegroups.com designates 209.85.220.55 as permitted sender) client-ip=209.85.220.55; Authentication-Results: mx.google.com; dkim=pass header.i=@googlegroups.com header.s=20161025 header.b="Q/OLA2CA"; arc=pass (i=2 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of isar-users+bncbctzztvx2qcrbanm3waqmgqekbynjni@googlegroups.com designates 209.85.220.55 as permitted sender) smtp.mailfrom=isar-users+bncBCTZZTVX2QCRBANM3WAQMGQEKBYNJNI@googlegroups.com; dmarc=fail (p=NONE sp=NONE dis=NONE arc=pass) header.from=siemens.com ARC-Seal: i=2; a=rsa-sha256; t=1614239234; cv=pass; d=google.com; s=arc-20160816; b=ttUxVbZ9JSAVq/XPDyEkhg2qXR26DhupMx8JJGGbu61kT2dVbWisBhaExl1EvG9dNL KD5XuAcPe+9tKTweWcmgCUDHYn560bDRTIheHtA9bD3PbaAGmZ7cjDcPyMtjotLiAtai whpcCRbDpQFcQnwYtOFOXe/oeVV4QBOsuO4SQ6auy5cPbOUvJUj041GM3Py8CrDkulOj E/d05f28W+Oe+aGVO2PT8Q5754qaL2xFFMCGGsHPPh+qwTX58YXYdVNtQ6Io5PsVQiuv f4/Fvby3HlzBpTHqFwlvgf0iikkHz4J/W5YwkCo1ppdmnBbbS+ubnm77PaCVy8YMTVum ZC4g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:message-id:date :subject:cc:to:from:sender:dkim-signature; bh=Vfy4LUAs0Zz/ae/vwyIIz08YN/I93FWGeu9t52z7YFs=; b=HZAT1tu8lvLlqgvjKhRVFmWsqDK53VWTOacOgW7S0SzaFLDk0LQzwtUgbZSMoFZGYK aRcttwAciG2/m1KyuZFhyL/cXyi3CI4umKO6nCIe2gisFDskXKANU07bM91Q439veZ0A X6iyddFZZzdaZ9JCCZMEN3lGCnrfxSO0ur5jLj09NKBG/U9D0z+aLh6tpVW7oNz3PxRU r46hBl6xQJqMNXYMTN/XyGVj6CVFHiADyYJuL7NAWtKtSYYyqb8YVRsGbJ5NfRUTvwjD dLaw9ZH5vSUmNGbNE2Bb9Yyu/P/Mu9W8KLtuoJTaPOJMaVBOvjqXezH47QZs9vVg1RtP b/LQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of quirin.gylstorff@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=Quirin.Gylstorff@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=Vfy4LUAs0Zz/ae/vwyIIz08YN/I93FWGeu9t52z7YFs=; b=Q/OLA2CAbQEz3d/rPNol8aWaVRKXS28gLWgMJFNeATRIVO6b8gVf1aOBPKOabrQsH6 27FgWk/fVPF0Cm5mwI6iK8I8BQc6pfuB5yKyrJIAYLvh/H+6VbCdTuw1vHjk1MXm7Vfm VZknA9G3unQkh/aKABomKoPvPc72NXIPmoy6UvxftWPF6D9dy4EYAA9GiY4N/1eVoXlq 6q5iLMVeuK0cT9gmR5qNpnhgh3X9gaeDnuYC/H3EQ5O2/kaJJIKHneCWB6AZ2Ca5QR22 jVXwjV+e9grw1cWv8jXCcT6PFtIKRa07q4mFkF/40wqxTYiAeJeDJg1UNeh1EXl4Fmnj 0N1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:from:to:cc:subject:date:message-id :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:x-spam-checked-in-group:list-post :list-help:list-archive:list-subscribe:list-unsubscribe; bh=Vfy4LUAs0Zz/ae/vwyIIz08YN/I93FWGeu9t52z7YFs=; b=kaoADjxTbwMia5ZVrRTKLYRIpzHSYmfLSJ/uyggdFo20VL1ep06trcJDLRdRFvhp84 rPb3y+vy7lPCwcLhWkfODNJSU4QuVvTjH+EJWZCQDjHs//TmzvuVSH12/t1q8/tQQ4yl tGCvTW+LnEpR79qvZrBgZd6yeS/34g2oXWpV7HRh76cqFGDQ1Big/fH08M/2w/TeR0Y4 u4VG9Kswtirdcp7YywYJ8NateKlODwTG9lA8TtKt5rmNJdrTK2lr26UZsSuNj7ftpxxe JUtZSkS1yiLErC1jugyss2DZfy/jvqTt0yby4DCpZKiQB9UEFH6nehbEy60V/Zjb8Xsd x6/g== Sender: isar-users@googlegroups.com X-Gm-Message-State: AOAM533ss3cu8ASnhO7HNADSwpftt7yZWU8ndyV8kIw+/mQA6hLiHMBR 2mCGTjWGjzdwwDX/ME0cdb4= X-Google-Smtp-Source: ABdhPJzRMLmTxcywuZFordtX5F/WkUiCFfHcJTiQq0bzGWXtJEDWqFnQ1TF1T6k1hWrnmvA+rcS3Vg== X-Received: by 2002:a05:6402:1641:: with SMTP id s1mr1661156edx.272.1614239234024; Wed, 24 Feb 2021 23:47:14 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:aa7:c909:: with SMTP id b9ls1020655edt.2.gmail; Wed, 24 Feb 2021 23:47:13 -0800 (PST) X-Received: by 2002:a05:6402:d09:: with SMTP id eb9mr1609241edb.285.1614239233224; Wed, 24 Feb 2021 23:47:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614239233; cv=none; d=google.com; s=arc-20160816; b=0J9NV3fVpMd2xPjkApTFYaWM4D1KOlYaPeonUFN4lD0s8Hjkh3I7bI8SsHECZmRdVk x2CiyRDHM4q/ARcASXqvFGHMUepIkqg0ATPU7dIIhdRZH5RzFDVKIpJAjEKMkY+hmPLh aUssEQlJIkFw6s19g13JkpLxxTfTOXdu+NmTZBjRuApM7rGIYGS47QflMhpBYzOSJIoR jjWhhK73tof4Y7pGC0/hlBb+GVNLl1fvCiz3qckzIORAAdEZVLRL4iDbopAdFg1X8KpQ kKhJly9plm0QmrYj0mZmJG0i3Y3oTYbVlzfrxFUfNJ6UmRRGmMhPfQYDDLZYZJiGR4bi +ZvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=sAl36+rtAywDebMUnMs57j9VQCZQNn2ksoulYAKpclg=; b=xyz2KkQsLgJ3zOaXFm9DBuSZOcGabekrqdLhhYbpQzlYjX+CD6pSH+DneFADt3YUiF zIJ0h956VSx9vZbmGlCd1abOW1aUBYQqfQmAlR12TDVT98P2wbsaH4XZXnTiZSWq1hFy VYvUW0+xGGoSX6DqdSeRvJ7OfUsmU1MPQ2z+lqnxawm+k+0H6X7KW/BpY52S1Dd6bKbE 4FRGKRpEWRCSb1q2veaOSxEWGAFMjA2i7T43s9llygK2m+EsWr5zb3ej4qP3IGZPOgoI IZ3zNR9mY2WyOmDvzz9tY5btg0mwFkzsyubzPuzbi3R8GeMQRCtLDHM1zz6XKXCAeicv kmXw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of quirin.gylstorff@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=Quirin.Gylstorff@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id k3si207761eds.1.2021.02.24.23.47.13 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Feb 2021 23:47:13 -0800 (PST) Received-SPF: pass (google.com: domain of quirin.gylstorff@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id 11P7lC0R031902 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 25 Feb 2021 08:47:12 +0100 Received: from md2dvrtc.fritz.box ([167.87.33.36]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 11P7lCRI006473; Thu, 25 Feb 2021 08:47:12 +0100 From: "Q. Gylstorff" To: isar-users@googlegroups.com Cc: Quirin Gylstorff Subject: [PATCH v3] sshd-regen-keys: do not enable ssh server if previously disabled Date: Thu, 25 Feb 2021 08:47:12 +0100 Message-Id: <20210225074712.31768-1-Quirin.Gylstorff@siemens.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Original-Sender: quirin.gylstorff@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of quirin.gylstorff@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=Quirin.Gylstorff@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1692583976186673736?= X-GMAIL-MSGID: =?utf-8?q?1692652519452411511?= From: Quirin Gylstorff The code 'test -n $SSHD_ENABLED' always returns "0" and enables ssh even if deactivated previously. Adding quotes(") to evaluate the variable content instead of variable name. Signed-off-by: Quirin Gylstorff --- Changes V2: - add missing space Changes V#: - clarify commit message meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.sh b/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.sh index 910d879..50f45eb 100644 --- a/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.sh +++ b/meta/recipes-support/sshd-regen-keys/files/sshd-regen-keys.sh @@ -12,7 +12,7 @@ rm -v /etc/ssh/ssh_host_*_key* echo "Regenerating keys ..." dpkg-reconfigure openssh-server -if test -n $SSHD_ENABLED; then +if [ -n "$SSHD_ENABLED" ]; then echo "Reenabling ssh server ..." systemctl enable --no-reload ssh fi