From patchwork Thu Mar 21 07:01:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Badrikesh Prusty X-Patchwork-Id: 3423 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Thu, 21 Mar 2024 08:02:15 +0100 X-Sieve: CMU Sieve 2.4 Received: from mail-oo1-f58.google.com (mail-oo1-f58.google.com [209.85.161.58]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 42L72Ba2024004 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 21 Mar 2024 08:02:12 +0100 Received: by mail-oo1-f58.google.com with SMTP id 006d021491bc7-5a46b391b53sf455986eaf.0 for ; Thu, 21 Mar 2024 00:02:12 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711004525; cv=pass; d=google.com; s=arc-20160816; b=ue48YNv19VFaNLzqFdXscYI5vyndlUtqjsAQXxoc5jZhWRGOnxjum7eSevbzzUg3mK k9igUOk/M5ZlhlbuipwlSdCB5ykKUYB6+0tG8zAATlt3PK4CZ3Waim58KvcCLHCaITxI Hsh1wQ98iE5yr7zrETGzkDsRdFKCruOApTCz1CrDV3iDqeG+OMNjz2b3z88cWaY96On+ vTgkN06T4QZe6R88oTrR88hOLc0mrqMh0w1KNAh8SYG+kHQXrK9c8scEfrWswnf7O4+s hLnoqLFwMEgIcpqo72OEyH2uKzaCg7TGqksryLzDoZxEKbjBAs5EVC6Rv1ClA7NdzD9q Q1uA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:message-id:date :subject:cc:to:from:ironport-sdr:sender:dkim-signature; bh=9aSwIki5SR9aNJIB5NXge87GUHizneczbtqHmDb2bLE=; fh=sLR3ibOMAIU1FqlxIkGd8VL1y78UuJ507UmoUHf5kDA=; b=DP1+CUL28q+9P9HdCmS/DbFWOVseqBxqLoibEwGg3Rh36ZzxnCxOiX6vtixGSLK6o4 vSCoVXzvTKQ4m56xN93OIBAjS3fJS4I0+3WHoB/4aXpRTdrlP5tXg8+o0kGgIwMZpSEU 9anh+A5HodIvMfgew9wq7qriHBXzmAFkonFPrAnf3P3pZDf8sG5a67/mwBtNh7vg9BpB KBUFrPTURw5hDYv3yA15jTQUPflhF4QXLIiXzpEox82Uxlr9ldezGzfL/JdO2Q7izlFp c0rIYx1hbOm5CX+oA6LTgI+NTylln6Mwxa9B6hXgn1L6myIwaNxKSZkIsu0xbr9JYdyI HxOA==; darn=isar-build.org ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of badrikesh_prusty@mentor.com designates 68.232.141.98 as permitted sender) smtp.mailfrom=Badrikesh_Prusty@mentor.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1711004525; x=1711609325; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:message-id:date:subject:cc:to:from :ironport-sdr:sender:from:to:cc:subject:date:message-id:reply-to; bh=9aSwIki5SR9aNJIB5NXge87GUHizneczbtqHmDb2bLE=; b=O8fuc695PL3YbEgdQuvMvwxssL0yulpGq7LvD7kQGjtFd7Fd3Q3bqXZv3p0kf/e2Lf TCCgxpgnWYg5pjlMQzziWe+hruULmoUQKqKF+oeogdtpJlI7yNIE8RogPESz3ba2Nr4h ryOmt5mGcHGAb++IQlMEKZ1qEimVewOyag60KdZrJJNSkkpQflw2SPd/BrTyqMjegiOP R268EqcSJlexxz8htW/WkOELcS981bGB4Qh4cxW7QTvvo+rjBBTVtIcqvn4J6pfck/vh Jdb2N+WCZjEjoKmD3saDv+V69ZAuSKVMxl5yLBtJYt5898QsbZhra/GEopi1J29PdxaL cryA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711004525; x=1711609325; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :message-id:date:subject:cc:to:from:ironport-sdr:x-beenthere :x-gm-message-state:sender:from:to:cc:subject:date:message-id :reply-to; bh=9aSwIki5SR9aNJIB5NXge87GUHizneczbtqHmDb2bLE=; b=GIVSiDyqr+yrWrBwxkgWTqKQg9JxB2oQT07mkxkA0yWYwJpbQtUZy0NbYoy1OyMNhc dJrb/5yjbErOZBoSr0K9nirz9FyVRv5W2gcagI+iIDTDviCmIb6dJAJv7TQjoPeZ7Yo5 8HnRLNFv85opfek7+QUB9EwtnHB0SgLYU/GnJ8+NzL0g3JvOdwL70KRlXED/9yaVBlaY TLHnYzc6mHDR5AuavWtnoFDDxtZShDORRnwiXZDZpO7H2ln2HXNstw9Uh8lK4aZOG9my NmmmmLlsYj0Px4lO2xkhMJ919Be33NKYZjuf69N8VVjjXs22XIEFQSId68o+AXL9lnTf gAWA== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCXaEAuPpW1xaKi6GcHf2zWspY3VO37jm9IcoV3riLH33RgMKnA6VmF4ruO+xsToyZmsWKZNsLHtHD0NEo1QWbQtANhjYHk= X-Gm-Message-State: AOJu0YwFiFyFsOjn6P/QoZUl3QdIlnT8ZGKx/ZJZvkHC7RojD8AU26ee 5ve2WRq4m3JmC9H3TLZHA2Z4EeGJaOdRlAPuLEKEBXMmePgyiCy1 X-Google-Smtp-Source: AGHT+IFqXbWZ2ah+a5dmXDt29AfuO4AeNWxsMVOBn1iE7UleBZlmKp6DYb/p4aP7uIk1XDKmKZNOkg== X-Received: by 2002:a4a:ee84:0:b0:5a4:942a:2a9b with SMTP id dk4-20020a4aee84000000b005a4942a2a9bmr14034320oob.8.1711004525612; Thu, 21 Mar 2024 00:02:05 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a4a:e0d1:0:b0:5a4:3b6f:c4fa with SMTP id e17-20020a4ae0d1000000b005a43b6fc4fals586077oot.2.-pod-prod-02-us; Thu, 21 Mar 2024 00:02:03 -0700 (PDT) X-Received: by 2002:a05:6830:4b1:b0:6e5:3134:10f7 with SMTP id l17-20020a05683004b100b006e5313410f7mr21429828otd.32.1711004523217; Thu, 21 Mar 2024 00:02:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1711004523; cv=none; d=google.com; s=arc-20160816; b=fUAsMcghVGN9ru0QE18Yvf462oRr45hY6VvhJDt8K91o3bkmhvagM0NKh9Cf0tYLTJ oMJYOQZEUJ6q78Sn5YHEr0GbsDuU/VHNh6/USotW0NuCWn1UrJ3kQvm/gKia0RZkLgLL oyxCTqHQaY759Xz05lNwkOm6PGUzlx4lxOuskcpMH7J1VQZWR65jgQPOxN9Obi8/cnvX uzbOC1GvX+GNvQo5/0hvnGWUIFEwDuGe69AbWWjS0Z8Siu4bUoFAXclsHVGR8cah74n2 2B0cXGgbvjv/mGGQG32e+KY6tfxLJ8qWDjDZHUeyfO+BwtBPFAiQNx2fGMvM9g2WjVDY fI4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:ironport-sdr; bh=SpuCw9t/Rdhh637+ulwC736FruuDfforCpiWnO5bO1c=; fh=F4R8d8MZz4e5TZM675wSZVz+eMNa1apx7X6eFG4Iths=; b=smTh2Tpes+sDj9OJAtLgHQsNhb6GdynOuHVtS/JWhA9pfkLYnQcaCXqD3Eq+UI/OwR UgTB6aa+cNPbUi6EMpVPFDr5yUfba6C6U9U6ofLT9tBaJlKtIOVIz2pvEq84HxZLkeD/ g2NJMx6Cvz1FwpMwX7WdSBeXHCbSRQYuKn5QQWn7j/Ww4igC18gl7BEUNj8C22vRg65a BknSP1YQz8ROudlYNOcz3OBDnz4RwaLA2Tlmy47nvKCkn2gllrgO4RlF5n575DJef2oA YC3RxSbYA0JLCor0dFKl1/jI5mJF+rQSC53QYLyzXwTXqcYfbaI62D+PqSGL5qf30pOE IZqQ==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of badrikesh_prusty@mentor.com designates 68.232.141.98 as permitted sender) smtp.mailfrom=Badrikesh_Prusty@mentor.com Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com. [68.232.141.98]) by gmr-mx.google.com with ESMTPS id l2-20020a9d6a82000000b006e6a1f0ac32si352847otq.1.2024.03.21.00.02.02 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Mar 2024 00:02:03 -0700 (PDT) Received-SPF: pass (google.com: domain of badrikesh_prusty@mentor.com designates 68.232.141.98 as permitted sender) client-ip=68.232.141.98; X-CSE-ConnectionGUID: J4B0AXw7RxCfhaxO6nC5Tg== X-CSE-MsgGUID: IHll00iYR0KOVYQl6a0oQw== X-IronPort-AV: E=Sophos;i="6.07,142,1708416000"; d="scan'208";a="36340820" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa2.mentor.iphmx.com with ESMTP; 20 Mar 2024 23:02:01 -0800 IronPort-SDR: uWnj0YvmlCM+VpqXtxW2rG1rFnOQFYQ1v7GjU2xulvIaXMf/pBqMIvwixPDFT5AJubXunW/oXn XoqlnoTil5Edo/RE5SNG3aPpnWQgeEehRTLA6hpQK+VZoXp+jYI/pWiatQGkvOZxhOYJL2FNp9 OnkBAzQLVqwmPKP6R6lHPTJXptU05cE4K0RTYnK8kNeuaEINVOnkPy2htvspY3cyPzkLw5P05h w9CXab3NRszSSGi+/NfSeWrRLzD3mRr68dvdLlH4VNW9H+KZJ2U+BUtw/NHu1HUoYi9tcd4smv VkU= From: Badrikesh Prusty To: CC: Badrikesh Prusty Subject: [PATCH] scripts/start_vm: enclose -append args in quotes and use eval Date: Thu, 21 Mar 2024 12:31:19 +0530 Message-ID: <20240321070119.2973182-1-badrikesh_prusty@mentor.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-ClientProxiedBy: svr-orw-mbx-11.mgc.mentorg.com (147.34.90.211) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Original-Sender: badrikesh_prusty@mentor.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of badrikesh_prusty@mentor.com designates 68.232.141.98 as permitted sender) smtp.mailfrom=Badrikesh_Prusty@mentor.com Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: Badrikesh Prusty - Observing boot failure of qemuarm64 with error message: 'root=/dev/vda': No such file or directory - Fix syntax for providing -append arguments with qemu-system-* command - The -append arguments must be enclosed in quotes - Use eval to execute qemu-system-* command - Fix consistency with use of spaces instead of tabs Signed-off-by: Badrikesh Prusty --- scripts/start_vm | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/scripts/start_vm b/scripts/start_vm index 8c696a4a..e9f13dc0 100755 --- a/scripts/start_vm +++ b/scripts/start_vm @@ -19,18 +19,18 @@ bb2sh() { start_qemu() { root=`echo $QEMU_DISK_ARGS \ | sed 's,##ROOTFS_IMAGE##,'$IMAGE_DIR/$ROOTFS_IMAGE','` - [ -n "$KARGS$EXTRA_KARGS" ] && OPT_KERNEL_ARGS="-append $KARGS$EXTRA_KARGS" + [ -n "$KARGS$EXTRA_KARGS" ] && OPT_KERNEL_ARGS="-append '$KARGS$EXTRA_KARGS'" local had_x echo $- | grep -q x && had_x=1 || had_x=0 [ $had_x -eq 0 ] && set -x - qemu-system-$QEMU_ARCH \ - -m 1024M \ - -M $QEMU_MACHINE \ - $QCPU \ - -nographic \ - $EXTRA_ARGS \ - $OPT_KERNEL_ARGS \ - $root + eval qemu-system-$QEMU_ARCH \ + -m 1024M \ + -M $QEMU_MACHINE \ + $QCPU \ + -nographic \ + $EXTRA_ARGS \ + $OPT_KERNEL_ARGS \ + $root [ $had_x -eq 0 ] && set +x }