From patchwork Wed Jan 8 15:22:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Mikanovich X-Patchwork-Id: 3997 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Wed, 08 Jan 2025 16:23:16 +0100 X-Sieve: CMU Sieve 2.4 Received: from mail-wm1-f61.google.com (mail-wm1-f61.google.com [209.85.128.61]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 508FNFcj020958 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 8 Jan 2025 16:23:15 +0100 Received: by mail-wm1-f61.google.com with SMTP id 5b1f17b1804b1-4361eb83f46sf122355935e9.3 for ; Wed, 08 Jan 2025 07:23:15 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1736349790; cv=pass; d=google.com; s=arc-20240605; b=Hcqc7up4dfdra4oFHym+l4zbH31eiPXpHLfPa3/xJ8I5iUcJXrfFSAbUKbv57kAlXM y0o8EqVgI8L1Fx+jYOW+e5SY6Cu7yUDcfRQvncSJ3I7c0VLxZhj5KdtbJG1pzN0EhVde EuC4RLWiK42KSr0hjg9vBZR1Gja8lJ7erzbZh8kk4sRr6BBowX/+W+lf7tNBxpX1g34I sqeKocUyXoogjmuJzBH18hdkq2iaV+ciXB2errPANb/Xizgg56Bd3iRsGJ/s/1VqDbeu 3/6r5g2+5aVoWdV14SB9RlQNqKIbXuiWsZ8XpGvAcBo1pg0HtS062i4dLhO860zaXqBp rH2g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:message-id:date :subject:cc:to:from:sender:dkim-signature; bh=8cUNyBZgYM9m6EaMJhPbhfet+QNCNWBoW2qh1lPG/b8=; fh=uIjlWnpH3fPFNdHE6f6FhNUwc6aRnKa2O7ybA8d1rIU=; b=MDIzKhNUK6qr3rofAXG6QMMTl2HVEI4ZhzvlI5rVCJomZ5qCR391BqNcyi0j4IDxeU KheurPl2IbTnFuSi7cc13QzOQkNJ/nIvkAg0ATDVi4iz+NSFWttQrc5tveekezrBQgQM SLbAwUimZcU9U5abVbD3r2L9P+8SoLRty82TlH84PcRixGHtFkJQZk6wGDqymnyhqW8A CPPTDpKZ00QI1HzBjiXMT0w6UjG4zB5cMWuQux8CYYSESBnO2/YDg4dd71SXPMIj9Zpf I3imC9Ei6tpxZeXiYTUls5hEPx5Y/kjGKL7d6CHTTe9TkkFtoUjhGUib8sQP4yCDe1IO SpQw==; darn=isar-build.org ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1736349790; x=1736954590; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:message-id:date:subject:cc:to:from :sender:from:to:cc:subject:date:message-id:reply-to; bh=8cUNyBZgYM9m6EaMJhPbhfet+QNCNWBoW2qh1lPG/b8=; b=vdCSO4x+C5qSejFo6nNAjfjkLZHoThbLAldbJBC76SkIzw7fkxvhV6CLSMQqUr6bVC T1yRMh5r2n03ZihMiOdrFWEhCnwCduFrcm0Rh52RFFIHi5Jhk3CWG/CgKkZxG0sPBqWG zYd+/R0krJCVf7DIZl6bzQ5G9M9LnWSMyBITDNYQC4K+u3o/MO8JAZ9elMzZO8VouQsl XZLaj9rx38gdm9h9BE9o8mkxZ2KsC+jx9Bze8psbs1TPczwcthGsnHesevhTVO+XZRBs fhM32cm500Nm50T0P1NqGiUA979Gp0hxsfPtohiZ+XsM4WRrdQrnMaCa6opDLl1UWnQO whGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736349790; x=1736954590; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :message-id:date:subject:cc:to:from:x-beenthere:x-gm-message-state :sender:from:to:cc:subject:date:message-id:reply-to; bh=8cUNyBZgYM9m6EaMJhPbhfet+QNCNWBoW2qh1lPG/b8=; b=YJc61tNCaBXJdvAhvTGrDVX/jjdvHaAoBMFkBar1FOyOsZWgzqCOVpSPELvLeCfsHM B7KVgBBCtYja6JYIiN/aWqdPji+2MBtmucBgVji40eoMK6kqCmvdgIxwjRiVuUu/LiSq ZaEgEAEUVhsQohbo3U9fOjNnsiUiazd8peTryuYNCU7QbTDEurrOxSreNQxHgUFc9pD9 6cRUx5xUowtGYqf+VSO6FsUzmpMv3AbD9gAssgyX0BWX+gOBBejlCekRYMDl24L3wxHE n8PH1f0tyfO+P3qMfcphwC65G7MzWSOfIjh5+8i2RMdb/S1q18LtqwTMjmhBgJ85dRkp sMtg== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCX+NR/U5UGDfegQEyT5hrA9AW4T2CuorUtyMQ6ttQMw7I8es1Bcsrkoqn1/KZ/s+EUwjItTjWo=@isar-build.org X-Gm-Message-State: AOJu0YzMuujEL43kNZgL6g84YleknB9AyxM0teTnCGNRByGhmVasBBVQ ef9qVhj4veybpNy1c8tRZbUVlNsb3FY6LeP6acd1Rqcwv+O5dZvF X-Google-Smtp-Source: AGHT+IFsTWsuZmKUDTbAHEU/LVzlOEgikdfSauPLcDuBbLp8M0DPBqtRIyBFHWJhnbCQNpTDDeG9kg== X-Received: by 2002:a5d:64aa:0:b0:385:dedb:a12f with SMTP id ffacd0b85a97d-38a872fc200mr2614042f8f.6.1736349786261; Wed, 08 Jan 2025 07:23:06 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6000:1811:b0:385:df0c:c6ac with SMTP id ffacd0b85a97d-38a19fb2621ls171348f8f.2.-pod-prod-02-eu; Wed, 08 Jan 2025 07:23:04 -0800 (PST) X-Received: by 2002:a05:6000:4011:b0:386:3835:9fec with SMTP id ffacd0b85a97d-38a873306cemr2615634f8f.44.1736349784066; Wed, 08 Jan 2025 07:23:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1736349784; cv=none; d=google.com; s=arc-20240605; b=Nj1Vwkzj9ItGvJJ7Jdhr4zxys+UMyHXZRbeZ6+u7pFUSb4ejaioBqQZS+ROfSV0rCi Zlb1piKG01jY8XHY1B8zvY296v7TLtuor/4B3pV7+rIIOTZbgg3L3tK1aIqnLarOw5J+ f57bq24Bcn5ODN6ivTEEutAoCQu9Nsv1yLVDEVNdlXoBG+RQH6fplxvwJVmC1Jv3YWAr 0qcVnPrUXERWyzF6LsQcn2mY6+ii6vnGeJCFfeofvU/TxKu6VfWnDdxaXFUCyFahtaAm N3Z9eGSQlOvRoyh6OTutWE8De85As7XPNtGhr7c6MC0bfr9cYxcgFkOZc7Ru4JK/sBCq HlXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=tYiplMv6N2mWA8ubPQ3mv0+4l0gj13SVWGEWwjop/gI=; fh=/h9QQkzJ8EboVkWg45aWwpaUro6WMavIVd2OhN45RtE=; b=TWKJnNuoqtd5BOi4eAkVMgeaHwXPglFakGES1Zk2OdOPsTzUwMMn/NiOZGBa5X0FL4 9VlzWeMJd6VnnLwXfqEVmi+EQy3hhHeH8IMttM3iUBc5gWNSnEpo36qO8NGNLnEroYZk pZjFwnHaZbIIQdEWUJ4cmxmmxjfslvLaizS9CI7WzS+eF2JXaBix9n8cXX/s4AfmDlT6 a4jaZl6wc6MA0mmAFWVKwS7UGscpOBkZgZ+Jko3BC/3czW+k0UtRp/lcXcZdTjY51kCc PJC+OWaX2aNvAp5z4M4EsSKNxRB3qYVnh3p78wYdO7EZB+x4LGXir96PUKndXQcQ4aoC b7gw==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 5b1f17b1804b1-436dd0fd098si3145005e9.1.2025.01.08.07.23.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 08 Jan 2025 07:23:03 -0800 (PST) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from user-B660.promwad.corp ([159.148.83.114]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 508FN2iX020945 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 8 Jan 2025 16:23:03 +0100 From: Anton Mikanovich To: isar-users@googlegroups.com Cc: Anton Mikanovich Subject: [PATCH] devshell: Fix wrong PATH value if disabled ccache Date: Wed, 8 Jan 2025 17:22:56 +0200 Message-Id: <20250108152256.851757-1-amikan@ilbers.de> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: amikan@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= In case USE_CCACHE is set to 0 the value of PATH_PREPEND env variable will be empty. This makes PATH in devshell looks like: :/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin If building the packages having directories named the same as some binaries used during the build (like dh-python with dh directory inside its sources), it will fail with the following error: ... debian/rules binary dh binary make: dh: Permission denied make: *** [debian/rules:4: binary] Error 127 Make devshell expand PATH only if PATH_PREPEND is non-empty. Signed-off-by: Anton Mikanovich --- meta/classes/dpkg-base.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass index c02c07a8..4468a49a 100644 --- a/meta/classes/dpkg-base.bbclass +++ b/meta/classes/dpkg-base.bbclass @@ -258,7 +258,7 @@ python do_devshell() { apt-get -y -q update -o Dir::Etc::SourceList=\"sources.list.d/isar-apt.list\" -o Dir::Etc::SourceParts=\"-\" -o APT::Get::List-Cleanup=\"0\"; \ apt-get -y upgrade; \ {2}; \ - export PATH=$PATH_PREPEND:$PATH; \ + if [ -n \"$PATH_PREPEND\" ]; then export PATH=$PATH_PREPEND:$PATH; fi; \ $SHELL -i \ '" oe_terminal(termcmd.format(schroot, pp_pps, install_deps), "Isar devshell", d)