From patchwork Fri Apr 11 11:26:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felix Moessbauer X-Patchwork-Id: 4166 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Fri, 11 Apr 2025 13:26:39 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-wr1-f59.google.com (mail-wr1-f59.google.com [209.85.221.59]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 53BBQdTU017754 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 11 Apr 2025 13:26:39 +0200 Received: by mail-wr1-f59.google.com with SMTP id ffacd0b85a97d-39130f02631sf747909f8f.2 for ; Fri, 11 Apr 2025 04:26:39 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1744370793; cv=pass; d=google.com; s=arc-20240605; b=Qwf4O0+8WkM4fwqlTkhq3HBCFvEa5MpQJsA46YwqUmjyEFlEN7/FHfS3GyINuA11qz SgqvjqRxelgIUHQRGNjBEFtUS+LS+IUwNbDFxJ0TxXGK5hVHGAvZhTuRV2ShckdjfmON YW93cx+HkmUKz68adcMOpwQuQv24Cn7jsEGRmZvhyy0IYVx0YE72n9piUxEYy8XM+MzD zLnHMRWY3UC8xJnAyDDTWlGMbXu1vABoAMNcwYDupeDANht2SbJ/4lHdIO7230pMPWDU GI5YN3Ljo4HT56DA+O7yyYUA8KdncIpTtU9WKA1w/4qtWwuHzHY3zuKvqOLFCKDMpNJ7 ZjoQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=07Dqq4E0pbH2MBNfrgb4Lr+zpoHkMOQ6p+zTizywm4U=; fh=CimYiw5ySkkKTtDhcXoVCyl5KqykACrpY3S570dfiyo=; b=HgQWr5awNMsFFl6AyIEuJc82e60rEB30I2gYYMnO1YSCOb1vWn2/0NrM13Wfsrq9hb 9NYWm1F1ISfafBxDg5geA+k/NxiLuYgqyjkInWtWi+E6Rx+6TCtv2Gkf3G0PyyTsFLCZ m50emxrDzw+e9lMh1+LF5Uz58PSPeyhwnlI+TAO90us8OPXNS594p0dn9BsVWMvDemcX qHkRoU0xuLkaZ+jlKd5q5BpX3eCZ1jyT9owTFpOC0SNhE+18rKLcJL6ZzYHFLG4R3QS5 Gu4qhcb0s3nbzvR898GrtUnFHw48BStK3IMmOQNXFlg/kXCwYnpmckW9KRwnwpU4ss8U kJvA==; darn=isar-build.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=WNbC7Al7; spf=pass (google.com: domain of fm-1321639-20250411112629c61a7fda0580e9473b-ubn_zy@rts-flowmailer.siemens.com designates 185.136.65.226 as permitted sender) smtp.mailfrom=fm-1321639-20250411112629c61a7fda0580e9473b-uBn_ZY@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1744370793; x=1744975593; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=07Dqq4E0pbH2MBNfrgb4Lr+zpoHkMOQ6p+zTizywm4U=; b=L6dfGn0Pee64J8go8rUXcO0IQz9Y7CPiz2SJZIo7iu4OARK21d+NgdyuKHDpaXwhJp bAw97Ob8vguqq0HUncVsx/TgKjc5LfpoDH/cCgHNju5reLT5p4FWMdSd6KU5PzQezGNE ufdPPcTW9jqJ0i1Hc57CFfw12La+C1KSty5jM54wrsTYusPv2LFA+ohNJFmKu+XesUit AokMb8lZJwg+CHVd2RTCqzGLzGm9aX+5LKzYWcEldtCAp7KmJqeOyYjEuIwG6zTVxDHA 5/L6WOeNzp0c0dMfq/+hPQpxZo3upXoCAzT1XkfIEp8Ymtfvg1De4O9AsyrMJANA/VMo j4Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744370793; x=1744975593; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:x-beenthere :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=07Dqq4E0pbH2MBNfrgb4Lr+zpoHkMOQ6p+zTizywm4U=; b=L8INQdRhi7F8QX6LGaM2l7UlN1mS4o0etBG41SUZ0DNWSE0oGKvbgm33pIppsx0o41 9D9CT9lpqptB5Tt2F1MS/O299BtcoHo1XTSF2THWVVfqv+eWG9AN8Bz0fzlnQKMAi8wj gcwhi/+kTIqXCQTwLoDwodn7HvFjXzpi4eIZm6o1Ntqc3EnM7g8TdYqh6eIHIUoejd0H YVQmdFWiNzKc0aN4Juk3QfUBngRJqr3IKKpngjCUqoCoynjRBB5aMnREHy2c5XOl+8c/ Djak7l83GevYGvQUPq1X1qed3NAhngWahEOutnE9ufqJAqTFrGBDTN+LPw0UN2GW7viF kmLw== X-Forwarded-Encrypted: i=2; AJvYcCVgNyH81og/8nTt4o1m/h4epdY0XaKyU+pPP4eXZNUpUUVV/z4a2hMbn10u1wzA23NlDzwoMYU=@isar-build.org X-Gm-Message-State: AOJu0YytZ0L9Qmkn+GTxhNl/OwCrdnCoqMgKN+Xw3oqwI3oGzn3Jcijo Wgg1RWBEPylYATUlCLoIWwNzyjNxnz5/Ag+s0+YeuooqfEaLYPER X-Google-Smtp-Source: AGHT+IEopgc2u99QUVm2zmPikRMsF3BROhWqAlqAV3OkoiKldvhqgbu9+vowmYg5gVfZC7O4q8+Reg== X-Received: by 2002:a05:6000:4387:b0:397:8ef9:9963 with SMTP id ffacd0b85a97d-39eaaed5841mr1761483f8f.55.1744370792957; Fri, 11 Apr 2025 04:26:32 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h=ARLLPAJPdnFtLGHlhl4hnMBANtMa3PUga+zk1qXhwwQljtFM5Q== Received: by 2002:a05:6000:2401:b0:390:dd70:6845 with SMTP id ffacd0b85a97d-39d8df1b5a2ls1137077f8f.0.-pod-prod-01-eu; Fri, 11 Apr 2025 04:26:30 -0700 (PDT) X-Received: by 2002:a5d:59a7:0:b0:39c:30d8:3290 with SMTP id ffacd0b85a97d-39ea51eee3amr1774379f8f.7.1744370790116; Fri, 11 Apr 2025 04:26:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1744370790; cv=none; d=google.com; s=arc-20240605; b=VZwYs+PQaQeekfPteYUBwqug3fBWwv4PbxjPjdW+M93IUkVde8tF2HodgNQlKXNVZP Mwc2BpjzR8RdFVuWutEYdOTvqDYKO3DqxbtVCKqiJ7KSsP3YTzzCnJQosd5bAZlbWBB8 KHDY5hmxMSiQ4zo3A4P7NhQbHM2uHB6sv9IHmQIxM9CazHcs1ojCZEMTGLGdIGlAT37s j0pktdRIQYiI83nIhMCeGC88DTcbCCbo79vep4Li2h1g9DcWuidnhGD0iY0XAo3Tz57c ltsZUfZKZOGL7p3ZTEfdQz3lKg8uVIoktY+kDhTnVd6mHzAp5i392tltoh6elCdexM+i bUoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=feedback-id:content-transfer-encoding:mime-version:message-id:date :subject:cc:to:from:dkim-signature; bh=qR17KNg1Jh5+OMhJmm5flNeHHPHSNbaCzDXPYFAd2g0=; fh=upEgivMM8FVJT6j5EqQeIJ2Ga3K2ZXl0EQ0zQKls27g=; b=dHLmBeDP1mJnSen4sM/tTRV6TgSDOZ2QRp2STkCebCNlqiuAdJ83cSdtPGDH6gyypU x16FwoM+65LR9APuAjOAM+Wby2JFdfs3s51fRBmKu/JQU+A9Gh0s+v4RjaZ0ogS2USiJ 9mntrEaySAQGsWb82IPFsk9dWI9kanStEHYkHx3XUtfrycD7q7TqykIsb7+W1eHMNNJD He4uNfahaNWSGM8GvfqxUdteJ5xW3OBpqlnGrGONNGVp7J6aj+e+/28aa5Vfq3+VfxQQ b33qJlXFHtzzK8TK6zWEgl72zqNmmNUvbs5S1uT554ZXzjD1YZH+QPpn2J6QGyry3Q5v ok7w==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=WNbC7Al7; spf=pass (google.com: domain of fm-1321639-20250411112629c61a7fda0580e9473b-ubn_zy@rts-flowmailer.siemens.com designates 185.136.65.226 as permitted sender) smtp.mailfrom=fm-1321639-20250411112629c61a7fda0580e9473b-uBn_ZY@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-65-226.siemens.flowmailer.net (mta-65-226.siemens.flowmailer.net. [185.136.65.226]) by gmr-mx.google.com with ESMTPS id 5b1f17b1804b1-43f33c3807dsi552935e9.1.2025.04.11.04.26.30 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Apr 2025 04:26:30 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-1321639-20250411112629c61a7fda0580e9473b-ubn_zy@rts-flowmailer.siemens.com designates 185.136.65.226 as permitted sender) client-ip=185.136.65.226; Received: by mta-65-226.siemens.flowmailer.net with ESMTPSA id 20250411112629c61a7fda0580e9473b for ; Fri, 11 Apr 2025 13:26:29 +0200 X-Patchwork-Original-From: "'Felix Moessbauer' via isar-users" From: Felix Moessbauer To: isar-users@googlegroups.com Cc: adriaan.schmidt@siemens.com, Felix Moessbauer , Clara Kowalsky Subject: [PATCH v2 1/1] fix: rebuild rootfs on change of USERS Date: Fri, 11 Apr 2025 13:26:18 +0200 Message-Id: <20250411112618.3992560-1-felix.moessbauer@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1321639:519-21489:flowmailer X-Original-Sender: felix.moessbauer@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=WNbC7Al7; spf=pass (google.com: domain of fm-1321639-20250411112629c61a7fda0580e9473b-ubn_zy@rts-flowmailer.siemens.com designates 185.136.65.226 as permitted sender) smtp.mailfrom=fm-1321639-20250411112629c61a7fda0580e9473b-uBn_ZY@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Felix Moessbauer Reply-To: Felix Moessbauer Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= In case a change to the Isar created users is done, this currently only re-triggers the do_rootfs_postprocess task. This task changes the rootfs (e.g. home dirs are moved) and by that needs to operate on a clean one. Otherwise old homedirs might still remain in the final rootfs or move operations are not possible. We fix this by ensuring that the do_rootfs_install task is executed whenever a change to USERS is done. By that, we enter the do_rootfs_postinstall with a clean rootfs. Reported-by: Clara Kowalsky Signed-off-by: Felix Moessbauer --- Changes since v1: - Also add dependency to USER_ for all x in USERS meta/classes/image-account-extension.bbclass | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/meta/classes/image-account-extension.bbclass b/meta/classes/image-account-extension.bbclass index ea956cd5..3c461b1a 100644 --- a/meta/classes/image-account-extension.bbclass +++ b/meta/classes/image-account-extension.bbclass @@ -8,6 +8,10 @@ USERS ??= "" GROUPS ??= "" +# rebuild rootfs on change of USERS as homes might be moved / created +# no need to depend on GROUPS as they don't create directories +# groups need to be created before users, hence do not move the user creation into +# the do_rootfs_install task but only add a dependency python() { for entry in (d.getVar("GROUPS") or "").split(): group_entry = "GROUP_{}".format(entry) @@ -16,7 +20,9 @@ python() { for entry in (d.getVar("USERS") or "").split(): user_entry = "USER_{}".format(entry) d.appendVarFlag("image_postprocess_accounts", "vardeps", " {}".format(user_entry)) + d.appendVarFlag("do_rootfs_install", "vardeps", " {}".format(user_entry)) } +do_rootfs_install[vardeps] += "USERS" def image_create_groups(d: "DataSmart") -> None: """Creates the groups defined in the ``GROUPS`` bitbake variable.