From patchwork Wed Aug 6 05:54:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Shekar, Kasturi" X-Patchwork-Id: 4265 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Wed, 06 Aug 2025 07:55:02 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-qv1-f55.google.com (mail-qv1-f55.google.com [209.85.219.55]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 5765t1xS021154 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 6 Aug 2025 07:55:01 +0200 Received: by mail-qv1-f55.google.com with SMTP id 6a1803df08f44-6fab979413fsf123101426d6.2 for ; Tue, 05 Aug 2025 22:55:01 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1754459695; cv=pass; d=google.com; s=arc-20240605; b=CthYy29rRmBAMgWpCqFD7/GfMV/oemDDT8XQpK+TfdGhCJsE9cbUBR1H0VlYMv85C4 vbLhB4HT5rrgx3EbXX0dnd4p89ltUWIxIh6TK3JVl+yhmj78KHX435BJIg6Qf3/mUGRU An/D8mPxlxJuPYU1ZBHCGmv5MZW7iyODqxxPvVyf9oBoaZWjwREQCu4Rc4z0+m+mEtXE RwMWFcoM+3AkKHBjZpGwaDqGMJ668PBv7N6mN0mkZHj9KBfr429BuY9zms+kBJe/OeUy s14NV5GB1P42O1B8A0rEuSAWny9wDmaMZPjc05eIZwbPm90as184SxcN6bC+Jss0Sdpl 1Y8Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=RKD6NKL1XLvpeNwmCHO+7JOkE8GQ9E06czj75RhqC7U=; fh=bPej6hNgh8DOingh0kTmBzZPUttHVWukI4IGif5Gbgg=; b=gy5r+7f1qPG9SfL4BMKAxf5lJn8O5lTId6h25Nh0HjALQ+jOWoTVxyoTbI5J9tZ4iH iIRtT/+EvfnoyMTVlc5zFyIZhYI5dRUCUz8kqlh3/09tHGU9nepKMhkLGsFQxaqOZIhv 29bl1pfsCVyo2LlBFjvhUQ/pD7HWzH24hcIcEq2IgDoY0O4x6+BpFJgiWhhHzpnnUJlV W2cb0mrpkifP2DhghtxB1QlcEpGJsyQqKO3p07H/TOiUB2UJNcrBYrMnQ48vNGI/swa0 7Bqduuyf8b0J8O/w5ZsB9UqWU6MQY5X2KbAXX38a9LF7YeqhyO3vS/QZGJ1R5Esl9Dz5 E2HA==; darn=isar-build.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=ZQUcfS2I; spf=pass (google.com: domain of fm-1328757-20250806055452a1af25b2b6b3ac1522-poj4vd@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) smtp.mailfrom=fm-1328757-20250806055452a1af25b2b6b3ac1522-PoJ4VD@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1754459695; x=1755064495; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=RKD6NKL1XLvpeNwmCHO+7JOkE8GQ9E06czj75RhqC7U=; b=moqD9/q0eQq+faGg/ufaN7Aw7Q+6ejahV07aGYK7EMHptBYrLwHDexOoiJhZZE4Rub v6xqX14cUPnXxQOe5X4P0KC7XSxIUPZ8ke1BmFyOE2fWkdvJ+xrsSJEKEW0uq+T/8b2z j/hrsZNHzA5aV23FZHZSRPvxXRloI243Khbyjg47IxR1+XICY6liYeBOZSPnV1W36VpY 0APQw+UaeTW93fvF7lERfF1yLBS4seTDCR6dGr38CAtof4KNhVTstSyvmagvprOm7hxI x4dn9wQC//ZAbFAQZMxgiKgzmOQJd0UUhzR6U5U1Ix1SClwZ/dx/nbo68CaU1aRVJYyH z2LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754459695; x=1755064495; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-beenthere:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RKD6NKL1XLvpeNwmCHO+7JOkE8GQ9E06czj75RhqC7U=; b=lN/LXbTuBi6mgiwKRXYfY0lFHmHrkQGXFGy7SY8bpvc9iZM52paU2bsoulPSpxA97a 6lsSC/ItkUQLZRoWhXKwXeD9Ukn1PIp6tqIvaK+asAtAMKQupaZFXRBvwOGp9yZ7P3fu engLpMYyoG0srWQMQUbdyPKmW9QA4fOSmvVFLCcgM3ByzP4f/HMmlFA0Svk1tqD1piJj Pg9OR6OxzMLSLQAIQEZBQ9zgPfX4QG667MZzWX6VHow5HD5yXvenZ9VJxzPdZ8UT+nM9 /f59iVPVHhrmH3IeLtMc1LfMjbhae5xBoWzYE7GR8jgCG7wja1woPDQ2pgGBgOR2hPRK lKXQ== X-Forwarded-Encrypted: i=2; AJvYcCXUFAbIVk1Fr4rXL2YV8nz9CPUFUnKRRPe8G70JtA/5coju8BV4y6wP7WCliaQirWLGq9fn3B8=@isar-build.org X-Gm-Message-State: AOJu0YzU4OVdUBGHDkZCa7pm2Ol/lFmZJTOCqavCRtxaUzs17q1F8XBS t6YsG8VvF3ZNP/ZpWUQz9fM1i+y4qbdFw2Yq3nMX7B8oI/XVTMxi9QOJ X-Google-Smtp-Source: AGHT+IHobMkWfNVWgVI2MtQC1jK2Z/LBFGa7fnqo8j+Yryjfotcrm+R63Or0sn1LtQS7dM4pdtShgg== X-Received: by 2002:a05:6214:2022:b0:707:3d2e:10b1 with SMTP id 6a1803df08f44-709795f4baamr27075486d6.26.1754459695285; Tue, 05 Aug 2025 22:54:55 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h=AZMbMZf/2dXh3w147EPgxMzEzppeOxezZZJ1486Q08F9m7iZQA== Received: by 2002:a05:6214:b68:b0:6ff:16c9:4229 with SMTP id 6a1803df08f44-70778b1bca6ls93820456d6.1.-pod-prod-05-us; Tue, 05 Aug 2025 22:54:54 -0700 (PDT) X-Received: by 2002:a05:6214:2022:b0:707:6934:cc67 with SMTP id 6a1803df08f44-709795f4bc2mr27505086d6.25.1754459694404; Tue, 05 Aug 2025 22:54:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1754459694; cv=none; d=google.com; s=arc-20240605; b=U0ylPbgh3cVBEWu1TXhVMLxLSpe2Kc109nBJ+w/77FmwcUKl79V7bofvIcmyzufyQj 0VSbnNEIlA+qQdMynAhKmn9IxJdX7volLJnV7TAcL2nrjrnvvyUaHsCnR2Mo4X4U52vZ rNnhjJPuZjeFqx/M41ee/JTBpeI1cv63Lq/U6YK5wa+eKo6ir+9V5SRrdwdtR/6xcWVI C5rcWsvlhbGNOmiwru89h1a1RR7c7JP3z721bl3wvCB42E2MrIPHYX0Opxjy44cU0TEM 09+psUsST4MOffvDRHiO8ptk9osRxLmiFt3Bk0AJ7BMpDEJ22j4Dzu68L2dB+9TjYloR s+Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=feedback-id:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=GB7+7LJ1yfg0BtVjmAF5lJYH8Tb4z5+/91QAQnxC0ic=; fh=pR4tJPO4NbHlIB/rP4bIo54Z1zh5hd/ksAGQ0tcKkYM=; b=jW9LUeCwBY+/YUHnzkUe64fPS+HB6mYq8z/Yyn3wyqfQnWT033JfaJgTGqgMD/o+kS AJYEXsN2iljeRiPaZew0zRLoZesZ6VExIQ4RAwWr77L6ZpsaQgww9ek2ZC0XAHv8eSpW 3FZd9LNAT79/vrw3VQk//1Jn5UHAt34t++XHJxRbVJamrH/iuUzJHBT9GPHP9xEyOeY8 LALe5F2G97BWVzr23hCcmqgf6z2a5DN0N7hLUZAb/QeBruOoff+GcdZMnBqhmkQq7xTo wUvj4BDCR450UOQwzv2FSqTHpICDcYCUljReM4U3oKpR+C9Ycp2YAaKKfzFykf2xiYXQ OyfA==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=ZQUcfS2I; spf=pass (google.com: domain of fm-1328757-20250806055452a1af25b2b6b3ac1522-poj4vd@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) smtp.mailfrom=fm-1328757-20250806055452a1af25b2b6b3ac1522-PoJ4VD@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-64-225.siemens.flowmailer.net (mta-64-225.siemens.flowmailer.net. [185.136.64.225]) by gmr-mx.google.com with ESMTPS id 6a1803df08f44-7077c96e3fdsi4548116d6.8.2025.08.05.22.54.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Aug 2025 22:54:54 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-1328757-20250806055452a1af25b2b6b3ac1522-poj4vd@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) client-ip=185.136.64.225; Received: by mta-64-225.siemens.flowmailer.net with ESMTPSA id 20250806055452a1af25b2b6b3ac1522 for ; Wed, 06 Aug 2025 07:54:53 +0200 X-Patchwork-Original-From: "'Kasturi Shekar' via isar-users" From: "Shekar, Kasturi" To: isar-users@googlegroups.com Cc: Kasturi Shekar Subject: [PATCH v2] fix premature success dialog in installer script Date: Wed, 6 Aug 2025 11:24:38 +0530 Message-Id: <20250806055438.3318548-1-kasturi.shekar@siemens.com> In-Reply-To: References: MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1328757:519-21489:flowmailer X-Original-Sender: kasturi.shekar@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=ZQUcfS2I; spf=pass (google.com: domain of fm-1328757-20250806055452a1af25b2b6b3ac1522-poj4vd@rts-flowmailer.siemens.com designates 185.136.64.225 as permitted sender) smtp.mailfrom=fm-1328757-20250806055452a1af25b2b6b3ac1522-PoJ4VD@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Kasturi Shekar Reply-To: Kasturi Shekar Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= The 'Installation successful' message was displayed before the progress bar completed. Fixed by tracking the dialog --gauge PID and terminating it after bmaptool finishes. This ensures the progress bar runs to 100% before showing the final message. Changes: - Tracked the PID of the dialog --gauge process. - Killed gauge process after bmaptool completed. - Ensured success message is shown only after the progress bar ends. Signed-off-by: Kasturi Shekar --- .../deploy-image/files/usr/bin/deploy-image-wic.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh index aba81c84..fa1061c1 100755 --- a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh +++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh @@ -183,12 +183,16 @@ if version_ge "$bmap_version" "3.6"; then done ) | dialog --gauge "Flashing image, please wait..." 10 70 0 & + gauge_pid=$! fi if ! bmaptool ${quiet_flag} copy ${bmap_options} "$installer_image_uri" "${installer_target_dev}"; then + kill "$gauge_pid" exit 1 fi +kill "$gauge_pid" 2>/dev/null + if ! $installer_unattended; then dialog --title "Reboot" \ --msgbox "Installation was successful. System will be rebooted. Please remove the USB stick." 6 60