From patchwork Tue Oct 21 04:22:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kasturi Shekar X-Patchwork-Id: 4421 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Tue, 21 Oct 2025 06:22:24 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-wm1-f63.google.com (mail-wm1-f63.google.com [209.85.128.63]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 59L4MNVF011403 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 21 Oct 2025 06:22:23 +0200 Received: by mail-wm1-f63.google.com with SMTP id 5b1f17b1804b1-47111dc7bdbsf42183345e9.0 for ; Mon, 20 Oct 2025 21:22:23 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1761020538; cv=pass; d=google.com; s=arc-20240605; b=X20NqnmwejeGBkInfr0iAwRYASvOnmpSzPj8k62uy/mCEucjlScTXvLQajWBf9Ufik 23wxR6w+yUxCcPZ3nmQu/VjMjfGPUgUqEdUr4l7yol8A5cfYfFcn4R133WbcQ8p71lhd aS8nN4aMu9O1i0lKupawGNEEizAt9ca5RJUaTeSYWsipFToCUYISIPcOsg0/Dv/xtMPu ykmcwYFODjO7579lMlCM/JDRqdNeGDYvDFDyPrqCoUScbsCF1oOheafc28yJCiN7CmOD HZV/Ot8zxxjYt5buiXzCCbddGTH64BECcF1v7HuKmFY71pLqeQ/w2Hya/O96ledTSpSS Z1ug== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=XuUtO775onllnX7qCxRr3S8xMYXMW83pl47bXxNDXtI=; fh=ZG3Lb5Wf1GYj5qjHEILT5q444XOXgXj0XHUyDCM8Lag=; b=WvrwcN6W8WkS1yxqnOLuH4aQDK/EHi0Up+ckKVIlpbOEdbUGN3vNx3W19eScICYPCP JmjDsX9Ezl18IpokgMjM1uMK0Kkm+bWThcqiEQqjtQfZ3COEBIUhbp6yfg3H+evgFx1v pvd7TnoNsBF2RpUSH3ApAjKwAuGAS83A6zgUhwsPntUlblorbWYoxAV/XfXJi0WeIuTo BvLZ+s8fJZIJNRm/yjHoReU4F7EdR2h02LWR3XDwP/08aTnEn+nnF3mMKxVgMPVLLH5d ZEyDmeZNvm0IiSwEAkUCISFBPCmC1MtMIYoRqi5Q+0tAilJbY5u3KvdkFdLEanjLGXrc DpFQ==; darn=isar-build.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=KiceIRdR; spf=pass (google.com: domain of fm-1328757-20251021042214df64b5141800020754-zyt6lf@rts-flowmailer.siemens.com designates 185.136.65.227 as permitted sender) smtp.mailfrom=fm-1328757-20251021042214df64b5141800020754-ZYt6lf@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1761020538; x=1761625338; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=XuUtO775onllnX7qCxRr3S8xMYXMW83pl47bXxNDXtI=; b=axNLqeDHINilat+owEX2i3bAF7kzqdDiJQTCk2+XeehwN/y26JxwmLqaex1PRqgmSK SImcnB1qzalbVQqi56DQox+6aK8p3yT6p+pe4uZF4jBkMrg3LNQX9J+136uMQ93Qkqsu TFUHYuDh4yvE1hwnLn51B2AVion6ETm2sAhoz/Hx9MmtcArl0ydHKqhC4Iw8x9cUFdx9 okmVR22tZExA04vu83w+SieGCWJORl6N3S0oiI94+vOF699sj4Ux9d9tF1czTDXLutvg 4s+Dmw95mm0FpE7oDbt3bJTFTR+9nATOia3WH9IKRvYW7zLedZMvmppRICCsKW5Acixc XILw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761020538; x=1761625338; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:x-beenthere :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XuUtO775onllnX7qCxRr3S8xMYXMW83pl47bXxNDXtI=; b=gButDEMKqtOtwY1sf8Qd1qLi63XXjA0WVMwV0UFzScUd7f7UIejuiNro4ObZhKpV6C cdInuL233q5FKHsi2YlrcmgQkbeLr6v1iq2bGqursV4aachywuezA805ba0yGArRvxGm BwdHPJToMkgNQPwbCAKL0NvdOQkVLHYJ47tHV7L79FZSRRZ44bCLZ3Y46aGlkJf1jmjs nWBvZwJTZhColaLsjE1sBPsCusF9mFWljtMBs4K9nu8Bed37FmCSRE9A208FRSpKvQAM 6ydrE3AbEyWbFtjWZk2KX29gEwbN2LJ5C4ASivAE8mFXTrKzefPmrybglNGuNfon8nK+ J6bA== X-Forwarded-Encrypted: i=2; AJvYcCX0SJ1RPCpMGzKQHxrg7dlat0cODp1pGLQaWpbf8RUipsiJb2lWUVi9GN+l/0ctNItDtzEqLxM=@isar-build.org X-Gm-Message-State: AOJu0YxQ97KzAG/GzN81kUA8jUHiy5V5zveUAwXXpUCfP0nd0ZToXB9o DAy2oJ8cAnAO5R+1mYPKx4Y46FgF3ahvLQ0LSioMps/zDT9klXzAKtXz X-Google-Smtp-Source: AGHT+IFgkjBgElwlNBa1uSLERHOPrXJVob9h/N2LMmQZAm9e+vA8le7juxrGpc8yO3ssg7+X4f3UGQ== X-Received: by 2002:a05:600c:458b:b0:46f:b32e:5094 with SMTP id 5b1f17b1804b1-4711791cb4cmr137867445e9.32.1761020537958; Mon, 20 Oct 2025 21:22:17 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h="ARHlJd7s9lJJobGlMerL6NXmEtrzWJp7I4aRebITSavokpcHTQ==" Received: by 2002:a5d:457c:0:b0:3e1:7964:2c28 with SMTP id ffacd0b85a97d-426ff502854ls2396412f8f.1.-pod-prod-01-eu; Mon, 20 Oct 2025 21:22:14 -0700 (PDT) X-Received: by 2002:a05:6000:430d:b0:427:8e5:39df with SMTP id ffacd0b85a97d-42708e53c54mr7753441f8f.21.1761020534654; Mon, 20 Oct 2025 21:22:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1761020534; cv=none; d=google.com; s=arc-20240605; b=iVAexmOMwpGp31wHA6Ze9n8vSmfCe4A9L67166R12imsMedzXtTpgBCqJc2pkp7URw sKJ8ES3JeG/c1afPB9f9riS3J3RjcO+JIhmLGCTEw9PMoG2IwrDuA35gSgDaYgai0YDa SUZJvbjbN8zFl1Gl9DEQ87OiY6B5CgzaOIOXI1FmJUDtUscMySJy5X+NrcwsbbtrLpI1 twBqxtEMga80juJettB/kFWdN767X0ep3qlnSYlvz2JMcjer7cdndMdyjM8Y57f5zhaO bXZ7FbhpvOwLVv4MZnRl2Jm1gS2Kzxpej2iMFkjXDwNVppovOExN92iLMnaNKie2yp+2 QGBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=feedback-id:content-transfer-encoding:mime-version:message-id:date :subject:cc:to:from:dkim-signature; bh=/gKJy7Y2h/nn2s3Dodey2PWQFMwNlXPVNd1B+PrZKQE=; fh=pR4tJPO4NbHlIB/rP4bIo54Z1zh5hd/ksAGQ0tcKkYM=; b=MaFOvbCF4B4gf7QSwR0vhV8gP/G6y4NlyDGppFJw1FnQ8KbOEg5YBlPz7M5b2BZHQI NQu4e2r3oKoy4CW8VnKKRk0b+5dawBVwAUvRUQsIQ068hbu41AKjEaFHe85wL0ntfwWn KL4lYV2gckkv3TK/tHoOJAeZmQhaQlCW7jZe9t3X/pI7kIdv+S3VEaz6tEN/bfEbcaLy UsAWt/rKL9xcM1IWthDNkAQ+4LIc0O5PtaVDitv2BOpdj1guG/vSQr60R6/IP7c40w/w 4mz9fMMnwn1J35aetj61k/Oxdbg5KZe3jAK2GUqu0NQFObTmrN01AW/8G9WPsG7Eacwu uxKA==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=KiceIRdR; spf=pass (google.com: domain of fm-1328757-20251021042214df64b5141800020754-zyt6lf@rts-flowmailer.siemens.com designates 185.136.65.227 as permitted sender) smtp.mailfrom=fm-1328757-20251021042214df64b5141800020754-ZYt6lf@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-65-227.siemens.flowmailer.net (mta-65-227.siemens.flowmailer.net. [185.136.65.227]) by gmr-mx.google.com with ESMTPS id 5b1f17b1804b1-47496b0bfdcsi864275e9.2.2025.10.20.21.22.14 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Oct 2025 21:22:14 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-1328757-20251021042214df64b5141800020754-zyt6lf@rts-flowmailer.siemens.com designates 185.136.65.227 as permitted sender) client-ip=185.136.65.227; Received: by mta-65-227.siemens.flowmailer.net with ESMTPSA id 20251021042214df64b5141800020754 for ; Tue, 21 Oct 2025 06:22:14 +0200 X-Patchwork-Original-From: "'Kasturi Shekar' via isar-users" From: Kasturi Shekar To: isar-users@googlegroups.com Cc: Kasturi Shekar Subject: [PATCH] isar-installer: run installer under agetty and reboot via EXIT trap Date: Tue, 21 Oct 2025 09:52:01 +0530 Message-Id: <20251021042201.1184698-1-kasturi.shekar@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1328757:519-21489:flowmailer X-Original-Sender: kasturi.shekar@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=KiceIRdR; spf=pass (google.com: domain of fm-1328757-20251021042214df64b5141800020754-zyt6lf@rts-flowmailer.siemens.com designates 185.136.65.227 as permitted sender) smtp.mailfrom=fm-1328757-20251021042214df64b5141800020754-ZYt6lf@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Kasturi Shekar Reply-To: Kasturi Shekar Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= the deploy-image service was directly invoked the installer script, which could result in the script running without a properly configured TTY or missing TERM environment variable. This was observed when bypassing agetty during service startup now we launch the installer under agetty to ensure that it runs in a fully initialized terminal environment. Since the service is now managed by agetty, we ensure that the system reboots once the installation completes (successfully or not) by adding a trap handler. Signed-off-by: Kasturi Shekar --- .../deploy-image-service/files/install.override.conf | 2 +- .../deploy-image/files/usr/bin/deploy-image-wic.sh | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/meta-isar/recipes-installer/deploy-image-service/files/install.override.conf b/meta-isar/recipes-installer/deploy-image-service/files/install.override.conf index 357d8662..913efac5 100644 --- a/meta-isar/recipes-installer/deploy-image-service/files/install.override.conf +++ b/meta-isar/recipes-installer/deploy-image-service/files/install.override.conf @@ -1,5 +1,5 @@ [Service] ExecStart= -ExecStart=/bin/sh -c "deploy-image-wic.sh || (echo 'Rebooting in 60 s'; sleep 60); reboot" +ExecStart=-/sbin/agetty -o --noclear -a root -l /usr/bin/deploy-image-wic.sh --keep-baud 115200,38400,9600 %I $TERM StandardInput=tty StandardOutput=tty diff --git a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh index 333762f1..7618a810 100755 --- a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh +++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh @@ -3,6 +3,18 @@ # Copyright (C) Siemens AG, 2024 # # SPDX-License-Identifier: MIT +trap reboot_on_exit EXIT + +reboot_on_exit() { + status=$? + if [ $status -eq 0 ]; then + echo "Installation completed successfully. Rebooting..." + else + echo "Installation failed. Rebooting in 60 seconds..." + sleep 60 + fi + exec reboot +} installdata=${INSTALL_DATA:-/install}