From patchwork Mon Apr 27 10:04:24 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "srinuvasan.a" X-Patchwork-Id: 5053 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Mon, 27 Apr 2026 12:04:06 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-yx1-f60.google.com (mail-yx1-f60.google.com [74.125.224.60]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 63RA449m001735 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 27 Apr 2026 12:04:05 +0200 Received: by mail-yx1-f60.google.com with SMTP id 956f58d0204a3-65441e6e331sf10723653d50.3 for ; Mon, 27 Apr 2026 03:04:05 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1777284239; cv=pass; d=google.com; s=arc-20240605; b=L+HC+K83jYF+FTpm4FVaDPDS5vQxF1wwWw2mZqSZRB/6afyAGdRKjbQwaze38DYh16 fQZwaaOWzLzIo1ijU+gP+s4YXOPxEoWbbLp8i/NdOCiHmENFoLD3BHuz3qCOeZqVLjHd CvhQbKH47HfoFDEHJ64XpyB6Js3cNqoamL2r2PytkGRJb3kujV3fvLyZt6pdBe7+r8/7 pD719GNPRyDYgjgdEIsB9ugW8L8Kw03qf2k4/ImE0K92T3rsG2btKGG682oHDCA4O4BH Ei2BZbQjNxqNfObEMb1r8YncJBHpx/UlknuyNvA5f7FI5NBzBX6tv7bOdnXdqq00kJff EdRA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=LFFpXEq4rwC+SSbHRKnXmInyEU1yBP+y4EpolcsI9PE=; fh=tNstw9yRw7fldVv0ci8q1vTmY7mAyny7+1iLvphhBUQ=; b=cx/Uk4ZOsEj6sC02SBnT6prh7Y09tV32f/zWBU/lE6VXRbIf714BEQVdqz8iaYzxfq Xy5fvutdli8D1enObUsTWSO1BgUX1oBrTVmLtbosICshm/j4hGj1eEoA7qzvxU0KavA/ uHvoUPwIHJLyGi6qedCaeZDp0gPt6gupMtpQxigSxc4m2vaezdDniABlbD4/jAnkIWYV VXt+bpriWFBGpSXdUuB496/LEqKdCakZj+XOE+kW6vtjeApmonSCvMMwzFOEZ7qsS8Ai rJwRK68vcyaV+4H8voY+OPsWghkD00Bw71eut1hPwplF0KvDv2xAQcFd4MqjcRLAPDxg BdLw==; darn=isar-build.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=LWCEFF+u; spf=pass (google.com: domain of fm-1324425-2026042710035414c004013f00020765-8rltcm@rts-flowmailer.siemens.com designates 185.136.64.227 as permitted sender) smtp.mailfrom=fm-1324425-2026042710035414c004013f00020765-8RLtcm@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20251104; t=1777284239; x=1777889039; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=LFFpXEq4rwC+SSbHRKnXmInyEU1yBP+y4EpolcsI9PE=; b=frVRsKgLBjaT06pNR4YGbsif31v3v8oqxWOV2cFPMvKY6Ysu13jwiQKJ+tWxkHGt3T 3Q9d8Tb9nqjqtaRlWVOq8ISlYUaRsR5J4mpbTgqE0v+QPhcPTbINeVQhJQlLEkoNbuKB 1r0D/XkquHyB9/iF912Randt9H4nuGPgoc3pOJI0jDZTceN8CSjMD1AN5s5uZHztnOB8 2gMbsn+9TJweuTL6ZSNXGtnqa8Bb+melx89WTJ9to9R+5ffR0oeKiyidfm+VkVxIH+wU JCr/bBTo1YULPu/6VGit0v5Tdv9mvgXuypIUTLSuFuWPHzusC5RSM8OB7Og+86UKJnZ4 rQPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777284239; x=1777889039; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:message-id:date:subject:cc:to:from:x-beenthere :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LFFpXEq4rwC+SSbHRKnXmInyEU1yBP+y4EpolcsI9PE=; b=lvFNYW6L+bGDJ7vchJSnHtGpxMQqNI2W0v0LHc+S3Bz5SQKuqYytxWk8opC3C76uIa 3kRyQnARRifl/PPD4jRWEdq8cqtTeqtE92ppELSjUnv/cFR9s5agm3isolaR1YCl8n57 8fdlialbW1NmNTXlVyQFenoVsFY2jVuXnNKF9Z3HFhQg14iOGsSo0xlmPpK9LFJYJyeb r+3JKmsSw8Sj9afX7R5kDG0/P6/WCYDuJ3Jry3hbjRMdNspHDt0ETB2gk9BGxE3Uo189 qntHB1ofR4doI9mzp3KT20hArjbSy7e03dWmF5CfnJODZnYyXWlovsPjx1ZW+nAzgdRy IgzQ== X-Forwarded-Encrypted: i=2; AFNElJ9nvAeAXaTknuprkuUeH5njS3lcaamzFYzas2TLS1x74KvR3unzmaB+MLve5X2Iz+0z2dnTlE0=@isar-build.org X-Gm-Message-State: AOJu0Yxbkihuyjb9/qjN6ylm62ToqmVSEVlzATQW7oECJVKXsSP3SlNU cMrFqNjgbOL7zs4JMKRh0PelaZ1eFaBc360Oix5hNYQwTr8CgL8fiu73 X-Received: by 2002:a05:690e:d50:b0:654:1a51:81fb with SMTP id 956f58d0204a3-6541a51a46fmr26700168d50.54.1777284238979; Mon, 27 Apr 2026 03:03:58 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h="AUV6zMOTDfn5rrDX4Bh4c0ExzNjmi9JUqfb4d99ycTjKTCaySg==" Received: by 2002:a53:cd52:0:b0:651:bf16:ab7 with SMTP id 956f58d0204a3-652f7be11f4ls8299711d50.2.-pod-prod-01-us; Mon, 27 Apr 2026 03:03:58 -0700 (PDT) X-Received: by 2002:a05:690c:39c:b0:79a:40fb:9346 with SMTP id 00721157ae682-7b9ecece3f1mr425549417b3.20.1777284237758; Mon, 27 Apr 2026 03:03:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1777284237; cv=none; d=google.com; s=arc-20240605; b=UuQtELg8qLCljkISXuXLCjOab3BsHe9wTpXiHYyVaQeg2yV35nFXK8KklNOxz6r9MG 2+coV26TUKNTac0X8nEsL0/V4d3jY3QYrIYir2+fSdlx5MLBkBhldRyPhF5k1p+gSmk5 6ZEK1lT8l7r8UZ2NGu3+KDN0lkCgpVDjNLkNU9RbHBrobD/QytpXngmXMW7/davTDgWo KyBvy9uomAgWwxBP0xbmWOC4pWMcnP6OAZoOZxefwKGlTnUzFA7tK7bAYMoipnD8lF9X k/4WtZ4tpx6/0Vh7hS3DQD8pUzjI/Z6jJ0kK26P9QIvq5hy/eHgIOrBJCv+TQWAOApmM etBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=feedback-id:content-transfer-encoding:mime-version:message-id:date :subject:cc:to:from:dkim-signature; bh=l9pnWpb416GTmWGFaxysAVyzq0fe8qNKuAe+tTACj+o=; fh=0pGeKO0i6YbKAhHk8EuRJq3X9Y5aSBVm9NvDfgU6AEw=; b=MkANdaKzjXrOfqJpSBQcmG7dOm8ecscO480Jp0FBErfEC1aeG6JP3uu1Ymc1FLfjvX +Ojg9rFu27UJWFikeO0h2chMh7c/hDLkfV5cSFPGu6B3j2A2QjcL/Cg2ioHBBjvu8vvj /fGP2yk77rP0mpJtQ5H5hGPlD9deb+kuGeKC9b28qAtLXzXG4bsLt1yukE6aJ3Ddlyai 0MXQoejP+4nO4rShrEcJkY/oNhiGn4+OMmxL9I+70W5sCyPsdYJR5KWeZt9SqHQAP4jk 5mfeVYVKh2AGVZHg8/pLYfeOMCs2BDOBT1XbAyebEooeQgIptf+Iu0iKl4p6fafDuf9e w3uA==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=LWCEFF+u; spf=pass (google.com: domain of fm-1324425-2026042710035414c004013f00020765-8rltcm@rts-flowmailer.siemens.com designates 185.136.64.227 as permitted sender) smtp.mailfrom=fm-1324425-2026042710035414c004013f00020765-8RLtcm@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-64-227.siemens.flowmailer.net (mta-64-227.siemens.flowmailer.net. [185.136.64.227]) by gmr-mx.google.com with ESMTPS id 00721157ae682-7b9ee936a27si10700567b3.3.2026.04.27.03.03.57 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Apr 2026 03:03:57 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-1324425-2026042710035414c004013f00020765-8rltcm@rts-flowmailer.siemens.com designates 185.136.64.227 as permitted sender) client-ip=185.136.64.227; Received: by mta-64-227.siemens.flowmailer.net with ESMTPSA id 2026042710035414c004013f00020765 for ; Mon, 27 Apr 2026 12:03:54 +0200 X-Patchwork-Original-From: "srinuvasan.a via isar-users" From: "srinuvasan.a" To: isar-users@googlegroups.com Cc: Srinuvasan A , Cedric Hombourger Subject: [PATCH] repository: default Priority to optional when field is absent Date: Mon, 27 Apr 2026 15:34:24 +0530 Message-Id: <20260427100424.558898-1-srinuvasan.a@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1324425:519-21489:flowmailer X-Original-Sender: srinuvasan.a@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=LWCEFF+u; spf=pass (google.com: domain of fm-1324425-2026042710035414c004013f00020765-8rltcm@rts-flowmailer.siemens.com designates 185.136.64.227 as permitted sender) smtp.mailfrom=fm-1324425-2026042710035414c004013f00020765-8RLtcm@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: srinuvasan.a@siemens.com Reply-To: srinuvasan.a@siemens.com Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: Srinuvasan A Some upstream packages omit the Priority field from their binary .deb metadata. reprepro rejects such packages with "No priority given", aborting repository construction. This was observed with a base-apt build that include upstream packages such as gir1.2-javascriptcoregtk-4.1. Both base-apt and isar-apt use the repository class. Fix repo_add_packages() to detect a missing Priority field and fall back to "optional", matching the Debian policy default. Add a test recipe (test-nopriority) that explicitly strips the Priority field before build, and a citest.py test case that exercises the isar-apt repository path with this recipe, covering the same failure mode as the base-apt case. Signed-off-by: Srinuvasan A Signed-off-by: Cedric Hombourger --- .../test-nopriority/test-nopriority.bb | 10 ++++++++++ meta/classes-recipe/repository.bbclass | 15 ++++++++++++--- testsuite/citest.py | 10 ++++++++++ 3 files changed, 32 insertions(+), 3 deletions(-) create mode 100644 meta-test/recipes-app/test-nopriority/test-nopriority.bb diff --git a/meta-test/recipes-app/test-nopriority/test-nopriority.bb b/meta-test/recipes-app/test-nopriority/test-nopriority.bb new file mode 100644 index 00000000..dc06c112 --- /dev/null +++ b/meta-test/recipes-app/test-nopriority/test-nopriority.bb @@ -0,0 +1,10 @@ +# Test that a .deb without a Priority field can be added to the repository. +# The debianize class sets Priority in the Source stanza of debian/control; +# we strip it here so the resulting .deb has no Priority metadata, exercising +# the prio_opt fallback in repository.bbclass. + +inherit dpkg-raw + +do_prepare_build:append() { + sed -i '/^Priority:/d' ${S}/debian/control +} diff --git a/meta/classes-recipe/repository.bbclass b/meta/classes-recipe/repository.bbclass index a5dd8bbc..ba2803ad 100644 --- a/meta/classes-recipe/repository.bbclass +++ b/meta/classes-recipe/repository.bbclass @@ -61,14 +61,23 @@ repo_add_packages() { local dir="$1" local dbdir="$2" local codename="$3" + local package + local priority + local prio_opt shift; shift; shift if [ -n "${GNUPGHOME}" ]; then export GNUPGHOME="${GNUPGHOME}" fi - reprepro -b "${dir}" --dbdir "${dbdir}" -C main \ - includedeb "${codename}" \ - "$@" + for package in "$@"; do + prio_opt="" + priority=$(dpkg-deb -f "${package}" Priority 2>/dev/null || true) + if [ -z "${priority}" ]; then + prio_opt="-P optional" + fi + reprepro -b "${dir}" --dbdir "${dbdir}" -C main ${prio_opt} \ + includedeb "${codename}" "${package}" + done } repo_del_srcpackage() { diff --git a/testsuite/citest.py b/testsuite/citest.py index fc6ec24c..9fdb9fd7 100755 --- a/testsuite/citest.py +++ b/testsuite/citest.py @@ -84,6 +84,16 @@ class DevTest(CIBaseTest): self.init() self.perform_build_test(targets) + def test_dev_nopriority(self): + """Test that packages without a Priority field can be added to the repo.""" + targets = [ + 'mc:qemuamd64-bookworm:isar-image-ci', + ] + + self.init() + self.perform_build_test(targets, + image_install='test-nopriority') + def test_dev_rebuild(self): self.init() layerdir_core = CIUtils.getVars('LAYERDIR_core')