From patchwork Fri May 15 10:02:36 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "srinuvasan.a" X-Patchwork-Id: 5080 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Fri, 15 May 2026 12:01:55 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-qt1-f190.google.com (mail-qt1-f190.google.com [209.85.160.190]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 64FA1sm2031270 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 15 May 2026 12:01:54 +0200 Received: by mail-qt1-f190.google.com with SMTP id d75a77b69052e-514b673c8f1sf111731571cf.3 for ; Fri, 15 May 2026 03:01:54 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1778839308; cv=pass; d=google.com; s=arc-20240605; b=Y8jt2x69WfkkAWDvv9k2HfkSyj6aDd28TH6Q1KqzZpquJLKfO7DIU/BhEnqtZEdVKH 1VNAYgsM53me8dA/7yOix0LEp/FkxzELnDGSnNVd+s1hjHc3Xl/DOE42vZWBhfGkEf5h cHNAMGsV7sQn6g9LTFAbZ4rID76pw9suf7iFxJVtUjOP26jSKiOY7L/HQcwdJNHfKp9f 9TAPmOIMMe/AWl0DRbPVvFob7cYtWB3QCMtwg4jZ6KxBT+3P6TrNjKYygqJCaBCZJ0zd +9KVO3N+QPBd1lSG/UUHMhR5N6aUjvSMh8FcjJvlxeBMuDjaBwCA6OTcD9fo1E99sgYm nt7Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=FYUdNTDlTCSY0gKUGo9E/Zq1d8sNK2y8FzsZTnE7ZoE=; fh=GAk4GxJt/3AeQlx8sFUNzoLHbxB4b6xMDbUWUkKQ5k0=; b=CbDhY5gPTuKTDI1uh5OmvV6yInoKBpde/R8bHCtWBPdTVvDsgeGKya/Xtjj+YjWU0i NXOT0MEJlUg8fpwBQNUx7g4PYlkHvL7tS5QFwxY6I6SrHhy5AhS+phGMbJq0mfXCGqF2 i4OfRAB2p1eReTd1jJmSkvdVEdnnqotRHAot9pkOt+CF+g8JPO0GsKJMxG9JjDe39bNS A026mUPQG7EB0zS7XG0SxuyFhHdVjqd529yX0thi0O1JCRwh0pEGymcvyrtwoBv69Drd EEsTAGNxCNDNGgCItrx7bVWOGCWcKY6enquozQXMPDVzEnmT9vUtB3ASpLp1ziKT5qTf ySDA==; darn=isar-build.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=OX+3BnHl; spf=pass (google.com: domain of fm-1324425-202605151001444ed9d1f296000207fd-jvjpja@rts-flowmailer.siemens.com designates 185.136.64.228 as permitted sender) smtp.mailfrom=fm-1324425-202605151001444ed9d1f296000207fd-jVJPja@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20251104; t=1778839308; x=1779444108; darn=isar-build.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=FYUdNTDlTCSY0gKUGo9E/Zq1d8sNK2y8FzsZTnE7ZoE=; b=r0x/2UtPpkAvh1Eh6DREieiXsrdz4EHeEbWe1U51wShdsiY33D1dRAbMk64i42a1UC IHNxbX8HNJw0GPBQMVu/nRiLgvFp9rBBiRT8fY12aGZf8mnER1d+0XP5O7ENPq1GhbOZ LSlSsT9lsFDGzNt72zfzOK8AD3MUMIx8oeESvDrklUbp5O6yvmGcQyO79xMP18I2WGSY PoNafjLqiob1DZ7cmj4uBVL6RePqgXlljHB5piumr/RL8LN8cHNo4ZDG4lhvKDyef7dE /uVHX1q2ZKRl5zFcyqvBYUZsMZ3mnOoksvJDfPXag35EIlh4LNhmrBqhI9VlGto443WI YEBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778839308; x=1779444108; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-beenthere:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FYUdNTDlTCSY0gKUGo9E/Zq1d8sNK2y8FzsZTnE7ZoE=; b=F17bSpdEbhP0srf0RZhVQgcpnK31HcCwL32WupOltNJUm/jQzBrHkbNXo4O7HdtCcg nLwFefPgYzD4KLNypdGGl0KeRKM8lmBBDYOmrTsa4JRg72E2nSDZv2g3Gm9OSRibamNm FerOJy6rsqf6nh0svaxFCz7pH8rFeW0Ty72XGLKU0hkDqKbTWYrCVJYDKKKA2l6EV42K 9k1qmCd1qfkxypC/5zuNlJFjzBQ0kVL5h1RwkEFHRwSWuu+ykNL0bFR1fXmtvdrvR3OZ UQcRfWcj9QJr4V1plzyId5KjjAqxRVDLBqHAnoMauG+Yufljq5uSoU428H2WXLsa+Yhp LByw== X-Forwarded-Encrypted: i=2; AFNElJ8P4TdIbuUFggauam5s+nanMMEsOJqfsJAzNfgUwoVqecREaHyPIRKpHGW8vfLC1o6lW1sihPQ=@isar-build.org X-Gm-Message-State: AOJu0YxYp/+wTnq/fd/iIgRU+uWXQtbWuYkIIPOjX7WVhHApBGxTdAki PhGaUG4MuAizgfyZdep22p3EzN5uYx/nYgEpSVovISQpgz7yUeNqs7Zr X-Received: by 2002:ac8:7f8e:0:b0:50f:b9e7:3031 with SMTP id d75a77b69052e-51659fde5fcmr44838601cf.7.1778839308383; Fri, 15 May 2026 03:01:48 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h="AUV6zMOnbXTdoy96kHMAlnFmaXcpC1GBHr2YH955LPq6+qYOWg==" Received: by 2002:ac8:5882:0:b0:510:1492:c3b1 with SMTP id d75a77b69052e-516455bff00ls39933131cf.1.-pod-prod-04-us; Fri, 15 May 2026 03:01:47 -0700 (PDT) X-Received: by 2002:a05:622a:5513:b0:50d:6557:5c8f with SMTP id d75a77b69052e-5165a256f60mr43397341cf.58.1778839307175; Fri, 15 May 2026 03:01:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1778839307; cv=none; d=google.com; s=arc-20240605; b=O8tfUSwK/yXBVJt5jFIp8h8udKV5X4CG57+x4nyWsEJ/TOQo0nwpuRJ2E8epkcY5mK on+8OIGU4/XQD/Ptoo7oK+nGcUxQammQe9H6YYDs3yaCqK6CjvNk39GUDU3h+t3EtYSz YYMMlJWGp08leqdqeMH4qUaUyL40m4VVgou4+nNwTRLEZC4HaLNz6jmTc9uZFQXYLNT2 qy3z1/g5ScPx3YhfDX+R2pjkNqiF7ufJVskB4wFfdUFVNLbVJUTCBEvbKNz/BrDL8mOf sfri51Aa+ZnQr2E3WDJiiPsWyh4ufWXyja9wUpoCOe1ktUAMAAknTesCwofv5tqeMMcD 3dFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=feedback-id:content-transfer-encoding:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=tHFzIEs1zIOgvEEeMouQ7GPVzHtbAtS/BnPYKnRi1Ho=; fh=FwyE32lwkwF+b7/zzV6RvJyWRyZqxmj9mv3Mjmy9dXU=; b=SOc7U31fWnlJsLwwBkohnr13pligWQdJ7IcnH5Di2R+xhco8tJJRztRxrWBmqFuj6f bPUAppUUY8SlT75GrPcWzMVuEy9SKfh8X/1yJYshtV8dkHDm4flBxUx5gmU74Fv4SDqd NKCZAPoUb9h9Sg/X4GFcF8bYJDyNzWmf+QHQISdCik3s3plYpcq8KZ0emlimvs2POW+b MAMr0T8b4UpxKphkxg0tR1wXTjxrHA/JJaw8KiJW3Ro1+la8+veTl+BIR/GXNbTyKdt9 c/rT9Z7w9NyqYRWb2q+eqYceLvPH/jBpyZC6jf4a1SXYYyjcKexNxw0Qqc2UR4vKOtwZ 94YA==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=OX+3BnHl; spf=pass (google.com: domain of fm-1324425-202605151001444ed9d1f296000207fd-jvjpja@rts-flowmailer.siemens.com designates 185.136.64.228 as permitted sender) smtp.mailfrom=fm-1324425-202605151001444ed9d1f296000207fd-jVJPja@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-64-228.siemens.flowmailer.net (mta-64-228.siemens.flowmailer.net. [185.136.64.228]) by gmr-mx.google.com with ESMTPS id d75a77b69052e-51645562998si1241601cf.0.2026.05.15.03.01.46 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 May 2026 03:01:47 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-1324425-202605151001444ed9d1f296000207fd-jvjpja@rts-flowmailer.siemens.com designates 185.136.64.228 as permitted sender) client-ip=185.136.64.228; Received: by mta-64-228.siemens.flowmailer.net with ESMTPSA id 202605151001444ed9d1f296000207fd for ; Fri, 15 May 2026 12:01:45 +0200 X-Patchwork-Original-From: "srinuvasan.a via isar-users" From: "srinuvasan.a" To: isar-users@googlegroups.com Cc: amikan@ilbers.de, Srinuvasan A , Cedric Hombourger Subject: [PATCH v2] repository: default Priority to optional when field is absent Date: Fri, 15 May 2026 15:32:36 +0530 Message-Id: <20260515100236.671593-1-srinuvasan.a@siemens.com> In-Reply-To: <2b18650a-a913-4dfb-a7ad-aebc2d45bb7b@ilbers.de> References: <2b18650a-a913-4dfb-a7ad-aebc2d45bb7b@ilbers.de> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1324425:519-21489:flowmailer X-Original-Sender: srinuvasan.a@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=OX+3BnHl; spf=pass (google.com: domain of fm-1324425-202605151001444ed9d1f296000207fd-jvjpja@rts-flowmailer.siemens.com designates 185.136.64.228 as permitted sender) smtp.mailfrom=fm-1324425-202605151001444ed9d1f296000207fd-jVJPja@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: srinuvasan.a@siemens.com Reply-To: srinuvasan.a@siemens.com Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: Srinuvasan A Some upstream packages omit the Priority field from their binary .deb metadata. reprepro rejects such packages with "No priority given", aborting repository construction. This was observed with a base-apt build that include upstream packages such as gir1.2-javascriptcoregtk-4.1. Both base-apt and isar-apt use the repository class. Fix repo_add_packages() to detect a missing Priority field and fall back to "optional", matching the Debian policy default. Add a test recipe (test-nopriority) that explicitly strips the Priority field before build, and a citest.py test case that exercises the isar-apt repository path with this recipe, covering the same failure mode as the base-apt case. Signed-off-by: Srinuvasan A Signed-off-by: Cedric Hombourger --- .../test-nopriority/test-nopriority.bb | 10 ++++++++++ meta/classes-recipe/repository.bbclass | 15 ++++++++++++--- testsuite/citest.py | 17 +++++++++++++++++ 3 files changed, 39 insertions(+), 3 deletions(-) create mode 100644 meta-test/recipes-app/test-nopriority/test-nopriority.bb mode change 100755 => 100644 testsuite/citest.py diff --git a/meta-test/recipes-app/test-nopriority/test-nopriority.bb b/meta-test/recipes-app/test-nopriority/test-nopriority.bb new file mode 100644 index 00000000..dc06c112 --- /dev/null +++ b/meta-test/recipes-app/test-nopriority/test-nopriority.bb @@ -0,0 +1,10 @@ +# Test that a .deb without a Priority field can be added to the repository. +# The debianize class sets Priority in the Source stanza of debian/control; +# we strip it here so the resulting .deb has no Priority metadata, exercising +# the prio_opt fallback in repository.bbclass. + +inherit dpkg-raw + +do_prepare_build:append() { + sed -i '/^Priority:/d' ${S}/debian/control +} diff --git a/meta/classes-recipe/repository.bbclass b/meta/classes-recipe/repository.bbclass index a5dd8bbc..ba2803ad 100644 --- a/meta/classes-recipe/repository.bbclass +++ b/meta/classes-recipe/repository.bbclass @@ -61,14 +61,23 @@ repo_add_packages() { local dir="$1" local dbdir="$2" local codename="$3" + local package + local priority + local prio_opt shift; shift; shift if [ -n "${GNUPGHOME}" ]; then export GNUPGHOME="${GNUPGHOME}" fi - reprepro -b "${dir}" --dbdir "${dbdir}" -C main \ - includedeb "${codename}" \ - "$@" + for package in "$@"; do + prio_opt="" + priority=$(dpkg-deb -f "${package}" Priority 2>/dev/null || true) + if [ -z "${priority}" ]; then + prio_opt="-P optional" + fi + reprepro -b "${dir}" --dbdir "${dbdir}" -C main ${prio_opt} \ + includedeb "${codename}" "${package}" + done } repo_del_srcpackage() { diff --git a/testsuite/citest.py b/testsuite/citest.py old mode 100755 new mode 100644 index fc6ec24c..7b734be5 --- a/testsuite/citest.py +++ b/testsuite/citest.py @@ -131,6 +131,23 @@ class CompatTest(CIBaseTest): self.perform_build_test(targets, compat_arch=True) +class RepositoryTest(CIBaseTest): + """ + Test repository functionality. + :avocado: tags=repository,fast + """ + + def test_repository_nopriority(self): + """Test that packages without a Priority field can be added to the repo.""" + targets = [ + 'mc:qemuamd64-bookworm:isar-image-ci', + ] + + self.init() + self.perform_build_test(targets, + image_install='test-nopriority') + + class SbuildFlavor(CIBaseTest): """ Test package build with a custom sbuild chroot.