From patchwork Thu Oct 7 06:07:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: venkata.pyla@toshiba-tsip.com X-Patchwork-Id: 908 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3) with LMTPA; Thu, 07 Oct 2021 17:07:23 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-pj1-f63.google.com (mail-pj1-f63.google.com [209.85.216.63]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPS id 197F7JwC015766 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 7 Oct 2021 17:07:20 +0200 Received: by mail-pj1-f63.google.com with SMTP id z5-20020a17090acb0500b001a04086c030sf1294228pjt.6 for ; Thu, 07 Oct 2021 08:07:20 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1633619234; cv=pass; d=google.com; s=arc-20160816; b=e56IJcYdkE59tEsqGOkUqCp/wDnPuDIPzhpyXrcrztVM0xf1Np/zek2nprdLi0sdEa +c0hIps9ICDQteNqU/kPvPTYmmRpdbfoL+JuZCI/5n22DhaT/kDZOB2h5OK2+F0Kdz3P /5xtNkbbAh3Ll+j1pjeq9R53seKkDaWBRGIgdklw3F6InNIlu6SXlF0Y9h3jvfSIEWsl 4BEkSMMW+U7AKHJ9G+kiq00mXwthPLtU4gMoGrtaSzQ/yby1T9Ui8btgBa3FYwWUzdDs fZT0opvS8vduwq1d5XcUe2RRy3fbFF6bcegBRuIP8HNJN7P57K9vE+YTHC7RmZWINjSn FDkA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:message-id:date :subject:cc:to:from:sender:dkim-signature; bh=vyLgPEz4HCrUSOrZYiJZdRmjc9ZqJQLTP3LQCOdMcgQ=; b=k/PKiow72RcJc8TzMAhr94XC4uJ/HJxfZvD9EIB+Px1+Mx03UQsR/x589r2PuWc/gK SZ5yu4QgZjbBpSt7rVO/uPGOaDshkz4YyM5SogYkoWBw1MMPzsnxqghiZ7N4Y0FZZzrJ ccOGHiNAOTwsdttCfY8DS9XJYhz4clR3GFYDYzvZPFByux4lXo/jJ0uM/Msl8wCOeEao qEP1wlF0Ppl8WAQdrbkYxR6Dmjw7KTsEnuuxGBbyLJ1c7uK7L0wgSepFfc6mRTCVybGf YnkTYYAnQmcHuNtq5M+Hgx8sTVmdHI+qinHq360o3z+WgKRzuT4PMJVHguwcxk73R+6w 2SeA== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of venkata.pyla@toshiba-tsip.com designates 210.130.202.158 as permitted sender) smtp.mailfrom=venkata.pyla@toshiba-tsip.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:mime-version :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=vyLgPEz4HCrUSOrZYiJZdRmjc9ZqJQLTP3LQCOdMcgQ=; b=Q7tLOgSWsfjV93qcM7H3CFDahdeizUkSe8ghwYdC865aBUg0x+hCDf8bKDJOKhJEwQ L8UOv4yxMQdIrLsBZ0M3uzgTm45QUIPEQbj5YGv8YZozsoCAyh1+AVdoXF6XjtBgNQOX OnJbGV9B2rD3PlBcmEIyH5x5c2YieBY1ILwZFTkGWh3EOKM5vWK/hqE8YI+G077aHiQ7 o6nouJ1p6qrt9r3LjNVPD+9BzxIo8Pv+cf2G9D7cKZ6bvOBqbupyf2U9O9VF/RQ9fIi1 tty/y4rbpCdzK7QThWP3tWH0xUvB0PE9i7h+zZYgnSzUeAcnoL/qDcqcfrSlsahJeEP4 HjLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=sender:x-gm-message-state:from:to:cc:subject:date:message-id :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:x-spam-checked-in-group:list-post :list-help:list-archive:list-subscribe:list-unsubscribe; bh=vyLgPEz4HCrUSOrZYiJZdRmjc9ZqJQLTP3LQCOdMcgQ=; b=ZN6XgdyP5ZXAbONVxqI0GmYDW7IYzHFEbQvgHCkNE9ay1tuUKMyDya4aovUbdoqB6S RztZ24pH/sUwlxVZ2m+UFjywjjsuu8ZMyRp2nv4u7m2smd1DmPV9Ni1zeu4ht+SOjMEU zKn3ILOaedprnMAkozdrXCBvwJrIH2SgM+rwbPavgioZnvtkseDqV6kpBKD6Gv2PL0JP MwFBY90fwzeru8qwaGiJCmsE2oOvsMmSAR/tYnY61WqZ095yFy/GX/LBFRsaXie2ad+b mbHmJQG5Na1CDh9dirl3ucHB0sgW3TdFSLcB7alnXDLK8TETvm0uLYQ0Nz9TutB1kDOH D9bA== Sender: isar-users@googlegroups.com X-Gm-Message-State: AOAM530YGEdCcbCaXl29plLoBlBF54k43hRqD9NBZaDM6x+zIOwiB0XT 8qArhNYK2ARpM5zw048fHoA= X-Google-Smtp-Source: ABdhPJzSLZDdpAcuBrW5CU9OJ7NYsPrc9TaM+gFYabjSiBXZb7yFMgyl7sRC1Ri0/if0fm5Azi5Jkw== X-Received: by 2002:a17:90b:4c4a:: with SMTP id np10mr5532241pjb.233.1633619233839; Thu, 07 Oct 2021 08:07:13 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:903:185:: with SMTP id z5ls70005plg.9.gmail; Thu, 07 Oct 2021 08:07:13 -0700 (PDT) X-Received: by 2002:a17:90a:1984:: with SMTP id 4mr5455746pji.87.1633619233320; Thu, 07 Oct 2021 08:07:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633619233; cv=none; d=google.com; s=arc-20160816; b=0EhMboYTVyDX1OpvAg79eWYVsv9WHgNkAbWU1SUy5VB30qKlMcxEV9Sh1WKRG7nrnO wZe0Kf8mhZRbgJCyaUOInb6GpGeXN8l2T5ePwroPCgkvvdJ1yQQI30FXy06dHTjCfZak grOWGFBTg/mTFUZfzgVAmeo3waiyx2+9oHyP1TFQ+cuOSAsMC041Rd6UMbH3t4GESyiW cDdog9pmhQRMO0AzHdSM1fOmOOpjvh26gFHblvzmQJB4W0IML3LlqC651iQPCAfJSm/A k0BOCorQ1PYH74+gD+J4NY4Ip23rXJvZllzzPj61jcQPTnmRohVbR/o+OxCn2VNwL9Yk lD2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=LXTbFdwN0/aOTGwi/VxZoryQVhk7D46RmhHilt4UmQ4=; b=ITI94uXAGNrYIIp2c14CccNxNEsDq6WXC9mA8EqZuzdB0XEwjLw/HFqh8Igv1Fhzgw wwFzUETATu9YcaixZ517LkCmNd+gVNRH7NcbmcThqMOihG1/UQm2geaXeqp8/8l8jQ/z fqgSEc6yIW3VPK1C4SJzEQREDwJ1vl8LRGGr0bVDBxPLdwFjhzzldo2aO7BuZw6+C7n0 uE9vVPAAu2YbUKu+a7Q8jb/gW0Jp/ig6JzML6Gs02AyAVZuQ/NlYUw1h1ZJ+mDWP4M53 Muv3TfBWUBXppIQUiVK47fiP9e22JDnYFTs3aIwPY7RS4FHwoZTxO6dwPR8QeJPbWRV2 HR/A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of venkata.pyla@toshiba-tsip.com designates 210.130.202.158 as permitted sender) smtp.mailfrom=venkata.pyla@toshiba-tsip.com Received: from mo-csw.securemx.jp (mo-csw1116.securemx.jp. [210.130.202.158]) by gmr-mx.google.com with ESMTPS id w16si1810663pll.0.2021.10.07.08.07.12 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Oct 2021 08:07:13 -0700 (PDT) Received-SPF: pass (google.com: domain of venkata.pyla@toshiba-tsip.com designates 210.130.202.158 as permitted sender) client-ip=210.130.202.158; Received: by mo-csw.securemx.jp (mx-mo-csw1116) id 197F7BkD027542; Fri, 8 Oct 2021 00:07:11 +0900 X-Iguazu-Qid: 2wGr0wVJqdrEoaYs0u X-Iguazu-QSIG: v=2; s=0; t=1633619231; q=2wGr0wVJqdrEoaYs0u; m=/b1OlT3kgb3zyLeA9Heege/BhWaiGBaIWSDadeG5aj0= Received: from imx12-a.toshiba.co.jp (imx12-a.toshiba.co.jp [61.202.160.135]) by relay.securemx.jp (mx-mr1110) id 197F7ARU009108 (version=TLSv1.2 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 8 Oct 2021 00:07:10 +0900 Received: from enc02.toshiba.co.jp (enc02.toshiba.co.jp [61.202.160.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by imx12-a.toshiba.co.jp (Postfix) with ESMTPS id 852AF100113 for ; Fri, 8 Oct 2021 00:07:10 +0900 (JST) Received: from hop101.toshiba.co.jp ([133.199.85.107]) by enc02.toshiba.co.jp with ESMTP id 197F7AV1017750 for ; Fri, 8 Oct 2021 00:07:10 +0900 From: venkata.pyla@toshiba-tsip.com To: isar-users@googlegroups.com Cc: venkata pyla , henning.schild@siemens.com, jan.kiszka@siemens.com, dinesh.kumar@toshiba-tsip.com, daniel.sangorrin@toshiba.co.jp Subject: [PATCH v3] rootfs: clean package log files that are not owned by packages Date: Thu, 7 Oct 2021 20:37:34 +0530 X-TSB-HOP: ON Message-Id: <20211007150734.8380-1-venkata.pyla@toshiba-tsip.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-OriginalArrivalTime: 07 Oct 2021 15:07:08.0270 (UTC) FILETIME=[FF3CA8E0:01D7BB8C] X-Original-Sender: venkata.pyla@toshiba-tsip.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of venkata.pyla@toshiba-tsip.com designates 210.130.202.158 as permitted sender) smtp.mailfrom=venkata.pyla@toshiba-tsip.com Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-getmail-retrieved-from-mailbox: INBOX From: venkata pyla /var/log/* files that are created during build stage and not owned by any package are not neccessary to be present in rootfs image, as these log files adds additional size to rootfs image, and also it create problems for reproducible build functionality. so this ROOTFS feature 'clean-log-files' should help to clean the log files when it is enalbed, disable it if we need the log files for debugging purpose. ROOTFS_FEATURE += clean-log-files Signed-off-by: venkata pyla --- meta/classes/image.bbclass | 2 +- meta/classes/rootfs.bbclass | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass index ec93cab..edabca3 100644 --- a/meta/classes/image.bbclass +++ b/meta/classes/image.bbclass @@ -63,7 +63,7 @@ image_do_mounts() { } ROOTFSDIR = "${IMAGE_ROOTFS}" -ROOTFS_FEATURES += "clean-package-cache generate-manifest export-dpkg-status" +ROOTFS_FEATURES += "clean-package-cache generate-manifest export-dpkg-status clean-log-files" ROOTFS_PACKAGES += "${IMAGE_PREINSTALL} ${IMAGE_INSTALL}" ROOTFS_MANIFEST_DEPLOY_DIR ?= "${DEPLOY_DIR_IMAGE}" ROOTFS_DPKGSTATUS_DEPLOY_DIR ?= "${DEPLOY_DIR_IMAGE}" diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass index f9151c5..20ccb00 100644 --- a/meta/classes/rootfs.bbclass +++ b/meta/classes/rootfs.bbclass @@ -12,6 +12,7 @@ ROOTFS_PACKAGES ?= "" # 'clean-package-cache' - delete package cache from rootfs # 'generate-manifest' - generate a package manifest of the rootfs into ${ROOTFS_MANIFEST_DEPLOY_DIR} # 'export-dpkg-status' - exports /var/lib/dpkg/status file to ${ROOTFS_DPKGSTATUS_DEPLOY_DIR} +# 'clean-log-files' - delete log files that are not owned by packages ROOTFS_FEATURES ?= "" ROOTFS_APT_ARGS="install --yes -o Debug::pkgProblemResolver=yes" @@ -213,6 +214,15 @@ rootfs_postprocess_clean_package_cache() { sudo rm -rf "${ROOTFSDIR}/var/lib/apt/lists/"* } +ROOTFS_POSTPROCESS_COMMAND += "${@bb.utils.contains('ROOTFS_FEATURES', 'clean-log-files', 'rootfs_postprocess_clean_log_files', '', d)}" +rootfs_postprocess_clean_log_files() { + # Delete log files that are not owned by packages + sudo -E chroot '${ROOTFSDIR}' \ + /usr/bin/find /var/log/ -type f \ + -exec sh -c '! dpkg -S {} > /dev/null 2>&1' ';' \ + -exec rm -f {} ';' +} + ROOTFS_POSTPROCESS_COMMAND += "${@bb.utils.contains('ROOTFS_FEATURES', 'generate-manifest', 'rootfs_generate_manifest', '', d)}" rootfs_generate_manifest () { mkdir -p ${ROOTFS_MANIFEST_DEPLOY_DIR}