From patchwork Wed Dec 14 11:49:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Roberto A. Foglietta" X-Patchwork-Id: 2320 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Wed, 14 Dec 2022 12:50:30 +0100 X-Sieve: CMU Sieve 2.4 Received: from mail-oo1-f58.google.com (mail-oo1-f58.google.com [209.85.161.58]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 2BEBoSoR006741 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Dec 2022 12:50:29 +0100 Received: by mail-oo1-f58.google.com with SMTP id v5-20020a056820004500b004a35517bb38sf5389940oob.18; Wed, 14 Dec 2022 03:50:29 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1671018623; cv=pass; d=google.com; s=arc-20160816; b=od14axcCusJebEhOUDS1pXVn4Ch1n+jZyVK9wxOWLxMlQ2Vdf0o1QikMHBQdeJVZNM nsLNcqxm+uojVJvgagsMCzwAah++K53QihMgvaT3/FWfneB1QdCJhT1oQkCHdTUrGrNs TVdLxytLAsexA2NwCywqXzwodMz/KFWmIiNxMXCZVgm1dELyqkik0LMGVqcA7Yu0VLhm twhnL2ZBLOoesW7Mrr+uc5LGa3h6aAttTmq9me2jDJDZNJO9S5YblupDVyUVQSh80Bkc Y8Pj+BUc2h96rXew+2eg5wnW+FiMRpMeHVXQC+lM8Ic/oRsdGs8luDQ0FwJpMoMcOLy1 R5ZA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:to:subject:message-id:date:from :mime-version:sender:dkim-signature:dkim-signature; bh=JdUNvI538vzjgzLZkohQB9Ng4zZhxFTeLyGPs1Ce5b0=; b=soe4ZcqnBn8tk1hlFhxRaQUJAAmUzUvG+tXA7CXZ4dWpTKaVIrk1Oc9fNibAh7FJem cKo5dE8xoEu02oJzXb+aqrSo5UKE9pzhhCDQ9P5zXENArDHKUXClLUj3IpVdW5rbRLzy IF+7GaUz4rw8cbakJMiOANzxb8Je1SBgW4x9WkEoNMJphM7pN0NKMaCjyGhElRzQJfPQ 7fUb8Ool+MJAQB0DbBiUc3ZcavJ/7+uQeFf3lUqHcVE+sM1hiuFXnqrfsOkOULvEtt58 ls+TZUUyPZHtH1FPjZE6HQU5RJ3yUMh59lfTAGTdAQtJ7ZxaQOzZqFjSqV+lvfBubsJv oMjg== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Gw2fV551; spf=pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::f2f as permitted sender) smtp.mailfrom=roberto.foglietta@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20210112; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:to:subject:message-id:date:from:mime-version :sender:from:to:cc:subject:date:message-id:reply-to; bh=JdUNvI538vzjgzLZkohQB9Ng4zZhxFTeLyGPs1Ce5b0=; b=MCf2AMet5rSOY0C14aCtTdYFH2CJndx+OGr14I4/9++4XAoaj0nHLHKyePMcJYCWhz CjnoF9APB3q8ibfiCZT7bheFQ22RrDu8jy3DB1p+3O5sAhKEBVpheZFWgI0wX/WxaAaL 815qGpu8+lqWX56ug15ky16AiAswBRcpTex5N3BFVWoxRiDJUkVTE1jB8DIJuEPsGs1/ 7RxdC9kmOFtmt6VWX2k8R84+aZBZW5ytkrjt6Y0b14RqsPRe9v8kKu2WFTPXYf9+C0oG Y11+6ARkIW0d2zUiVwWo+5EAqZal8eMp4P6vMOlhPzMW+R4iJaJJ3UuOQdIsjR1zEcRp YDQg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:to:subject:message-id:date:from:mime-version:from :to:cc:subject:date:message-id:reply-to; bh=JdUNvI538vzjgzLZkohQB9Ng4zZhxFTeLyGPs1Ce5b0=; b=LaKAgBK03/IPnJ4oIUHhfml9jjK/XK4AhP04U/9OcZBvj/A2erFm8QoOej21VNzlQn iQe4QmV+lloRd+Q6XqynClrkdyk4E+8d1UCGNrgJuXQFCwca7Yp/w2op33r1VYPpPuo2 zmuZHLCM332To2yH2R6Hcq8TnfPnWPfBFKnfU/OH9x4EnK4JNya8DfmMWilUWsfSsAxd mpiT8BNeEr1sNtB3GV+jc30cJlPkt2SNsSMfD9gZezYvVroCW7fuTFvYvfL7Q7FocFzv aaR6eh6ny/9RA/iRLwL/ox+AJfjV/YrUKOMqF3Et4YjbZG6GdVDvtToD7p9XJvx5Sddo uDIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:to:subject :message-id:date:from:mime-version:x-gm-message-state:sender:from:to :cc:subject:date:message-id:reply-to; bh=JdUNvI538vzjgzLZkohQB9Ng4zZhxFTeLyGPs1Ce5b0=; b=m823YTbxZjk8YA97WtkODPoO0nULmLelWMOU9Z72bf+MjVa28umuMPuYwkBGhooOhj PVCPP+YQwwf5/1tLnap4r0/or9sg/6+Rj0VaCslsnsdOUXGuqZ5ERvdZAnuFuOxyJuKj VpMoWhQAOsnedg8BECcsiTgvw65R9NSAs3YLZxG5+Gcdv2feu4oaLq+eyKHFZ2hw+VcN o4wdPhHoxgCQszSDGmiqmWrc3S4QKn0ozPD6KR/kfK27QcvnD4m9RAW/XoC7D6PH2X/Y hgyrRXxjE8mRw5gNrssQh8PDmxWuEEcgnW93cFDKUWJtM9i9zSypjYvSb4edjU8zbOqq ANHw== Sender: isar-users@googlegroups.com X-Gm-Message-State: AFqh2kq0/TiLfAYVc4Of5Of3UlaGIF47ur7F5y/Ka2iM7RY+KCbtQ8El y62DwvxawpQAEGarnjMW0Cc= X-Google-Smtp-Source: AMrXdXssKjaYuYOgVd4nAvUEOMaoHyp5otf4kGSkyhhgHWy2U9CcvYz2HTXltoj8+fkeyxaw0kbesg== X-Received: by 2002:a05:6870:7387:b0:148:a6a:e616 with SMTP id z7-20020a056870738700b001480a6ae616mr227348oam.63.1671018622994; Wed, 14 Dec 2022 03:50:22 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6870:e28f:b0:13d:173c:e583 with SMTP id v15-20020a056870e28f00b0013d173ce583ls6487265oad.0.-pod-prod-gmail; Wed, 14 Dec 2022 03:50:22 -0800 (PST) X-Received: by 2002:a05:6871:440b:b0:145:2d8:44c2 with SMTP id nd11-20020a056871440b00b0014502d844c2mr11288807oab.36.1671018622441; Wed, 14 Dec 2022 03:50:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671018622; cv=none; d=google.com; s=arc-20160816; b=Hxr+kDAKTwwsPUT+YKLO0B+FdlVs1CwggPDLWnfPCtmcQdtvx9vU8VJaSO1KLnw3PY P1MnlbtOoIRNCIQx2tSNKQ6vQxEYnfql/ssg0ndlo5kR1VrKSDDvzqdWyWu3gxTFRa8u Ql/5jiZqb6qku/UeiHbfVjdn+9fxxqzfJE5+vQpGHVI0Rc4HBN7xEU0Q/gKOVMmBFzIM VzPe+BKZEA1EaY3C6N9muOlRPINaBbQ5COp4N7jji2k2QWVEaaUYAF2829uNfElA5Ydo 4s+vwX7h7vlh/75KBeAoVkE2YoEKXgANXRqXJq9jNdprR1FDPRhxR7igsIaIQgLiQqjw jNVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=to:subject:message-id:date:from:mime-version:dkim-signature; bh=z5T616r+oTj1K92X4bZNXg/XSq8i1XswwG5xMDdJh8c=; b=Ez8rFlldkC/++3K9dbSMyZHjQ5O4wE4Z3i1TXGZz1pP0KWeSv3N7hclVHjhBw1+lgq +EULTY3v7Ru21iJl8rvdrJ4BRe665yQX8uOe+Hahz9CU/gqejFRO3reJ+HnKZhC/0kPS ZiaHSP4ugehaAYkYDa24cb4xGHulviq+WLccK6lbDONS71sC+TgXkcR+yW2hwKWdXERw 4KKDxG+tcfEVK+Z5vb7MBWSvl1zZgz2dhAo4hWIcJ3d9uIdf6dIIGI4xqla8RDWNHB8l 4Blc0b+C4a30dwrFAyDrvht7a6xgUt6VJBUU9sHdCLe+ZgnsCvI/liK9Fqft69LtucbP W3bA== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Gw2fV551; spf=pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::f2f as permitted sender) smtp.mailfrom=roberto.foglietta@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com. [2607:f8b0:4864:20::f2f]) by gmr-mx.google.com with ESMTPS id v6-20020a056870310600b00141f024fbbdsi652779oaa.5.2022.12.14.03.50.22 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Dec 2022 03:50:22 -0800 (PST) Received-SPF: pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::f2f as permitted sender) client-ip=2607:f8b0:4864:20::f2f; Received: by mail-qv1-xf2f.google.com with SMTP id d13so12355132qvj.8 for ; Wed, 14 Dec 2022 03:50:22 -0800 (PST) X-Received: by 2002:a0c:f80a:0:b0:4d8:8f4e:3a3b with SMTP id r10-20020a0cf80a000000b004d88f4e3a3bmr1083523qvn.16.1671018621590; Wed, 14 Dec 2022 03:50:21 -0800 (PST) MIME-Version: 1.0 From: "Roberto A. Foglietta" Date: Wed, 14 Dec 2022 12:49:44 +0100 Message-ID: Subject: [PATCH] In expand last partition checking the size is useless To: isar-users@googlegroups.com X-Original-Sender: roberto.foglietta@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Gw2fV551; spf=pass (google.com: domain of roberto.foglietta@gmail.com designates 2607:f8b0:4864:20::f2f as permitted sender) smtp.mailfrom=roberto.foglietta@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= code maintenance, superfluous operations commented, kept for the future Tests shown that resize in full a ext4 or btrfs partition/filesystem does not hurt and does not report a failure, so nothing changes without the size check Patch sent by elastic mail SMTP went into moderation, attached here Best, R- From c0d56a45db8a38f7121a13eff4e68c10a6cf0db7 Mon Sep 17 00:00:00 2001 From: "Roberto A. Foglietta" Date: Wed, 14 Dec 2022 12:37:26 +0100 Subject: [PATCH] In expand last partition checking the size is useless code maintenance, superflous operations commented, kept for the future Tests shown that resize in full a ext4 or btrfs partition/filesystem does not hurt and does not report a failure, so nothing changes without the size check Signed-off-by: Roberto A. Foglietta --- .../files/expand-last-partition.sh | 34 +++++++++++-------- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh b/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh index 2c52b16..4d36733 100755 --- a/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh +++ b/meta/recipes-support/expand-on-first-boot/files/expand-last-partition.sh @@ -27,22 +27,26 @@ if [ "${ROOT_DEV}" = "${BOOT_DEV}" ]; then exit 0 fi -# this value is in blocks. Normally a block has 512 bytes. -BUFFER_SIZE=32768 -BOOT_DEV_NAME=${BOOT_DEV##*/} -DISK_SIZE="$(cat /sys/class/block/"${BOOT_DEV_NAME}"/size)" -ALL_PARTS_SIZE=0 -for PARTITION in /sys/class/block/"${BOOT_DEV_NAME}"/"${BOOT_DEV_NAME}"*; do - PART_SIZE=$(cat "${PARTITION}"/size) - ALL_PARTS_SIZE=$((ALL_PARTS_SIZE + PART_SIZE)) -done +# full resizing of ext4 and btrfs does not fail nor hurt but supporting more +# filesystems in future might change this condition, so commenting this code +useless_for_now() { + # this value is in blocks. Normally a block has 512 bytes. + BUFFER_SIZE=32768 + BOOT_DEV_NAME=${BOOT_DEV##*/} + DISK_SIZE="$(cat /sys/class/block/"${BOOT_DEV_NAME}"/size)" + ALL_PARTS_SIZE=0 + for PARTITION in /sys/class/block/"${BOOT_DEV_NAME}"/"${BOOT_DEV_NAME}"*; do + PART_SIZE=$(cat "${PARTITION}"/size) + ALL_PARTS_SIZE=$((ALL_PARTS_SIZE + PART_SIZE)) + done -MINIMAL_SIZE=$((ALL_PARTS_SIZE + BUFFER_SIZE)) -if [ "$DISK_SIZE" -lt "$MINIMAL_SIZE" ]; then - echo "Disk is practically already full, doing nothing." >&2 - trap - EXIT - exit 0 -fi + MINIMAL_SIZE=$((ALL_PARTS_SIZE + BUFFER_SIZE)) + if [ "$DISK_SIZE" -lt "$MINIMAL_SIZE" ]; then + echo "Disk is practically already full, doing nothing." >&2 + trap - EXIT + exit 0 + fi +} LAST_PART="$(sfdisk -d "${BOOT_DEV}" 2>/dev/null | tail -1 | cut -d ' ' -f 1)" -- 2.34.1