From patchwork Mon May 22 04:41:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinuvasan Arjunan X-Patchwork-Id: 2817 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Mon, 22 May 2023 06:41:48 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-lf1-f56.google.com (mail-lf1-f56.google.com [209.85.167.56]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 34M4fmii012315 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 22 May 2023 06:41:48 +0200 Received: by mail-lf1-f56.google.com with SMTP id 2adb3069b0e04-4f3b18ee692sf1168892e87.3; Sun, 21 May 2023 21:41:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1684730502; cv=pass; d=google.com; s=arc-20160816; b=OdRSFgstR9ckTuJJx0JcCPTMT+XC/wNVX/G6va1F4sTLzsNmWuY3fZPl2AoyiWymBe /uz+MB75WJ84geFmcmeS4OmhfMGSLTQ+ktU6ngj3MBuLJybklE9QiqA2UOAP9GLkE/J3 TY4qoDcOt1MH+FtJd1QNb7laiwqHUBKst/lW66goioy1NC3JYHLfFjjBqQTfKDue2bqK OoyCXBGWxqRZzgl027NcLz8fWAlS4SMaCarodweHNXcvctJHD1WFxeyHbbkpK2ERnkk3 jBbLW34zUpJHQKDKdxw1/f/CLvt+wM09bSzVrdr4TUgTUq3Y8qA1oCaTrm0FJuaiMwu2 dskQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:message-id:date :subject:cc:to:from:ironport-sdr:sender:dkim-signature; bh=c0h7J8z/IR/yfZv4f0w4Nq+KPU9Y4+ttfMSefRp4tcI=; b=N1ifiDkXQaXMFKpxQhZy39661FYyC6gEFdr2G8s4QN2NDymz7MjhNprfa0hN4ku87C TG+r/ymAWg7ef5R3EoKPeMp7R7NeX1510zmpYY79IuG2sDbaRaZVECETwP1NHSGR6bOR peDbtDdSpQ4rKNX9m8iGaXP4rUVoG4YBm9aW/1wyNXPFkNRItm1T6I7efI6+puhlAV69 gkwQsV+Gv5+gWSrpt+hQQ+XmFxFyDNqkI+GK4mOC2O5lhlwdk1TUxQbH3TpeaggQgoY5 Ug0aqYNygSaSJjXOe5Wl1POf99rEGzQ+iuz/9IfTzZsQ/vt9aWvCOW3/HPZDFf9b61Ce RDFg== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of srinuvasan_a@mentor.com designates 68.232.137.252 as permitted sender) smtp.mailfrom=Srinuvasan_A@mentor.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20221208; t=1684730502; x=1687322502; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:message-id:date:subject:cc:to:from :ironport-sdr:sender:from:to:cc:subject:date:message-id:reply-to; bh=c0h7J8z/IR/yfZv4f0w4Nq+KPU9Y4+ttfMSefRp4tcI=; b=Qf2PAKeBTQl/AXYSmDL0pit66jnc4uG43UINoX6WLK1Ia4Wwq6p/zLTxmFWB80Pzo5 sTFn9HF3TxZ7LVGNEIFXunNZuoa2Bm86r1FRv4LlkgTfvw7IfuzLZ+3Plx0W97QpTW9F StUJ0iFEB0R8/I+OJY06Ct+GUTdURilnUT1vJKBSaA6V2+YO/oib6U/1j9tKqA6Du/y4 VhzBHOTc724icKtwk5NcDAdUKG3zdx2frwSJzPMnbEZgTHUm5phBkuP6ndAVoCroRIQE AtqII8cE0bIvDXT//1MlaVzhvsV38QWNhA3uX/ADyxR6aprsdfXPiSAgTs4k4ftFUsK0 akRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684730502; x=1687322502; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :message-id:date:subject:cc:to:from:ironport-sdr:x-beenthere :x-gm-message-state:sender:from:to:cc:subject:date:message-id :reply-to; bh=c0h7J8z/IR/yfZv4f0w4Nq+KPU9Y4+ttfMSefRp4tcI=; b=R4LPthrlp76EA8oVz+SPD4su9Xpd/DaLOCLJCR5ww9vcF83bMbcMCbJ/NMKePZ2Qx4 R7/tUML0A6sCsmFfj10GNQz8ROVOe6gyxB0v0M4WWbkyGd19MncQd7Sd+8zBu1gDpDbD 5hryVXdnFElCbjYE23NAP2Yb39+1uVBM+AD2UyR5DjS2znz46S4+x1+58PN+K2yUloH5 y+lmLtZ3zoWpcWRb5X9NXOZTTAMdj1dkfFDbUm5RIsDK6t/SD/wNje4kOYq1voQpU7DF uDhZmJRz2oWvoDZ/CGoUnXxmJkL34d532aLmmUGuu9AjKwwbAyFWbYzH+UBtY8NMjPVi SlGA== Sender: isar-users@googlegroups.com X-Gm-Message-State: AC+VfDwvwr5lweEAicgUAg3HWNnD8Fj6mKvqD/anlzJym8QM5Hxd46yt 48BZkhCZ1KyQZ/9cHYiOM8s= X-Google-Smtp-Source: ACHHUZ721/qOFrSQm+6MIM2QNzVQj6SE+BJdV2vr6W0vVB2SQA9U2HSWt+44GR48KMzdx2PPMH8Lhw== X-Received: by 2002:a05:6512:515:b0:4f3:a483:55f with SMTP id o21-20020a056512051500b004f3a483055fmr2091291lfb.4.1684730501846; Sun, 21 May 2023 21:41:41 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:651c:1597:b0:2ad:a1ce:ff1b with SMTP id h23-20020a05651c159700b002ada1ceff1bls938239ljq.0.-pod-prod-02-eu; Sun, 21 May 2023 21:41:40 -0700 (PDT) X-Received: by 2002:a05:651c:1035:b0:2b0:297c:cbdf with SMTP id w21-20020a05651c103500b002b0297ccbdfmr222688ljm.1.1684730500365; Sun, 21 May 2023 21:41:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684730500; cv=none; d=google.com; s=arc-20160816; b=vzyxqRZEbtnImfGi5FxMOV7zC5r3WWMGBXgshot7G6fb95LhLiiinCnOSRieAuVD1V frduTcj3Jy/MEPp3BMlwPqg3pEZ5m9VvD0dG+qDpfRSt5JaW6re17stHreuiHCXbl73O OgluSofWnbZ5MBhd+GFJrsB/Aa5phB2p2/mRiG2+uiexJwaF9BnCbZzyf1dhI/QWAIO4 5h6twkPa85OB8lM6t6jU+Bmik3amLtZYUEGjJ2io7UQIwXagZ49TEwTfdk8pojCxsSA3 Wgr8qdaE1fknjQP5D0XdNFZoBtU1A/Gskp55rWHiEq7g+COLf6NAsHB0TIV7zyJC/B/g k40Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:ironport-sdr; bh=7GQo3t/Atuyt3rreA4hkEHsABtLjMDOBz3xAHKc/PuY=; b=twkrItbaPSp///f8osGktYNkyIk0d6ZqB0yv0L+UXX5cEPsjnw0xkR/hLkAqJm9ZB2 jmHNIWK0ZsxV6ZGwiEY8sLnvlIpRxULSObx4WSBp37Tka3bi7GOY1p5jajjE9W6meFCV 7VT77aTvm5f8M/I1JSUpmo0Kc5jD5c7cS+2v0gzYKrgMkKiBCvuSPgA8ldYEuxm13eZD PGLRSM3HyfgRpZp2eIpqHB4Pbg+wif3NthNQvw2+nccMcCv4l6vx3CKPUYIxvflblKTy aVjmk5R0x2WYC6c6R2/PTAEe/enUkKL0asDF7tMVqTaXX+kiBPmJ0ApAznDx+g5kvKyw yuLg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of srinuvasan_a@mentor.com designates 68.232.137.252 as permitted sender) smtp.mailfrom=Srinuvasan_A@mentor.com Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com. [68.232.137.252]) by gmr-mx.google.com with ESMTPS id bx35-20020a05651c19a300b002af15d1ad3asi295253ljb.8.2023.05.21.21.41.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 May 2023 21:41:40 -0700 (PDT) Received-SPF: pass (google.com: domain of srinuvasan_a@mentor.com designates 68.232.137.252 as permitted sender) client-ip=68.232.137.252; X-IronPort-AV: E=Sophos;i="6.00,183,1681200000"; d="scan'208";a="6089003" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 21 May 2023 20:41:37 -0800 IronPort-SDR: xRzsiocXguuHR6NE+2zmZo4BiXqojF+YicInSNgQ89RKljiF8ZSjxPN+vDxo8Jm/oepOJ8B13Y y3LxkMggAg6akhbzNi8N03iMrvJc4G/0l4ksL1sUaw0c+pgAOQmvanSkWIkNyaCXpGmtsCnIzn h5qW+lSQhZxeF6Xzm88kMNlUUmL3wtiMdWd30GDcz8NJIQghhc5oaA8rB/zCgfpLTDSO+P1IIN CLgEgEO27YMWLudpnYpYiBAzGGiEDyK1xSNVCmHFIgp4Lguy101OEa562/+Ht+pVv9QroEvGh+ Mi4= From: Srinuvasan Arjunan To: CC: , , Srinuvasan A Subject: [PATCH] crossvars.bbclass: use d.appendVar instead of d.setVar for SDK_TOOLCHAIN variable Date: Mon, 22 May 2023 10:11:17 +0530 Message-ID: <20230522044117.1698718-1-srinuvasan_a@mentor.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-ClientProxiedBy: svr-orw-mbx-11.mgc.mentorg.com (147.34.90.211) To svr-orw-mbx-13.mgc.mentorg.com (147.34.90.213) X-Original-Sender: srinuvasan_a@mentor.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of srinuvasan_a@mentor.com designates 68.232.137.252 as permitted sender) smtp.mailfrom=Srinuvasan_A@mentor.com Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= From: Srinuvasan A In downstream layer we may override the sdk_toolchain, but this not works as expected in latest ISAR, the reason behind this as they moved toolchain selection into python Anonymous function. Anonymous Python functions always run at the end of parsing, regardless of where they are defined even when we do override in our recipe, always wins the Anonymous Python functions variable settings, hence change to d.appendVar instead of d.setVar in sdk toolchain selection, so downstream layer they can modify the SDK_TOOLCHAIN list if needed (append/remove). Signed-off-by: Srinuvasan A --- meta/classes/crossvars.bbclass | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/classes/crossvars.bbclass b/meta/classes/crossvars.bbclass index 201d460..5a3edc4 100644 --- a/meta/classes/crossvars.bbclass +++ b/meta/classes/crossvars.bbclass @@ -17,7 +17,7 @@ python __anonymous() { sbuild_dep = "sbuild-chroot-target:do_build" buildchroot_dir = d.getVar('BUILDCHROOT_TARGET_DIR', False) buildchroot_dep = "buildchroot-target:do_build" - sdk_toolchain = "build-essential" + sdk_toolchain = " build-essential" else: d.setVar('BUILD_HOST_ARCH', d.getVar('HOST_ARCH')) schroot_dir = d.getVar('SCHROOT_HOST_DIR', False) @@ -31,5 +31,5 @@ python __anonymous() { d.setVar('BUILDCHROOT_DEP', buildchroot_dep) if isar_can_build_compat(d): sdk_toolchain += " crossbuild-essential-" + d.getVar('COMPAT_DISTRO_ARCH') - d.setVar('SDK_TOOLCHAIN', sdk_toolchain) + d.appendVar('SDK_TOOLCHAIN', sdk_toolchain) }