| Message ID | 20260806073945.109787-1-wzh@ilbers.de |
|---|---|
| State | Under Review |
| Headers | show |
| Series | testsuite: Drop unnecessary tmp dir moving in CrossTest | expand |
On Thu, 2026-08-06 at 09:39 +0200, Zhihang Wei wrote: > Testing showed that moving the tem dir is unnecessary. Thanks! I'm anyways wondering if we could clean up the tmpdir after a successful build? I briefly looked into it, but it seems like avocado does not support a teardown hook on class level, so we probably want to have a cleanup job which runs last in each test class. I still have a couple other improvements to the testsuite that make it much faster and less disk space hungry. But even with that, a full run still occupies around 500GB of disk space. Felix > > Signed-off-by: Zhihang Wei <wzh@ilbers.de> > --- > testsuite/citest.py | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/testsuite/citest.py b/testsuite/citest.py > index fcd08c95..3ab8b557 100644 > --- a/testsuite/citest.py > +++ b/testsuite/citest.py > @@ -558,9 +558,7 @@ class CrossTest(CIBaseTest): > ] > > self.init() > - self.move_in_build_dir('tmp', 'tmp_cross') > self.perform_build_test(targets) > - self.move_in_build_dir('tmp', 'tmp_cross_mira_trixie') > > class PrebuiltTest(CIBaseTest): > """ > -- > 2.39.5 > > -- > You received this message because you are subscribed to the Google Groups "isar-users" group. > To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. > To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260806073945.109787-1-wzh%40ilbers.de.
On 8/6/26 09:52, MOESSBAUER, Felix wrote: > On Thu, 2026-08-06 at 09:39 +0200, Zhihang Wei wrote: >> Testing showed that moving the tem dir is unnecessary. > Thanks! > > I'm anyways wondering if we could clean up the tmpdir after a > successful build? I briefly looked into it, but it seems like avocado > does not support a teardown hook on class level, so we probably want to > have a cleanup job which runs last in each test class. I'm not against a cleanup, as long as it's optional and can be set via local settings. Zhihang > I still have a couple other improvements to the testsuite that make it > much faster and less disk space hungry. But even with that, a full run > still occupies around 500GB of disk space. > > Felix > >> Signed-off-by: Zhihang Wei <wzh@ilbers.de> >> --- >> testsuite/citest.py | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/testsuite/citest.py b/testsuite/citest.py >> index fcd08c95..3ab8b557 100644 >> --- a/testsuite/citest.py >> +++ b/testsuite/citest.py >> @@ -558,9 +558,7 @@ class CrossTest(CIBaseTest): >> ] >> >> self.init() >> - self.move_in_build_dir('tmp', 'tmp_cross') >> self.perform_build_test(targets) >> - self.move_in_build_dir('tmp', 'tmp_cross_mira_trixie') >> >> class PrebuiltTest(CIBaseTest): >> """ >> -- >> 2.39.5 >> >> -- >> You received this message because you are subscribed to the Google Groups "isar-users" group. >> To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. >> To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260806073945.109787-1-wzh%40ilbers.de.
diff --git a/testsuite/citest.py b/testsuite/citest.py index fcd08c95..3ab8b557 100644 --- a/testsuite/citest.py +++ b/testsuite/citest.py @@ -558,9 +558,7 @@ class CrossTest(CIBaseTest): ] self.init() - self.move_in_build_dir('tmp', 'tmp_cross') self.perform_build_test(targets) - self.move_in_build_dir('tmp', 'tmp_cross_mira_trixie') class PrebuiltTest(CIBaseTest): """
Testing showed that moving the tem dir is unnecessary. Signed-off-by: Zhihang Wei <wzh@ilbers.de> --- testsuite/citest.py | 2 -- 1 file changed, 2 deletions(-)