mbox series

[0/4] Allow better control over container tags

Message ID 20210728152210.7089-1-henning.schild@siemens.com
Headers show
Series Allow better control over container tags | expand

Message

Henning Schild July 28, 2021, 7:22 a.m. UTC 
A container tags consists of "name:tag" and both have been kind of
hardcoded so far. "tag" was always "latest" which is not proper
versioning. And "name" has always been "isar-DISTRO-ARCH" which is also
not proper because the name should probably describe the content and not
so much the build system. Plus that name means guaranteed collision if
you build two containers with isar based on the same disto and arch.

p3 is kind of interface breaking, i may have forgotten some docs and
stuff

Henning Schild (4):
  classes: make sure container extension can run multiple times
  classes: simplify tag handling in container class
  classes: allow more control over container image name and tag
  classes: fix comment in container-img class

 meta/classes/container-img.bbclass            |  6 ++---
 .../classes/image-container-extension.bbclass | 25 ++++++++++---------
 meta/classes/image-sdk-extension.bbclass      |  2 +-
 3 files changed, 16 insertions(+), 17 deletions(-)

Comments

Henning Schild July 28, 2021, 7:23 a.m. UTC | #1 
This can also be found here:
 https://github.com/henning-schild-work/isar/tree/henning/staging

And so that CI picks it up here:
 https://github.com/henning-schild-work/isar/tree/henning/ilbers-ci

Henning

Am Wed, 28 Jul 2021 17:22:06 +0200
schrieb Henning Schild <henning.schild@siemens.com>:

> A container tags consists of "name:tag" and both have been kind of
> hardcoded so far. "tag" was always "latest" which is not proper
> versioning. And "name" has always been "isar-DISTRO-ARCH" which is
> also not proper because the name should probably describe the content
> and not so much the build system. Plus that name means guaranteed
> collision if you build two containers with isar based on the same
> disto and arch.
> 
> p3 is kind of interface breaking, i may have forgotten some docs and
> stuff
> 
> Henning Schild (4):
>   classes: make sure container extension can run multiple times
>   classes: simplify tag handling in container class
>   classes: allow more control over container image name and tag
>   classes: fix comment in container-img class
> 
>  meta/classes/container-img.bbclass            |  6 ++---
>  .../classes/image-container-extension.bbclass | 25
> ++++++++++--------- meta/classes/image-sdk-extension.bbclass      |
> 2 +- 3 files changed, 16 insertions(+), 17 deletions(-)
>
Silvano Cirujano Cuesta July 29, 2021, 4:58 a.m. UTC | #2 
Apart from the comment to Patch 3 regarding the breaking change that the default would produce that need some clarification, it looks good to me.

In any case, as you mention yourself, the breaking change (either direct on the application of the patch or later) needs to be well documented and announced. Also the variables CONTAINER_NAME and CONTAINER_TAG need to be documented.

Cheers,
  Silvano

On 28/07/2021 17:22, Henning Schild wrote:
> A container tags consists of "name:tag" and both have been kind of
> hardcoded so far. "tag" was always "latest" which is not proper
> versioning. And "name" has always been "isar-DISTRO-ARCH" which is also
> not proper because the name should probably describe the content and not
> so much the build system. Plus that name means guaranteed collision if
> you build two containers with isar based on the same disto and arch.
> 
> p3 is kind of interface breaking, i may have forgotten some docs and
> stuff
> 
> Henning Schild (4):
>   classes: make sure container extension can run multiple times
>   classes: simplify tag handling in container class
>   classes: allow more control over container image name and tag
>   classes: fix comment in container-img class
> 
>  meta/classes/container-img.bbclass            |  6 ++---
>  .../classes/image-container-extension.bbclass | 25 ++++++++++---------
>  meta/classes/image-sdk-extension.bbclass      |  2 +-
>  3 files changed, 16 insertions(+), 17 deletions(-)
>